depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2013-10-02	Fix segfault in nix-repl / hydra-eval-jobs	Eelco Dolstra	1	-3/+3
	If a "with" attribute set fails to evaluate, we have to make sure its Env record remains unchanged. Otherwise, repeated evaluation gives a segfault: nix-repl> :a with 0; { a = x; b = x; } Added 2 variables. nix-repl> a error: value is an integer while an attribute set was expected nix-repl> b Segmentation fault
2013-10-02	Report OOM errors better	Eelco Dolstra	2	-1/+8

2013-10-02	Fix typo	Eelco Dolstra	1	-1/+1

2013-09-17	RestoreSink: Slightly reduce the number of concurrent FDs	Eelco Dolstra	1	-0/+1

2013-09-06	Remove stray debug line	Eelco Dolstra	1	-2/+0

2013-09-06	Don't apply the CPU affinity hack to nix-shell (and other Perl programs)	Eelco Dolstra	4	-7/+10
	As discovered by Todd Veldhuizen, the shell started by nix-shell has its affinity set to a single CPU. This is because nix-shell connects to the Nix daemon, which causes the affinity hack to be applied. So we turn this off for Perl programs.
2013-09-03	nix-env -i: Add a flag ‘--remove-all’ / ‘-r’	Eelco Dolstra	1	-17/+25
	This is equivalent to running ‘nix-env -e '*'’ first, except that it happens in a single transaction. Thus, ‘nix-env -i pkgs...’ replaces the profile with the specified set of packages. The main motivation is to support declarative package management (similar to environment.systemPackages in NixOS). That is, if you have a specification ‘profile.nix’ like this: with import <nixpkgs> {}; [ thunderbird geeqie ... ] then after any change to ‘profile.nix’, you can run: $ nix-env -f profile.nix -ir to update the profile to match the specification. (Without the ‘-r’ flag, if you remove a package from ‘profile.nix’, it won't be removed from the actual profile.) Suggested by @zefhemel.
2013-09-03	nix-env: Use wildcard match by default	Eelco Dolstra	2	-13/+8
	That is, you don't need to pass '' anymore, so nix-env -qa is equivalent to nix-env -qa ''
2013-09-03	nix-env: Load files in ~/.nix-defexpr on demand	Eelco Dolstra	3	-3/+18
	So if you do "nix-env -qa -A nixos", then other channels won't be parsed/evaluated at all.
2013-09-03	Check for name collisions in the input Nix expressions	Eelco Dolstra	1	-3/+9

2013-09-03	Work on Values instead of Exprs	Eelco Dolstra	4	-50/+62
	This prevents some duplicate evaluation in nix-env and nix-instantiate. Also, when traversing ~/.nix-defexpr, only read regular files with the extension .nix. Previously it was reading files like .../channels/binary-caches/<name>. The only reason this didn't cause problems is pure luck (namely, <name> shadows an actual Nix expression, the binary-caches files happen to be syntactically valid Nix expressions, and we iterate over the directory contents in just the right order).
2013-09-03	Reformat	Eelco Dolstra	1	-33/+35

2013-09-03	Get rid of the parse tree cache	Eelco Dolstra	6	-34/+35
	Since we already cache files in normal form (fileEvalCache), caching parse trees is redundant. Note that getting rid of this cache doesn't actually save much memory at the moment, because parse trees are currently not freed / GC'ed.
2013-09-02	Add some support code for nix-repl	Eelco Dolstra	3	-12/+26

2013-09-02	Get rid of a signedness warning	Eelco Dolstra	1	-1/+1

2013-09-02	Fix whitespace	Eelco Dolstra	8	-82/+82

2013-09-02	Only show trace messages when tracing is enabled	Eelco Dolstra	1	-4/+3

2013-09-02	Add an option to limit the log output of builders	Eelco Dolstra	3	-0/+19
	This is mostly useful for Hydra to deal with builders that get stuck in an infinite loop writing data to stdout/stderr.
2013-08-26	Simplify inherited attribute handling	Shea Levy	5	-38/+21
	This reduces the difference between inherited and non-inherited attribute handling to the choice of which env to use (in recs and lets) by setting the AttrDef::e to a new ExprVar in the parser rather than carrying a separate AttrDef::v VarRef member. As an added bonus, this allows inherited attributes that inherit from a with to delay forcing evaluation of the with's attributes. Signed-off-by: Shea Levy <shea@shealevy.com>
2013-08-26	Fix typos, especially those that end up in the Nix manual	Ivan Kozik	6	-7/+7

2013-08-26	Fix personality switching from x86_64 to i686	Gergely Risko	1	-1/+6
	On Linux, Nix can build i686 packages even on x86_64 systems. It's not enough to recognize this situation by settings.thisSystem, we also have to consult uname(). E.g. we can be running on a i686 Debian with an amd64 kernel. In that situation settings.thisSystem is i686-linux, but we still need to change personality to i686 to make builds consistent.
2013-08-19	Store Nix integers as longs	Eelco Dolstra	9	-23/+25
	So on 64-bit systems, integers are now 64-bit. Fixes #158.
2013-08-14	Typo	Eelco Dolstra	1	-1/+1

2013-08-07	Respect MINSIGSTKSZ when allocating an alternative stack	Eelco Dolstra	1	-1/+1
	http://hydra.nixos.org/build/5663577
2013-08-07	Fix build on non-Linux	Eelco Dolstra	1	-0/+2
	http://hydra.nixos.org/build/5662914
2013-08-07	Run the daemon worker on the same CPU as the client	Eelco Dolstra	8	-4/+88
	On a system with multiple CPUs, running Nix operations through the daemon is significantly slower than "direct" mode: $ NIX_REMOTE= nix-instantiate '<nixos>' -A system real 0m0.974s user 0m0.875s sys 0m0.088s $ NIX_REMOTE=daemon nix-instantiate '<nixos>' -A system real 0m2.118s user 0m1.463s sys 0m0.218s The main reason seems to be that the client and the worker get moved to a different CPU after every call to the worker. This patch adds a hack to lock them to the same CPU. With this, the overhead of going through the daemon is very small: $ NIX_REMOTE=daemon nix-instantiate '<nixos>' -A system real 0m1.074s user 0m0.809s sys 0m0.098s
2013-08-06	Remove obsolete reference to ATerms	Eelco Dolstra	1	-3/+3

2013-08-02	In the profiler output, show function names (if available)	Eelco Dolstra	2	-8/+8

2013-08-02	Let the ordering operators also work on strings	Eelco Dolstra	1	-3/+6
	E.g. ‘"foo" < "bar"’ now works.
2013-08-02	Add comparison operators ‘<’, ‘<=’, ‘>’ and ‘>=’	Eelco Dolstra	2	-0/+7

2013-08-02	Add integer ‘-’, ‘*’ and ‘/’ operators	Eelco Dolstra	1	-1/+5

2013-08-02	Add a unary integer negation operator	Eelco Dolstra	1	-2/+4
	This allows saying "-1" instead of "builtins.sub 0 1".
2013-08-02	Overload the ‘+’ operator to support integer addition	Eelco Dolstra	1	-11/+19

2013-07-31	Make Env smaller	Eelco Dolstra	2	-21/+23
	Commit 20866a7031ca823055a221653b77986faa167329 added a ‘withAttrs’ field to Env, which is annoying because it makes every Env structure bigger and we allocate millions of them. E.g. NixOS evaluation took 18 MiB more. So this commit squeezes ‘withAttrs’ into values[0]. Probably should use a union...
2013-07-31	Don't use NULL	Eelco Dolstra	1	-4/+2

2013-07-31	Avoid thunks when a fromWith var can be looked up without evaluation	Shea Levy	2	-8/+8
	Signed-off-by: Shea Levy <shea@shealevy.com>
2013-07-31	Delay evaulation of `with` attrs until a variable lookup needs them	Shea Levy	2	-7/+13
	Evaluation of attribute sets is strict in the attribute names, which means immediate evaluation of `with` attribute sets rules out some potentially interesting use cases (e.g. where the attribute names of one set depend in some way on another but we want to bring those names into scope for some values in the second set). The major example of this is overridable self-referential package sets (e.g. all-packages.nix). With immediate `with` evaluation, the only options for such sets are to either make them non-recursive and explicitly use the name of the overridden set in non-overridden one every time you want to reference another package, or make the set recursive and use the `__overrides` hack. As shown in the test case that comes with this commit, though, delayed `with` evaluation allows a nicer third alternative. Signed-off-by: Shea Levy <shea@shealevy.com>
2013-07-30	Detect stack overflows	Eelco Dolstra	3	-1/+80
	Previously, if the Nix evaluator gets a stack overflow due to a deep or infinite recursion in the Nix expression, the user gets an unhelpful message ("Segmentation fault") that doesn't indicate that the problem is in the user's code rather than Nix itself. Now it prints: error: stack overflow (possible infinite recursion) This only works on x86_64-linux and i686-linux. Fixes #35.
2013-07-30	killUser: Don't let the child kill itself on Apple	Shea Levy	1	-0/+13
	The kill(2) in Apple's libc follows POSIX semantics, which means that kill(-1, SIGKILL) will kill the calling process too. Since nix has no way to distinguish between the process successfully killing everything and the process being killed by a rogue builder in that case, it can't safely conclude that killUser was successful. Luckily, the actual kill syscall takes a parameter that determines whether POSIX semantics are followed, so we can call that syscall directly and avoid the issue on Apple. Signed-off-by: Shea Levy <shea@shealevy.com>
2013-07-18	Revert "build-remote.pl: Enforce timeouts locally"	Eelco Dolstra	1	-1/+3
	This reverts commit 69b8f9980f39c14a59365a188b300a34d625a2cd. The timeout should be enforced remotely. Otherwise, if the garbage collector is running either locally or remotely, if will block the build or closure copying for some time. If the garbage collector takes too long, the build may time out, which is not what we want. Also, on heavily loaded systems, copying large paths to and from the remote machine can take a long time, also potentially resulting in a timeout.
2013-07-15	Allow bind-mounting regular files into the chroot	Shea Levy	1	-1/+9
	mount(2) with MS_BIND allows mounting a regular file on top of a regular file, so there's no reason to only bind directories. This allows finer control over just which files are and aren't included in the chroot without having to build symlink trees or the like. Signed-off-by: Shea Levy <shea@shealevy.com>
2013-07-12	Garbage collector: Don't follow symlinks arbitrarily	Eelco Dolstra	4	-45/+53
	Only indirect roots (symlinks to symlinks to the Nix store) are now supported.
2013-07-07	Leave `HAVE_HUP_NOTIFICATION' undefined on GNU/Hurd.	Ludovic Courtès	1	-2/+7

2013-06-20	Don't set $preferLocalBuild and $requiredSystemFeatures in builders	Eelco Dolstra	2	-8/+15
	With C++ std::map, doing a comparison like ‘map["foo"] == ...’ has the side-effect of adding a mapping from "foo" to the empty string if "foo" doesn't exist in the map. So we ended up setting some environment variables by accident.
2013-06-20	Don't substitute derivations that have preferLocalBuild set	Eelco Dolstra	3	-7/+15
	In particular this means that "trivial" derivations such as writeText are not substituted, reducing the number of GET requests to the binary cache by about 200 on a typical NixOS configuration.
2013-06-20	Increase SQLite's auto-checkpoint interval	Eelco Dolstra	1	-2/+2
	Common operations like instantiating a NixOS system config no longer fitted in 8192 pages, leading to more fsyncs. So increase this limit.
2013-06-20	Disable the copy-from-other-stores substituter	Eelco Dolstra	1	-0/+2
	This substituter basically cannot work reliably since we switched to SQLite, since SQLite databases may need write access to open them even just for reading (and in WAL mode they always do).
2013-06-20	Don't keep "disabled" substituters running	Eelco Dolstra	3	-2/+28
	For instance, it's pointless to keep copy-from-other-stores running if there are no other stores, or download-using-manifests if there are no manifests. This also speeds things up because we don't send queries to those substituters.
2013-06-13	Allow hard links between the outputs of a derivation	Eelco Dolstra	3	-9/+20

2013-06-13	Fix a security bug in hash rewriting	Eelco Dolstra	1	-0/+6
	Before calling dumpPath(), we have to make sure the files are owned by the build user. Otherwise, the build could contain a hard link to (say) /etc/shadow, which would then be read by the daemon and rewritten as a world-readable file. This only affects systems that don't have hard link restrictions enabled.