depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2011-08-06	* Cache the result of file evaluation (i.e, memoize evalFile()). This	Eelco Dolstra	2	-11/+22
	prevents files from being evaluated and stored as values multiple times. For instance, evaluation of the ‘system’ attribute in NixOS causes ‘nixpkgs/pkgs/lib/lists.nix’ to be evaluated 2019 times. Caching gives a modest speedup and a decent memory footprint reduction (e.g., from 1.44s to 1.28s, and from 81 MiB to 59 MiB with GC_INITIAL_HEAP_SIZE=100000 on my system).
2011-08-06	* Handle the case where the search path element is a regular file.	Eelco Dolstra	1	-1/+2

2011-08-06	* Remove a debug statement.	Eelco Dolstra	1	-1/+0

2011-08-06	* Add the Nix corepkgs to the end of the search path. This makes it	Eelco Dolstra	1	-0/+2
	possible for other Nix expressions to use corepkgs (mostly useful for the buildenv function).
2011-08-06	* Allow redirections in search path entries. E.g. if you have a	Eelco Dolstra	2	-6/+25
	directory /home/eelco/src/stdenv-updates that you want to use as the directory for import such as with (import <nixpkgs> { }); then you can say $ nix-build -I nixpkgs=/home/eelco/src/stdenv-updates
2011-08-06	* Add a Nix expression search path feature. Paths between angle	Eelco Dolstra	8	-6/+76
	brackets, e.g. import <nixpkgs/pkgs/lib> are resolved by looking them up relative to the elements listed in the search path. This allows us to get rid of hacks like import "${builtins.getEnv "NIXPKGS_ALL"}/pkgs/lib" The search path can be specified through the ‘-I’ command-line flag and through the colon-separated ‘NIX_PATH’ environment variable, e.g., $ nix-build -I /etc/nixos ... If a file is not found in the search path, an error message is lazily thrown.
2011-08-06	* Refactoring: move parseExprFromFile() and parseExprFromString() into	Eelco Dolstra	10	-52/+37
	the EvalState class.
2011-07-20	* Don't allow derivations with fixed and non-fixed outputs.	Eelco Dolstra	1	-43/+38

2011-07-20	* Fix a huuuuge security hole in the Nix daemon. It didn't check that	Eelco Dolstra	9	-81/+180
	derivations added to the store by clients have "correct" output paths (meaning that the output paths are computed by hashing the derivation according to a certain algorithm). This means that a malicious user could craft a special .drv file to build any desired path in the store with any desired contents (so long as the path doesn't already exist). Then the attacker just needs to wait for a victim to come along and install the compromised path. For instance, if Alice (the attacker) knows that the latest Firefox derivation in Nixpkgs produces the path /nix/store/1a5nyfd4ajxbyy97r1fslhgrv70gj8a7-firefox-5.0.1 then (provided this path doesn't already exist) she can craft a .drv file that creates that path (i.e., has it as one of its outputs), add it to the store using "nix-store --add", and build it with "nix-store -r". So the fake .drv could write a Trojan to the Firefox path. Then, if user Bob (the victim) comes along and does $ nix-env -i firefox $ firefox he executes the Trojan injected by Alice. The fix is to have the Nix daemon verify that derivation outputs are correct (in addValidPath()). This required some refactoring to move the hash computation code to libstore.
2011-07-18	* Support multiple outputs. A derivation can declare multiple outputs	Eelco Dolstra	1	-45/+84
	by setting the ‘outputs’ attribute. For example: stdenv.mkDerivation { name = "aterm-2.5"; src = ...; outputs = [ "out" "tools" "dev" ]; configureFlags = "--bindir=$(tools)/bin --includedir=$(dev)/include"; } This derivation creates three outputs, named like this: /nix/store/gcnqgllbh01p3d448q8q6pzn2nc2gpyl-aterm-2.5 /nix/store/gjf1sgirwfnrlr0bdxyrwzpw2r304j02-aterm-2.5-tools /nix/store/hp6108bqfgxvza25nnxfs7kj88xi2vdx-aterm-2.5-dev That is, the symbolic name of the output is suffixed to the store path (except for the ‘out’ output). Each path is passed to the builder through the corresponding environment variable, e.g., ${tools}. The main reason for multiple outputs is to allow parts of a package to be distributed and garbage-collected separately. For instance, most packages depend on Glibc for its libraries, but don't need its header files. If these are separated into different store paths, then a package that depends on the Glibc libraries only causes the libraries and not the headers to be downloaded. The main problem with multiple outputs is that if one output exists while the others have been garbage-collected (or never downloaded in the first place), and we want to rebuild the other outputs, then this isn't possible because we can't clobber a valid output (it might be in active use). This currently gives an error message like: error: derivation `/nix/store/1s9zw4c8qydpjyrayxamx2z7zzp5pcgh-aterm-2.5.drv' is blocked by its output paths There are two solutions: 1) Do the build in a chroot. Then we don't need to overwrite the existing path. 2) Use hash rewriting (see the ASE-2005 paper). Scary but it should work. This is not finished yet. There is not yet an easy way to refer to non-default outputs in Nix expressions. Also, mutually recursive outputs aren't detected yet and cause the garbage collector to crash.
2011-07-13	* Allow attribute names to be strings. Based on the	Eelco Dolstra	1	-0/+2
	allow-arbitrary-strinsg-in-names patch by Marc Weber.
2011-07-13	* Allow a default value in attribute selection by writing	Eelco Dolstra	5	-21/+43
	x.y.z or default (as originally proposed in https://mail.cs.uu.nl/pipermail/nix-dev/2009-September/002989.html). For instance, an expression like stdenv.lib.attrByPath ["features" "ckSched"] false args can now be written as args.features.ckSched or false
2011-07-06	* Change the right-hand side of the ‘.’ operator from an attribute to	Eelco Dolstra	4	-18/+33
	an attribute path. This is a refactoring to support default values.
2011-07-06	* In the ‘?’ operator, allow attribute paths. For instance, you can	Eelco Dolstra	4	-24/+47
	write ‘attrs ? a.b’ to test whether ‘attrs’ has an attribute ‘a’ containing an attribute ‘b’. This is more convenient than ‘attrs ? a && attrs.a ? b’. Slight change in the semantics: it's no longer an error if the left-hand side of ‘?’ is not an attribute set. In that case it just returns false. So, ‘null ? foo’ no longer throws an error.
2011-06-30	Add support for the `build-timeout' and `--timeout' options.	Ludovic Courtès	4	-4/+38

2011-04-19	* Handle error messages from the Nix worker containing the `%'	Eelco Dolstra	1	-1/+1
	character. (Nix/216)
2011-04-11	* `nix-env -ub' (`--prebuilt-only') didn't really work because it	Eelco Dolstra	1	-17/+20
	checked too soon whether substitutes are available. That is, it did so for every available package, rather than those matching installed packages. This was very slow and subject to assertion failures. So do the check much later. Idem for `nix-env -qab' and `nix-env -ib'.
2011-02-10	* Don't allocate a big initial GC address space on machines with	Eelco Dolstra	1	-11/+24
	little RAM. Even if the memory isn't actually used, it can cause problems with the overcommit heuristics in the kernel. So use a VM space of 25% of RAM, up to 384 MB.
2011-02-09	* Don't call GC_expand_hp unless we're actually using the garbage	Eelco Dolstra	2	-12/+18
	collector.
2011-02-09	Use $BDW_GC_LIBS instead of a custom variable.	Ludovic Courtès	2	-2/+2

2011-02-09	* Sync with the trunk.	Eelco Dolstra	1	-2/+0

2011-02-05	* Clang compatibility fix. Clang actually checks template definitions	Eelco Dolstra	1	-1/+1
	when they are defined
2011-01-14	Remove useless <config.h> inclusion from public header.	Ludovic Courtès	1	-2/+0

2011-01-14	* builtins.substring: if "start" is beyond the end of the string,	Eelco Dolstra	1	-1/+1
	return the empty string.
2010-12-17	* Do a short sleep after SQLITE_BUSY.	Eelco Dolstra	1	-0/+11

2010-12-17	* Propagate the "100" exit status for failed builds through the Nix	Eelco Dolstra	3	-5/+9
	daemon.
2010-12-14	* I forgot to catch SQLiteBusy in registerValidPaths(). So	Eelco Dolstra	1	-38/+31
	registerValidPaths() now handles busy errors and registerValidPath() is simply a wrapper around it.
2010-12-13	* nix-instantiate: return exit status 100 to denote a permanent build	Eelco Dolstra	4	-7/+22
	failure. The build hook can use this to distinguish between transient and permanent failures on the remote side.
2010-12-13	* Create /nix/var/nix/db if it's missing.	Eelco Dolstra	1	-0/+1

2010-12-13	* createDirs(path): if path already exists, make sure it's a	Eelco Dolstra	2	-20/+26
	directory. * Provide a C++ wrapper around lstat().
2010-12-13	* Update some comments.	Eelco Dolstra	2	-4/+3

2010-12-08	* Ignore the result of sqlite3_reset().	Eelco Dolstra	1	-3/+4

2010-12-06	* `nix-store --verify --check-contents': don't hold the global GC lock	Eelco Dolstra	2	-11/+49
	while checking the contents, since this operation can take a very long time to finish. Also, fill in missing narSize fields in the DB while doing this.
2010-12-05	* Retry a transaction if SQLite returns SQLITE_BUSY. This can happen	Eelco Dolstra	1	-61/+83
	even with a very long busy timeout, because SQLITE_BUSY is also returned to resolve deadlocks. This should get rid of random "database is locked" errors. This is kind of hard to test though. * Fix a horrible bug in deleteFromStore(): deletePathWrapped() should be called after committing the transaction, not before, because the commit might not succeed.
2010-11-29	* Quick hack around one of the pathological cases in bsdiff	Eelco Dolstra	1	-0/+1
	(namely, when there is a long region of 0s). On one 86 MiB case, this cut patch generation time from 44m to 2m.
2010-11-25	* Sync with the trunk.	Eelco Dolstra	1	-0/+4

2010-11-25	* DrvInfo contains pointers to expressions, so DrvInfos should be	Eelco Dolstra	1	-0/+4
	traced by the garbage collector. Otherwise "nix-env -u" can crash randomly.
2010-11-17	* Before a build, show the disk space that the downloaded store paths	Eelco Dolstra	8	-12/+18
	will approximately require.
2010-11-17	* Add an operation `nix-store -q --size'.	Eelco Dolstra	4	-7/+24

2010-11-17	* Implement RemoteStore::queryPathInfo().	Eelco Dolstra	3	-1/+27

2010-11-16	* Store the size of a store path in the database (to be precise, the	Eelco Dolstra	15	-90/+143
	size of the NAR serialisation of the path, i.e., `nix-store --dump PATH'). This is useful for Hydra.
2010-11-16	* Sync with the trunk.	Eelco Dolstra	25	-437/+643

2010-10-29	* Document Boehm GC support.	Eelco Dolstra	1	-1/+1

2010-10-29	* Set libgc's initial heap size to 384 MiB to prevent garbage	Eelco Dolstra	1	-0/+12
	collection in most cases (and therefore its performance overhead).
2010-10-28	* new(UseGC) is inexplicably slower than GC_MALLOC, so prefer the	Eelco Dolstra	1	-4/+4
	latter.
2010-10-28	* Handle out of memory condition.	Eelco Dolstra	5	-10/+28

2010-10-24	* When allocating an attribute set, reserve enough space for all	Eelco Dolstra	4	-28/+21
	elements. This prevents the vector from having to resize itself.
2010-10-24	* Keep attribute sets in sorted order to speed up attribute lookups.	Eelco Dolstra	11	-146/+184
	* Simplify the representation of attributes in the AST. * Change the behaviour of listToAttrs() in case of duplicate names.
2010-10-24	* Don't create thunks for variable lookups (if possible). This	Eelco Dolstra	3	-23/+60
	significantly reduces the number of values allocated (e.g. from 8.7m to 4.9m for the Bittorrent test).
2010-10-24	* Store attribute sets as a vector instead of a map (i.e. a red-black	Eelco Dolstra	7	-90/+129
	tree). This saves a lot of memory. The vector should be sorted so that names can be looked up using binary search, but this is not the case yet. (Surprisingly, looking up attributes using linear search doesn't have a big impact on performance.) Memory consumption for $ nix-instantiate /etc/nixos/nixos/tests -A bittorrent.test --readonly-mode on x86_64-linux with GC enabled is now 185 MiB (compared to 946 MiB on the trunk).