depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2013-06-20	Don't set $preferLocalBuild and $requiredSystemFeatures in builders	Eelco Dolstra	2	-8/+15
	With C++ std::map, doing a comparison like ‘map["foo"] == ...’ has the side-effect of adding a mapping from "foo" to the empty string if "foo" doesn't exist in the map. So we ended up setting some environment variables by accident.
2013-06-20	Don't substitute derivations that have preferLocalBuild set	Eelco Dolstra	3	-7/+15
	In particular this means that "trivial" derivations such as writeText are not substituted, reducing the number of GET requests to the binary cache by about 200 on a typical NixOS configuration.
2013-06-20	Increase SQLite's auto-checkpoint interval	Eelco Dolstra	1	-2/+2
	Common operations like instantiating a NixOS system config no longer fitted in 8192 pages, leading to more fsyncs. So increase this limit.
2013-06-20	Disable the copy-from-other-stores substituter	Eelco Dolstra	1	-0/+2
	This substituter basically cannot work reliably since we switched to SQLite, since SQLite databases may need write access to open them even just for reading (and in WAL mode they always do).
2013-06-20	Don't keep "disabled" substituters running	Eelco Dolstra	3	-2/+28
	For instance, it's pointless to keep copy-from-other-stores running if there are no other stores, or download-using-manifests if there are no manifests. This also speeds things up because we don't send queries to those substituters.
2013-06-13	Allow hard links between the outputs of a derivation	Eelco Dolstra	3	-9/+20

2013-06-13	Fix a security bug in hash rewriting	Eelco Dolstra	1	-0/+6
	Before calling dumpPath(), we have to make sure the files are owned by the build user. Otherwise, the build could contain a hard link to (say) /etc/shadow, which would then be read by the daemon and rewritten as a world-readable file. This only affects systems that don't have hard link restrictions enabled.
2013-06-13	Fix assertion failure in canonicalisePathMetaData() after hash rewriting	Eelco Dolstra	1	-2/+9
	The assertion in canonicalisePathMetaData() failed because the ownership of the path already changed due to the hash rewriting. The solution is not to check the ownership of rewritten paths. Issue #122.
2013-06-13	computeFSClosure: Only process the missing/corrupt paths	Eelco Dolstra	1	-11/+17
	Issue #122.
2013-06-13	In repair mode, update the hash of rebuilt paths	Eelco Dolstra	2	-4/+5
	Otherwise subsequent invocations of "--repair" will keep rebuilding the path. This only happens if the path content differs between builds (e.g. due to timestamps).
2013-06-12	nix-daemon: Trust options like binary-caches when the client is root	Eelco Dolstra	1	-5/+7
	Fixes #127.
2013-06-07	Remove obsolete EOF checks	Eelco Dolstra	1	-26/+18

2013-06-07	Process stderr from substituters while doing have/info queries	Eelco Dolstra	4	-9/+59

2013-06-07	Buffer reads from the substituter	Eelco Dolstra	2	-10/+27
	This greatly reduces the number of system calls.
2013-05-23	nix-store --export: Export paths in topologically sorted order	Eelco Dolstra	2	-2/+4
	Fixes #118.
2013-05-16	Show function names in error messages	Eelco Dolstra	5	-8/+43
	Functions in Nix are anonymous, but if they're assigned to a variable/attribute, we can use the variable/attribute name in error messages, e.g. while evaluating `concatMapStrings' at `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs/pkgs/lib/strings.nix:18:25': ...
2013-05-16	Show which function argument was unexpected	Eelco Dolstra	1	-5/+9
	Fixes #116.
2013-05-16	Shut up a compiler warning	Eelco Dolstra	1	-1/+1

2013-05-10	In trace messages, don't print the output path	Eelco Dolstra	1	-19/+15
	This doesn't work if there is no output named "out". Hydra didn't use it anyway.
2013-05-09	Communicate build timeouts to Hydra	Eelco Dolstra	1	-7/+11

2013-05-09	build-remote.pl: Enforce timeouts locally	Eelco Dolstra	1	-3/+1
	Don't pass --timeout / --max-silent-time to the remote builder. Instead, let the local Nix process terminate the build if it exceeds a timeout. The remote builder will be killed as a side-effect. This gives better error reporting (since the timeout message from the remote side wasn't properly propagated) and handles non-Nix problems like SSH hangs.
2013-05-01	Don't let stderr writes in substituters cause a deadlock	Eelco Dolstra	1	-0/+4

2013-04-26	addAdditionalRoots(): Check each path only once	Eelco Dolstra	1	-2/+2

2013-04-23	Fix --timeout	Eelco Dolstra	1	-38/+25
	I'm not sure if it has ever worked correctly. The line "lastWait = after;" seems to mean that the timer was reset every time a build produced log output. Note that the timeout is now per build, as documented ("the maximum number of seconds that a builder can run").
2013-04-23	Nix daemon: respect build timeout from the client	Eelco Dolstra	2	-4/+5

2013-04-04	Complain if /homeless-shelter exists	Eelco Dolstra	1	-1/+5

2013-03-25	makeStoreWritable: Ask forgiveness, not permission	Shea Levy	1	-2/+2
	It is surprisingly impossible to check if a mountpoint is a bind mount on Linux, and in my previous commit I forgot to check if /nix/store was even a mountpoint at all. statvfs.f_flag is not populated with MS_BIND (and even if it were, my check was wrong in the previous commit). Luckily, the semantics of mount with MS_REMOUNT \| MS_BIND make both checks unnecessary: if /nix/store is not a mountpoint, then mount will fail with EINVAL, and if /nix/store is not a bind-mount, then it will not be made writable. Thus, if /nix/store is not a mountpoint, we fail immediately (since we don't know how to make it writable), and if /nix/store IS a mountpoint but not a bind-mount, we fail at first write (see below for why we can't check and fail immediately). Note that, due to what is IMO buggy behavior in Linux, calling mount with MS_REMOUNT \| MS_BIND on a non-bind readonly mount makes the mountpoint appear writable in two places: In the sixth (but not the 10th!) column of mountinfo, and in the f_flags member of struct statfs. All other syscalls behave as if the mount point were still readonly (at least for Linux 3.9-rc1, but I don't think this has changed recently or is expected to soon). My preferred semantics would be for MS_REMOUNT \| MS_BIND to fail on a non-bind mount, as it doesn't make sense to remount a non bind-mount as a bind mount.
2013-03-25	makeStoreWritable: Use statvfs instead of /proc/self/mountinfo to find out ↵	Shea Levy	1	-21/+12
	if /nix/store is a read-only bind mount /nix/store could be a read-only bind mount even if it is / in its own filesystem, so checking the 4th field in mountinfo is insufficient. Signed-off-by: Shea Levy <shea@shealevy.com>
2013-03-14	Fix building against Bison 2.6	Eelco Dolstra	2	-6/+4

2013-03-14	Make sure that thunks are restored properly if an exception occurs	Eelco Dolstra	1	-3/+6
	Fixes Hydra bug #67.
2013-03-08	Revert "Prevent config.h from being clobbered"	Eelco Dolstra	16	-104/+177
	This reverts commit 28bba8c44f484eae38e8a15dcec73cfa999156f6.
2013-03-07	Prevent config.h from being clobbered	Eelco Dolstra	16	-177/+104

2013-02-28	Handle systems without lutimes() or lchown()	Eelco Dolstra	1	-1/+1

2013-02-28	Handle symlinks properly	Eelco Dolstra	1	-1/+1
	Now it's really brown paper bag time...
2013-02-27	Handle hard links to other files in the output	Eelco Dolstra	1	-6/+26

2013-02-27	Refactoring: Split off the non-recursive canonicalisePathMetaData()	Eelco Dolstra	3	-37/+52
	Also, change the file mode before changing the owner. This prevents a slight time window in which a setuid binary would be setuid root.
2013-02-26	Security: Don't allow builders to change permissions on files they don't own	Eelco Dolstra	5	-20/+17
	It turns out that in multi-user Nix, a builder may be able to do ln /etc/shadow $out/foo Afterwards, canonicalisePathMetaData() will be applied to $out/foo, causing /etc/shadow's mode to be set to 444 (readable by everybody but writable by nobody). That's obviously Very Bad. Fortunately, this fails in NixOS's default configuration because /nix/store is a bind mount, so "ln" will fail with "Invalid cross-device link". It also fails if hard-link restrictions are enabled, so a workaround is: echo 1 > /proc/sys/fs/protected_hardlinks The solution is to check that all files in $out are owned by the build user. This means that innocuous operations like "ln ${pkgs.foo}/some-file $out/" are now rejected, but that already failed in chroot builds anyway.
2013-02-19	build-remote: Use the --quiet flag	Eelco Dolstra	1	-5/+2
	‘--option verbosity 0’ doesn't actually do anything.
2013-02-19	Add `Settings::nixDaemonSocketFile'.	Ludovic Courtès	5	-10/+14

2013-02-19	Enable chroot support on old glibc versions.	Ludovic Courtès	1	-0/+6

2013-02-08	Make "${./path} ..." evaluate to a string, not a path	Eelco Dolstra	3	-5/+7
	Wacky string coercion semantics caused expressions like exec = "${./my-script} params..."; to evaluate to a path (‘/path/my-script params’), because anti-quotations are desuged to string concatenation: exec = ./my-script + " params..."; By constrast, adding a space at the start would yield a string as expected: exec = " ${./my-script} params..."; Now the first example also evaluates to a string.
2013-02-08	Rename "hash" to "hashString" and handle SHA-1	Eelco Dolstra	1	-19/+9

2013-02-08	experimental/hash	Marc Weber	1	-0/+26
	adding primop function calculating hash of a string Signed-off-by: Marc Weber <marco-oweber@gmx.de>
2013-01-30	Support the colonies	Eelco Dolstra	1	-3/+3

2013-01-23	Only warn about SQLite being busy once	Eelco Dolstra	1	-1/+5
	No need to get annoying.
2013-01-22	Correctly handle missing logs	Eelco Dolstra	1	-1/+3

2013-01-17	Store build logs in /nix/var/log/nix/drvs/<XX>	Eelco Dolstra	2	-30/+37
	...where <XX> is the first two characters of the derivation. Otherwise /nix/var/log/nix/drvs may become so large that we run into all sorts of weird filesystem limits/inefficiences. For instance, ext3/ext4 filesystems will barf with "ext4_dx_add_entry:1551: Directory index full!" once you hit a few million files.
2013-01-05	Delete a left-over trash directory before doing a GC	Eelco Dolstra	1	-1/+4

2013-01-04	Fix "0 store paths deleted" message	Eelco Dolstra	1	-0/+2

2013-01-03	Open the database after removing immutable bits	Eelco Dolstra	1	-1/+1