depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2013-08-26	Fix typos, especially those that end up in the Nix manual	Ivan Kozik	1	-1/+1

2013-08-07	Run the daemon worker on the same CPU as the client	Eelco Dolstra	1	-0/+2
	On a system with multiple CPUs, running Nix operations through the daemon is significantly slower than "direct" mode: $ NIX_REMOTE= nix-instantiate '<nixos>' -A system real 0m0.974s user 0m0.875s sys 0m0.088s $ NIX_REMOTE=daemon nix-instantiate '<nixos>' -A system real 0m2.118s user 0m1.463s sys 0m0.218s The main reason seems to be that the client and the worker get moved to a different CPU after every call to the worker. This patch adds a hack to lock them to the same CPU. With this, the overhead of going through the daemon is very small: $ NIX_REMOTE=daemon nix-instantiate '<nixos>' -A system real 0m1.074s user 0m0.809s sys 0m0.098s
2013-06-20	Increase SQLite's auto-checkpoint interval	Eelco Dolstra	1	-2/+2
	Common operations like instantiating a NixOS system config no longer fitted in 8192 pages, leading to more fsyncs. So increase this limit.
2013-06-20	Don't keep "disabled" substituters running	Eelco Dolstra	1	-2/+25
	For instance, it's pointless to keep copy-from-other-stores running if there are no other stores, or download-using-manifests if there are no manifests. This also speeds things up because we don't send queries to those substituters.
2013-06-13	Allow hard links between the outputs of a derivation	Eelco Dolstra	1	-7/+8

2013-06-13	In repair mode, update the hash of rebuilt paths	Eelco Dolstra	1	-3/+4
	Otherwise subsequent invocations of "--repair" will keep rebuilding the path. This only happens if the path content differs between builds (e.g. due to timestamps).
2013-06-07	Remove obsolete EOF checks	Eelco Dolstra	1	-26/+18

2013-06-07	Process stderr from substituters while doing have/info queries	Eelco Dolstra	1	-9/+50

2013-06-07	Buffer reads from the substituter	Eelco Dolstra	1	-10/+22
	This greatly reduces the number of system calls.
2013-05-01	Don't let stderr writes in substituters cause a deadlock	Eelco Dolstra	1	-0/+4

2013-03-25	makeStoreWritable: Ask forgiveness, not permission	Shea Levy	1	-2/+2
	It is surprisingly impossible to check if a mountpoint is a bind mount on Linux, and in my previous commit I forgot to check if /nix/store was even a mountpoint at all. statvfs.f_flag is not populated with MS_BIND (and even if it were, my check was wrong in the previous commit). Luckily, the semantics of mount with MS_REMOUNT \| MS_BIND make both checks unnecessary: if /nix/store is not a mountpoint, then mount will fail with EINVAL, and if /nix/store is not a bind-mount, then it will not be made writable. Thus, if /nix/store is not a mountpoint, we fail immediately (since we don't know how to make it writable), and if /nix/store IS a mountpoint but not a bind-mount, we fail at first write (see below for why we can't check and fail immediately). Note that, due to what is IMO buggy behavior in Linux, calling mount with MS_REMOUNT \| MS_BIND on a non-bind readonly mount makes the mountpoint appear writable in two places: In the sixth (but not the 10th!) column of mountinfo, and in the f_flags member of struct statfs. All other syscalls behave as if the mount point were still readonly (at least for Linux 3.9-rc1, but I don't think this has changed recently or is expected to soon). My preferred semantics would be for MS_REMOUNT \| MS_BIND to fail on a non-bind mount, as it doesn't make sense to remount a non bind-mount as a bind mount.
2013-03-25	makeStoreWritable: Use statvfs instead of /proc/self/mountinfo to find out ↵	Shea Levy	1	-21/+12
	if /nix/store is a read-only bind mount /nix/store could be a read-only bind mount even if it is / in its own filesystem, so checking the 4th field in mountinfo is insufficient. Signed-off-by: Shea Levy <shea@shealevy.com>
2013-03-08	Revert "Prevent config.h from being clobbered"	Eelco Dolstra	1	-37/+79
	This reverts commit 28bba8c44f484eae38e8a15dcec73cfa999156f6.
2013-03-07	Prevent config.h from being clobbered	Eelco Dolstra	1	-79/+37

2013-02-28	Handle systems without lutimes() or lchown()	Eelco Dolstra	1	-1/+1

2013-02-28	Handle symlinks properly	Eelco Dolstra	1	-1/+1
	Now it's really brown paper bag time...
2013-02-27	Handle hard links to other files in the output	Eelco Dolstra	1	-6/+26

2013-02-27	Refactoring: Split off the non-recursive canonicalisePathMetaData()	Eelco Dolstra	1	-35/+50
	Also, change the file mode before changing the owner. This prevents a slight time window in which a setuid binary would be setuid root.
2013-02-26	Security: Don't allow builders to change permissions on files they don't own	Eelco Dolstra	1	-7/+10
	It turns out that in multi-user Nix, a builder may be able to do ln /etc/shadow $out/foo Afterwards, canonicalisePathMetaData() will be applied to $out/foo, causing /etc/shadow's mode to be set to 444 (readable by everybody but writable by nobody). That's obviously Very Bad. Fortunately, this fails in NixOS's default configuration because /nix/store is a bind mount, so "ln" will fail with "Invalid cross-device link". It also fails if hard-link restrictions are enabled, so a workaround is: echo 1 > /proc/sys/fs/protected_hardlinks The solution is to check that all files in $out are owned by the build user. This means that innocuous operations like "ln ${pkgs.foo}/some-file $out/" are now rejected, but that already failed in chroot builds anyway.
2013-01-23	Only warn about SQLite being busy once	Eelco Dolstra	1	-1/+5
	No need to get annoying.
2013-01-03	Open the database after removing immutable bits	Eelco Dolstra	1	-1/+1

2013-01-03	Clear any immutable bits in the Nix store	Eelco Dolstra	1	-1/+60
	Doing this once makes subsequent operations like garbage collecting more efficient since we don't have to call makeMutable() first.
2012-12-11	On SQLITE_BUSY, wait a random amount of time	Eelco Dolstra	1	-1/+1
	If all contending processes wait a fixed amount of time (100 ms), there is a good probability that they'll just collide again.
2012-11-09	Use vfork() instead of fork() if available	Eelco Dolstra	1	-5/+16
	Hopefully this reduces the chance of hitting ‘unable to fork: Cannot allocate memory’ errors. vfork() is used for everything except starting builders.
2012-11-09	Remove some redundant close() calls	Eelco Dolstra	1	-2/+0
	They are unnecessary because we set the close-on-exec flag.
2012-11-09	Remove the quickExit function	Eelco Dolstra	1	-1/+1

2012-11-09	Remove a Darwin hack that should no longer be needed	Eelco Dolstra	1	-7/+0

2012-11-09	Remove unnecessary call to closeMostFDs()	Eelco Dolstra	1	-1/+0
	We have close-on-exec on all FDs now, and there is no security risk in passing open FDs to substituters anyway.
2012-11-06	canonicalizePathMetaData: Fall-back to utimes if lutimes fails due to ENOSYS	Shea Levy	1	-0/+2

2012-10-04	nix-store --verify: Continue on errors	Eelco Dolstra	1	-2/+4

2012-10-03	Remove bin2c	Eelco Dolstra	1	-0/+2

2012-10-03	Add a ‘--repair’ flag to nix-instantiate	Eelco Dolstra	1	-8/+8
	This allows repairing corrupted derivations and other source files.
2012-10-03	When repairing a derivation, check and repair the entire output closure	Eelco Dolstra	1	-4/+20
	If we find a corrupted path in the output closure, we rebuild the derivation that produced that particular path.
2012-10-02	Add a --repair flag to ‘nix-store -r’ to repair derivation outputs	Eelco Dolstra	1	-0/+10
	With this flag, if any valid derivation output is missing or corrupt, it will be recreated by using a substitute if available, or by rebuilding the derivation. The latter may use hash rewriting if chroots are not available.
2012-10-02	nix-store --verify: Add an option ‘--repair’ to repair all ↵	Eelco Dolstra	1	-5/+20
	missing/corrupt paths Also, return a non-zero exit code if errors remain after verifying/repairing.
2012-09-25	Make the store writable before creating /nix/store/.links	Eelco Dolstra	1	-2/+1

2012-09-19	Remove setting of the immutable bit	Eelco Dolstra	1	-2/+0
	Using the immutable bit is problematic, especially in conjunction with store optimisation. For instance, if the garbage collector deletes a file, it has to clear its immutable bit, but if the file has additional hard links, we can't set the bit afterwards because we don't know the remaining paths. So now that we support having the entire Nix store as a read-only mount, we may as well drop the immutable bit. Unfortunately, we have to keep the code to clear the immutable bit for backwards compatibility.
2012-09-19	Support having /nix/store as a read-only bind mount	Eelco Dolstra	1	-0/+39
	It turns out that the immutable bit doesn't work all that well. A better way is to make the entire Nix store a read-only bind mount, i.e. by doing $ mount --bind /nix/store /nix/store $ mount -o remount,ro,bind /nix/store (This would typically done in an early boot script, before anything from /nix/store is used.) Since Nix needs to be able to write to the Nix store, it now detects if /nix/store is a read-only bind mount and then makes it writable in a private mount namespace.
2012-09-19	Templatise tokenizeString()	Eelco Dolstra	1	-3/+3

2012-09-13	Vacuum the SQLite DB after running the garbage collector	Eelco Dolstra	1	-0/+7

2012-08-01	Report substituter errors to clients of the Nix daemon	Eelco Dolstra	1	-21/+37

2012-07-30	Refactor settings processing	Eelco Dolstra	1	-33/+31
	Put all Nix configuration flags in a Settings object.
2012-07-30	Pass configuration settings to the substituters	Eelco Dolstra	1	-0/+4
	Previously substituters could read nix.conf themselves, but this didn't take --option flags into account.
2012-07-30	Remove unused variables	Eelco Dolstra	1	-2/+0

2012-07-30	Fix whitespace	Eelco Dolstra	1	-71/+71

2012-07-26	Fix the substituter tests	Eelco Dolstra	1	-1/+2

2012-07-26	Merge branch 'master' into no-manifests	Eelco Dolstra	1	-9/+23

2012-07-23	Automatically optimise the Nix store when a new path is added	Eelco Dolstra	1	-0/+7
	Auto-optimisation is enabled by default. It can be turned off by setting auto-optimise-store to false in nix.conf.
2012-07-23	Use lutimes() if available to canonicalise the timestamp of symlinks	Eelco Dolstra	1	-9/+16
	Also use utimes() instead of utime() if lutimes() is not available.
2012-07-18	Merge branch 'master' into no-manifests	Eelco Dolstra	1	-0/+24