depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2016-03-04	Eliminate some large string copying	Eelco Dolstra	1	-4/+4

2016-02-26	importPaths(): Optionally add NARs to binary cache accessor	Eelco Dolstra	1	-1/+2
	This enables an optimisation in hydra-queue-runner, preventing a download of a NAR it just uploaded to the cache when reading files like hydra-build-products.
2016-02-24	deletePath(): Succeed if path doesn't exist	Eelco Dolstra	1	-3/+3
	Also makes it robust against concurrent deletions.
2016-02-24	Eliminate reserveSpace flag	Eelco Dolstra	1	-17/+13

2016-02-24	LocalStore::addTextToStore(): Don't read the path we just wrote	Eelco Dolstra	1	-3/+5
	This eliminates some unnecessary (presumably cached) I/O.
2016-02-17	Fix build without sodium	Eelco Dolstra	1	-4/+1
	http://hydra.nixos.org/build/32085949
2016-02-16	Rename ValidPathInfo::hash -> narHash for consistency	Eelco Dolstra	1	-16/+16

2016-02-15	Expose the export magic value and move LocalStore::queryReferences to Store	Eelco Dolstra	1	-14/+3

2016-02-15	Add function to extract hash part of a store path	Eelco Dolstra	1	-1/+1

2016-02-04	Eliminate the "store" global variable	Eelco Dolstra	1	-2/+2
	Also, move a few free-standing functions into StoreAPI and Derivation. Also, introduce a non-nullable smart pointer, ref<T>, which is just a wrapper around std::shared_ptr ensuring that the pointer is never null. (For reference-counted values, this is better than passing a "T&", because the latter doesn't maintain the refcount. Usually, the caller will have a shared_ptr keeping the value alive, but that's not always the case, e.g., when passing a reference to a std::thread via std::bind.)
2016-01-31	Use the daemon when we don't have write access to the Nix database	Eelco Dolstra	1	-1/+7

2016-01-12	Canonicalize gids to 0	Eelco Dolstra	1	-2/+2
	Previously files in the Nix store were owned by root or by nixbld, depending on whether they were created by a substituter or by a builder. This doesn't matter much, but causes spurious diffoscope differences. So use root everywhere.
2015-12-10	Build sandbox support etc. unconditionally on Linux	Eelco Dolstra	1	-7/+2
	Also, use "#if __APPLE__" instead of "#if SANDBOX_ENABLED" to prevent ambiguity.
2015-07-20	nix-copy-closure: Add -v flag	Eelco Dolstra	1	-1/+3
	And make exportPath() less spammy by default.
2015-07-20	More cleanup	Eelco Dolstra	1	-11/+3

2015-07-17	OCD: foreach -> C++11 ranged for	Eelco Dolstra	1	-73/+73

2015-06-22	Use posix_fallocate to create /nix/var/nix/db/reserved	Eelco Dolstra	1	-1/+11

2015-05-13	cygwin: explicitly include required c headers	Rok Garbas	1	-0/+1

2015-04-07	Revert /nix/store permission back to 01775	Eelco Dolstra	1	-1/+1
	This broke NixOS VM tests. Mostly reverts 27b7b94923d2f207781b438bb7a57669bddf7d2b, 5ce50cd99e740d0d0f18c30327ae687be9356553, afa433e58c3fe6029660a43fdc2073c9d15b4210.
2015-03-25	addToStore(): Take explicit name argument	Eelco Dolstra	1	-2/+2

2015-01-08	Doh^2	Eelco Dolstra	1	-1/+1

2015-01-08	Doh	Eelco Dolstra	1	-3/+3

2015-01-08	Set /nix/store permission to 1737	Eelco Dolstra	1	-4/+6
	I.e., not readable to the nixbld group. This improves purity a bit for non-chroot builds, because it prevents a builder from enumerating store paths (i.e. it can only access paths it knows about).
2014-12-29	LocalStore initialization: Don't die if build-users-group doesn't exist	Shea Levy	1	-11/+12
	See NixOS/nixpkgs@9245516
2014-12-12	Shut up a Valgrind warning	Eelco Dolstra	1	-1/+1

2014-12-10	Don't wait for PID -1	Eelco Dolstra	1	-1/+2
	The pid field can be -1 if forking the substituter process failed.
2014-11-19	Clean up temp roots in a more C++ way	Eelco Dolstra	1	-0/+9

2014-10-14	Improved error message when encountering unsupported file types	Eelco Dolstra	1	-3/+3
	Fixes #269.
2014-08-20	Use proper quotes everywhere	Eelco Dolstra	1	-64/+64

2014-08-05	Remove unnecessary call to addTempRoot()	Eelco Dolstra	1	-1/+0

2014-08-01	Make readDirectory() return inode / file type	Eelco Dolstra	1	-11/+9

2014-07-10	Replace message "importing path <...>" with "exporting path <...>"	Eelco Dolstra	1	-2/+2
	This causes nix-copy-closure to show what it's doing before rather than after.
2014-07-10	Refactoring: Move all fork handling into a higher-order function	Eelco Dolstra	1	-25/+10
	C++11 lambdas ftw.
2014-07-10	Remove maybeVfork	Eelco Dolstra	1	-1/+1

2014-05-02	Set up directories and permissions for multi-user install automatically	Eelco Dolstra	1	-1/+28
	This automatically creates /nix/var/nix/profiles/per-user and sets the permissions/ownership on /nix/store to 1775 and root:nixbld.
2014-04-08	If a .drv cannot be parsed, show its path	Eelco Dolstra	1	-2/+2
	Otherwise you just get ‘expected string `Derive(['’ which isn't very helpful.
2014-02-27	Set up a minimal /dev in chroots	Eelco Dolstra	1	-2/+1
	Not bind-mounting the /dev from the host also solves the problem with /dev/shm being a symlink to something not in the chroot.
2014-02-17	Heuristically detect if a build may have failed due to a full disk	Eelco Dolstra	1	-2/+2
	This will allow Hydra to detect that a build should not be marked as "permanently failed", allowing it to be retried later.
2014-02-03	Fix assertion failure in ‘nix-store --load-db’	Eelco Dolstra	1	-1/+12
	Namely: nix-store: derivations.cc:242: nix::Hash nix::hashDerivationModulo(nix::StoreAPI&, nix::Derivation): Assertion `store.isValidPath(i->first)' failed. This happened because of the derivation output correctness check being applied before the references of a derivation are valid.
2014-02-01	Give a friendly error message if the DB directory is not writable	Eelco Dolstra	1	-2/+6
	Previously we would say "error: setting synchronous mode: unable to open database file" which isn't very helpful.
2013-11-22	Include <cstring> for memset	Eelco Dolstra	1	-0/+1
	This should fix building on Illumos.
2013-11-14	Remove nix-setuid-helper	Eelco Dolstra	1	-3/+3
	AFAIK, nobody uses it, it's not maintained, and it has no tests.
2013-10-16	Retry all SQLite operations	Eelco Dolstra	1	-128/+165
	To deal with SQLITE_PROTOCOL, we also need to retry read-only operations.
2013-10-16	Fix a race in registerFailedPath()	Eelco Dolstra	1	-2/+1
	Registering the path as failed can fail if another process does the same thing after the call to hasPathFailed(). This is extremely unlikely though.
2013-10-16	Convenience macros for retrying a SQLite transaction	Eelco Dolstra	1	-46/+42

2013-10-16	Don't wrap read-only queries in a transaction	Eelco Dolstra	1	-6/+0
	There is no risk of getting an inconsistent result here: if the ID returned by queryValidPathId() is deleted from the database concurrently, subsequent queries involving that ID will simply fail (since IDs are never reused).
2013-10-16	Print a distinct warning for SQLITE_PROTOCOL	Eelco Dolstra	1	-4/+8

2013-10-16	Treat SQLITE_PROTOCOL as SQLITE_BUSY	Eelco Dolstra	1	-1/+1
	In the Hydra build farm we fairly regularly get SQLITE_PROTOCOL errors (e.g., "querying path in database: locking protocol"). The docs for this error code say that it "is returned if some other process is messing with file locks and has violated the file locking protocol that SQLite uses on its rollback journal files." However, the SQLite source code reveals that this error can also occur under high load: if( cnt>5 ){ int nDelay = 1; /* Pause time in microseconds / if( cnt>100 ){ VVA_ONLY( pWal->lockError = 1; ) return SQLITE_PROTOCOL; } if( cnt>=10 ) nDelay = (cnt-9)238; /* Max delay 21ms. Total delay 996ms */ sqlite3OsSleep(pWal->pVfs, nDelay); } i.e. if certain locks cannot be not acquired, SQLite will retry a number of times before giving up and returing SQLITE_PROTOCOL. The comments say: Circumstances that cause a RETRY should only last for the briefest instances of time. No I/O or other system calls are done while the locks are held, so the locks should not be held for very long. But if we are unlucky, another process that is holding a lock might get paged out or take a page-fault that is time-consuming to resolve, during the few nanoseconds that it is holding the lock. In that case, it might take longer than normal for the lock to free. ... The total delay time before giving up is less than 1 second. On a heavily loaded machine like lucifer (the main Hydra server), which often has dozens of processes waiting for I/O, it seems to me that a page fault could easily take more than a second to resolve. So, let's treat SQLITE_PROTOCOL as SQLITE_BUSY and retry the transaction. Issue NixOS/hydra#14.
2013-08-26	Fix typos, especially those that end up in the Nix manual	Ivan Kozik	1	-1/+1

2013-08-07	Run the daemon worker on the same CPU as the client	Eelco Dolstra	1	-0/+2
	On a system with multiple CPUs, running Nix operations through the daemon is significantly slower than "direct" mode: $ NIX_REMOTE= nix-instantiate '<nixos>' -A system real 0m0.974s user 0m0.875s sys 0m0.088s $ NIX_REMOTE=daemon nix-instantiate '<nixos>' -A system real 0m2.118s user 0m1.463s sys 0m0.218s The main reason seems to be that the client and the worker get moved to a different CPU after every call to the worker. This patch adds a hack to lock them to the same CPU. With this, the overhead of going through the daemon is very small: $ NIX_REMOTE=daemon nix-instantiate '<nixos>' -A system real 0m1.074s user 0m0.809s sys 0m0.098s