depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2014-09-17	On Linux, disable address space randomization	Eelco Dolstra	1	-5/+9

2014-09-17	Settings: Add bool get()	Eelco Dolstra	1	-2/+2

2014-08-28	Add disallowedReferences / disallowedRequisites	Eelco Dolstra	1	-26/+29
	For the "stdenv accidentally referring to bootstrap-tools", it seems easier to specify the path that we don't want to depend on, e.g. disallowedRequisites = [ bootstrapTools ];
2014-08-28	Introduce allowedRequisites feature	Gergely Risko	1	-1/+18

2014-08-21	fix disappearing bash arguments	Joel Taylor	1	-2/+7

2014-08-21	Use unshare() instead of clone()	Eelco Dolstra	1	-55/+35
	It turns out that using clone() to start a child process is unsafe in a multithreaded program. It can cause the initialisation of a build child process to hang in setgroups(), as seen several times in the build farm: The reason is that Glibc thinks that the other threads of the parent exist in the child, so in setxid_mark_thread() it tries to get a futex that has been acquired by another thread just before the clone(). With fork(), Glibc runs pthread_atfork() handlers that take care of this (in particular, __reclaim_stacks()). But clone() doesn't do that. Fortunately, we can use fork()+unshare() instead of clone() to set up private namespaces. See also https://www.mail-archive.com/lxc-devel@lists.linuxcontainers.org/msg03434.html.
2014-08-20	Use proper quotes everywhere	Eelco Dolstra	1	-87/+87

2014-08-20	Add some color	Eelco Dolstra	1	-37/+1

2014-08-20	Filter Nix-specific ANSI escape sequences from stderr	Eelco Dolstra	1	-1/+37
	The Nixpkgs stdenv prints some custom escape sequences to denote nesting and stuff like that. Most terminals (e.g. xterm, konsole) ignore them, but some do not (e.g. xfce4-terminal). So for the benefit of the latter, filter them out.
2014-08-19	Make hook shutdown more reliable	Eelco Dolstra	1	-1/+1

2014-08-18	Doh	Eelco Dolstra	1	-4/+1

2014-08-17	Reduce verbosity	Eelco Dolstra	1	-1/+2

2014-08-17	Propagate remote timeouts properly	Eelco Dolstra	1	-21/+33

2014-08-04	Refactor	Eelco Dolstra	1	-2/+2

2014-08-04	Add option ‘build-extra-chroot-dirs’	Eelco Dolstra	1	-4/+7
	This is useful for extending (rather than overriding) the default set of chroot paths.
2014-08-04	Get rid of "killing <pid>" message for unused build hooks	Eelco Dolstra	1	-1/+1

2014-08-01	Remove ugly hack for detecting build environment setup errors	Eelco Dolstra	1	-13/+10

2014-08-01	Call commonChildInit() before doing chroot init	Eelco Dolstra	1	-4/+6
	This ensures that daemon clients see error messages from the chroot setup.
2014-07-31	Restore default SIGPIPE handler before invoking ‘man’	Eelco Dolstra	1	-12/+0
	Fixes NixOS/nixpkgs#3410.
2014-07-19	Revert old useBuildHook behaviour	Eelco Dolstra	1	-1/+1

2014-07-11	Allow $NIX_BUILD_HOOK to be relative to Nix libexec directory	Eelco Dolstra	1	-2/+4

2014-07-10	Remove tabs	Eelco Dolstra	1	-3/+3

2014-07-10	Refactoring: Move all fork handling into a higher-order function	Eelco Dolstra	1	-50/+23
	C++11 lambdas ftw.
2014-07-10	Remove maybeVfork	Eelco Dolstra	1	-2/+2

2014-04-03	Fix compile errors on Illumos	Danny Wilson	1	-0/+1

2014-04-03	Make sure /dev/pts/ptmx is world-writable	Ludovic Courtès	1	-0/+4
	While running Python 3’s test suite, we noticed that on some systems /dev/pts/ptmx is created with permissions 0 (that’s the case with my Nixpkgs-originating 3.0.43 kernel, but someone with a Debian-originating 3.10-3 reported not having this problem.) There’s still the problem that people without CONFIG_DEVPTS_MULTIPLE_INSTANCES=y are screwed (as noted in build.cc), but I don’t see how we could work around it.
2014-03-30	boost::shared_ptr -> std::shared_ptr	Eelco Dolstra	1	-20/+26

2014-03-29	Fix potential segfault in waitForInput()	Eelco Dolstra	1	-3/+5
	Since the addition of build-max-log-size, a call to handleChildOutput() can result in cancellation of a goal. This invalidated the "j" iterator in the waitForInput() loop, even though it was still used afterwards. Likewise for the maxSilentTime handling. Probably fixes #231. At least it gets rid of the valgrind warnings.
2014-03-29	restoreSIGPIPE(): Fill in sa_mask	Eelco Dolstra	1	-0/+1
	Issue #231.
2014-03-21	Make /dev/kvm optional	Ludovic Courtès	1	-1/+4
	The daemon now creates /dev deterministically (thanks!). However, it expects /dev/kvm to be present. The patch below restricts that requirement (1) to Linux-based systems, and (2) to systems where /dev/kvm already exists. I’m not sure about the way to handle (2). We could special-case /dev/kvm and create it (instead of bind-mounting it) in the chroot, so it’s always available; however, it wouldn’t help much since most likely, if /dev/kvm missing, then KVM support is missing.
2014-02-27	Set up a private /dev/pts in the chroot	Eelco Dolstra	1	-1/+14

2014-02-27	Set up a minimal /dev in chroots	Eelco Dolstra	1	-3/+22
	Not bind-mounting the /dev from the host also solves the problem with /dev/shm being a symlink to something not in the chroot.
2014-02-27	Fix deadlock in SubstitutionGoal	Eelco Dolstra	1	-0/+1
	We were relying on SubstitutionGoal's destructor releasing the lock, but if a goal is a top-level goal, the destructor won't run in a timely manner since its reference count won't drop to zero. So release it explicitly. Fixes #178.
2014-02-18	Slight simplification	Eelco Dolstra	1	-17/+10

2014-02-18	Add a flag ‘--check’ to verify build determinism	Eelco Dolstra	1	-44/+78
	The flag ‘--check’ to ‘nix-store -r’ or ‘nix-build’ will cause Nix to redo the build of a derivation whose output paths are already valid. If the new output differs from the original output, an error is printed. This makes it easier to test if a build is deterministic. (Obviously this cannot catch all sources of non-determinism, but it catches the most common one, namely the current time.) For example: $ nix-build '<nixpkgs>' -A patchelf ... $ nix-build '<nixpkgs>' -A patchelf --check error: derivation `/nix/store/1ipvxsdnbhl1rw6siz6x92s7sc8nwkkb-patchelf-0.6' may not be deterministic: hash mismatch in output `/nix/store/4pc1dmw5xkwmc6q3gdc9i5nbjl4dkjpp-patchelf-0.6.drv' The --check build fails if not all outputs are valid. Thus the first call to nix-build is necessary to ensure that all outputs are valid. The current outputs are left untouched: the new outputs are either put in a chroot or diverted to a different location in the store using hash rewriting.
2014-02-17	Make --repair work on Darwin	Eelco Dolstra	1	-3/+3
	Mac OS X doesn't allow renaming a read-only directory. http://hydra.nixos.org/build/9113895
2014-02-17	Refactoring	Eelco Dolstra	1	-29/+36

2014-02-17	When using a build hook, only copy missing paths	Eelco Dolstra	1	-9/+6

2014-02-17	Move some code around	Eelco Dolstra	1	-92/+82
	In particular, do replacing of valid paths during repair later. This prevents us from replacing a valid path after the build fails.
2014-02-17	Heuristically detect if a build may have failed due to a full disk	Eelco Dolstra	1	-3/+26
	This will allow Hydra to detect that a build should not be marked as "permanently failed", allowing it to be retried later.
2014-01-21	Fix some clang warnings	Eelco Dolstra	1	-4/+1

2014-01-08	Fix checking of NAR hashes	Eelco Dolstra	1	-0/+1
	headdesk headdesk headdesk So since commit 22144afa8d9f8968da351618a1347072a93bd8aa, Nix hasn't actually checked whether the content of a downloaded NAR matches the hash specified in the manifest / NAR info file. Urghhh...
2014-01-06	wording	Domen Kožar	1	-1/+1

2013-12-05	Print a trace message if a build fails due to the platform being unknown	Eelco Dolstra	1	-1/+4

2013-11-14	Remove nix-setuid-helper	Eelco Dolstra	1	-141/+26
	AFAIK, nobody uses it, it's not maintained, and it has no tests.
2013-09-02	Only show trace messages when tracing is enabled	Eelco Dolstra	1	-4/+3

2013-09-02	Add an option to limit the log output of builders	Eelco Dolstra	1	-0/+13
	This is mostly useful for Hydra to deal with builders that get stuck in an infinite loop writing data to stdout/stderr.
2013-08-26	Fix personality switching from x86_64 to i686	Gergely Risko	1	-1/+6
	On Linux, Nix can build i686 packages even on x86_64 systems. It's not enough to recognize this situation by settings.thisSystem, we also have to consult uname(). E.g. we can be running on a i686 Debian with an amd64 kernel. In that situation settings.thisSystem is i686-linux, but we still need to change personality to i686 to make builds consistent.
2013-08-07	Run the daemon worker on the same CPU as the client	Eelco Dolstra	1	-0/+4
	On a system with multiple CPUs, running Nix operations through the daemon is significantly slower than "direct" mode: $ NIX_REMOTE= nix-instantiate '<nixos>' -A system real 0m0.974s user 0m0.875s sys 0m0.088s $ NIX_REMOTE=daemon nix-instantiate '<nixos>' -A system real 0m2.118s user 0m1.463s sys 0m0.218s The main reason seems to be that the client and the worker get moved to a different CPU after every call to the worker. This patch adds a hack to lock them to the same CPU. With this, the overhead of going through the daemon is very small: $ NIX_REMOTE=daemon nix-instantiate '<nixos>' -A system real 0m1.074s user 0m0.809s sys 0m0.098s
2013-07-18	Revert "build-remote.pl: Enforce timeouts locally"	Eelco Dolstra	1	-1/+3
	This reverts commit 69b8f9980f39c14a59365a188b300a34d625a2cd. The timeout should be enforced remotely. Otherwise, if the garbage collector is running either locally or remotely, if will block the build or closure copying for some time. If the garbage collector takes too long, the build may time out, which is not what we want. Also, on heavily loaded systems, copying large paths to and from the remote machine can take a long time, also potentially resulting in a timeout.