depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2011-07-20	* Fix a huuuuge security hole in the Nix daemon. It didn't check that	Eelco Dolstra	2	-65/+3
	derivations added to the store by clients have "correct" output paths (meaning that the output paths are computed by hashing the derivation according to a certain algorithm). This means that a malicious user could craft a special .drv file to build any desired path in the store with any desired contents (so long as the path doesn't already exist). Then the attacker just needs to wait for a victim to come along and install the compromised path. For instance, if Alice (the attacker) knows that the latest Firefox derivation in Nixpkgs produces the path /nix/store/1a5nyfd4ajxbyy97r1fslhgrv70gj8a7-firefox-5.0.1 then (provided this path doesn't already exist) she can craft a .drv file that creates that path (i.e., has it as one of its outputs), add it to the store using "nix-store --add", and build it with "nix-store -r". So the fake .drv could write a Trojan to the Firefox path. Then, if user Bob (the victim) comes along and does $ nix-env -i firefox $ firefox he executes the Trojan injected by Alice. The fix is to have the Nix daemon verify that derivation outputs are correct (in addValidPath()). This required some refactoring to move the hash computation code to libstore.
2011-07-18	* Support multiple outputs. A derivation can declare multiple outputs	Eelco Dolstra	1	-45/+84
	by setting the ‘outputs’ attribute. For example: stdenv.mkDerivation { name = "aterm-2.5"; src = ...; outputs = [ "out" "tools" "dev" ]; configureFlags = "--bindir=$(tools)/bin --includedir=$(dev)/include"; } This derivation creates three outputs, named like this: /nix/store/gcnqgllbh01p3d448q8q6pzn2nc2gpyl-aterm-2.5 /nix/store/gjf1sgirwfnrlr0bdxyrwzpw2r304j02-aterm-2.5-tools /nix/store/hp6108bqfgxvza25nnxfs7kj88xi2vdx-aterm-2.5-dev That is, the symbolic name of the output is suffixed to the store path (except for the ‘out’ output). Each path is passed to the builder through the corresponding environment variable, e.g., ${tools}. The main reason for multiple outputs is to allow parts of a package to be distributed and garbage-collected separately. For instance, most packages depend on Glibc for its libraries, but don't need its header files. If these are separated into different store paths, then a package that depends on the Glibc libraries only causes the libraries and not the headers to be downloaded. The main problem with multiple outputs is that if one output exists while the others have been garbage-collected (or never downloaded in the first place), and we want to rebuild the other outputs, then this isn't possible because we can't clobber a valid output (it might be in active use). This currently gives an error message like: error: derivation `/nix/store/1s9zw4c8qydpjyrayxamx2z7zzp5pcgh-aterm-2.5.drv' is blocked by its output paths There are two solutions: 1) Do the build in a chroot. Then we don't need to overwrite the existing path. 2) Use hash rewriting (see the ASE-2005 paper). Scary but it should work. This is not finished yet. There is not yet an easy way to refer to non-default outputs in Nix expressions. Also, mutually recursive outputs aren't detected yet and cause the garbage collector to crash.
2011-07-13	* Allow attribute names to be strings. Based on the	Eelco Dolstra	1	-0/+2
	allow-arbitrary-strinsg-in-names patch by Marc Weber.
2011-07-13	* Allow a default value in attribute selection by writing	Eelco Dolstra	5	-21/+43
	x.y.z or default (as originally proposed in https://mail.cs.uu.nl/pipermail/nix-dev/2009-September/002989.html). For instance, an expression like stdenv.lib.attrByPath ["features" "ckSched"] false args can now be written as args.features.ckSched or false
2011-07-06	* Change the right-hand side of the ‘.’ operator from an attribute to	Eelco Dolstra	4	-18/+33
	an attribute path. This is a refactoring to support default values.
2011-07-06	* In the ‘?’ operator, allow attribute paths. For instance, you can	Eelco Dolstra	4	-24/+47
	write ‘attrs ? a.b’ to test whether ‘attrs’ has an attribute ‘a’ containing an attribute ‘b’. This is more convenient than ‘attrs ? a && attrs.a ? b’. Slight change in the semantics: it's no longer an error if the left-hand side of ‘?’ is not an attribute set. In that case it just returns false. So, ‘null ? foo’ no longer throws an error.
2011-02-10	* Don't allocate a big initial GC address space on machines with	Eelco Dolstra	1	-11/+24
	little RAM. Even if the memory isn't actually used, it can cause problems with the overcommit heuristics in the kernel. So use a VM space of 25% of RAM, up to 384 MB.
2011-02-09	* Don't call GC_expand_hp unless we're actually using the garbage	Eelco Dolstra	1	-0/+18
	collector.
2011-02-09	Use $BDW_GC_LIBS instead of a custom variable.	Ludovic Courtès	1	-1/+1

2011-01-14	* builtins.substring: if "start" is beyond the end of the string,	Eelco Dolstra	1	-1/+1
	return the empty string.
2010-11-25	* DrvInfo contains pointers to expressions, so DrvInfos should be	Eelco Dolstra	1	-0/+4
	traced by the garbage collector. Otherwise "nix-env -u" can crash randomly.
2010-10-28	* new(UseGC) is inexplicably slower than GC_MALLOC, so prefer the	Eelco Dolstra	1	-4/+4
	latter.
2010-10-28	* Handle out of memory condition.	Eelco Dolstra	1	-5/+5

2010-10-24	* When allocating an attribute set, reserve enough space for all	Eelco Dolstra	3	-25/+18
	elements. This prevents the vector from having to resize itself.
2010-10-24	* Keep attribute sets in sorted order to speed up attribute lookups.	Eelco Dolstra	9	-139/+172
	* Simplify the representation of attributes in the AST. * Change the behaviour of listToAttrs() in case of duplicate names.
2010-10-24	* Don't create thunks for variable lookups (if possible). This	Eelco Dolstra	3	-23/+60
	significantly reduces the number of values allocated (e.g. from 8.7m to 4.9m for the Bittorrent test).
2010-10-24	* Store attribute sets as a vector instead of a map (i.e. a red-black	Eelco Dolstra	7	-90/+129
	tree). This saves a lot of memory. The vector should be sorted so that names can be looked up using binary search, but this is not the case yet. (Surprisingly, looking up attributes using linear search doesn't have a big impact on performance.) Memory consumption for $ nix-instantiate /etc/nixos/nixos/tests -A bittorrent.test --readonly-mode on x86_64-linux with GC enabled is now 185 MiB (compared to 946 MiB on the trunk).
2010-10-23	* Fix compiling without Boehm.	Eelco Dolstra	1	-10/+8
	* Fix the stats.
2010-10-23	* Optimise string constants by putting them in the symbol table.	Eelco Dolstra	4	-39/+55

2010-10-23	* Make Value smaller by not storing redundant PrimOp info.	Eelco Dolstra	2	-25/+44
	* Clear pointers in Values after overwriting them to make sure that no objects are kept alive unnecessarily.
2010-10-23	* Remove allocValues().	Eelco Dolstra	3	-34/+12

2010-10-22	* In environments, store pointers to values rather than values. This	Eelco Dolstra	2	-35/+25
	improves GC effectiveness a bit more (because a live value doesn't keep other values in the environment plus the parent environments alive), and removes the need for copy nodes.
2010-10-22	* Store Value nodes outside of attribute sets. I.e., Attr now stores	Eelco Dolstra	12	-116/+135
	a pointer to a Value, rather than the Value directly. This improves the effectiveness of garbage collection a lot: if the Value is stored inside the set directly, then any live pointer to the Value causes all other attributes in the set to be live as well.
2010-10-22	* Make building against the Boehm GC a configure option.	Eelco Dolstra	3	-7/+25

2010-10-20	* Keep some more stats.	Eelco Dolstra	2	-0/+12

2010-10-20	* Use the Boehm garbage collector to reclaim unused memory in the Nix	Eelco Dolstra	3	-11/+20
	expression evaluator.
2010-10-04	* Make sure that config.h is included before the system headers,	Eelco Dolstra	7	-18/+16
	because it defines _FILE_OFFSET_BITS. Without this, on OpenSolaris the system headers define it to be 32, and then the 32-bit stat() ends up being called with a 64-bit "struct stat", or vice versa. This also ensures that we get 64-bit file sizes everywhere. * Remove the redundant call to stat() in parseExprFromFile(). The file cannot be a symlink because that's the exit condition of the loop before.
2010-10-04	* If std::tr1::unordered_set is unavailable, use std::set.	Eelco Dolstra	1	-0/+9

2010-10-04	* Hack needed for GCC 4.3.2 on OpenSolaris.	Eelco Dolstra	1	-1/+1

2010-08-27	* Oops - "null" was displayed as "true".	Eelco Dolstra	1	-1/+1

2010-08-02	* Optimisation in the // operator: if one of the sets is empty, return	Eelco Dolstra	1	-6/+8
	the other set.
2010-08-02	* intersectAttrs: optimise for the case where the second set is larger	Eelco Dolstra	1	-7/+7
	than the first set. (That's usually the case with callPackage.)
2010-06-10	* builtins.toXML: propagate the string context. This is a regression	Eelco Dolstra	3	-5/+12
	from the old ATerm-based evaluator.
2010-06-02	(no commit message)	Eelco Dolstra	1	-0/+1

2010-06-01	* Turn build errors during evaluation into EvalErrors.	Eelco Dolstra	2	-1/+6

2010-05-18	* The << operator on values should be const.	Eelco Dolstra	3	-3/+3

2010-05-15	* Restore the __overrides feature that was lost somewhere in the	Eelco Dolstra	2	-3/+21
	fast-eval branch.
2010-05-12	* Print attributes in sorted order.	Eelco Dolstra	1	-2/+7

2010-05-12	* Implemented tryEval, the last missing primop in the fast-eval	Eelco Dolstra	1	-12/+6
	branch. Also added a test for tryEval.
2010-05-07	(no commit message)	Eelco Dolstra	1	-0/+2

2010-05-07	* Sync with the trunk.	Eelco Dolstra	3	-21/+45

2010-05-07	* Store position info for inherited attributes.	Eelco Dolstra	4	-25/+29

2010-05-07	* Updated addErrorContext.	Eelco Dolstra	1	-6/+7

2010-05-07	* Keep track of the source positions of attributes.	Eelco Dolstra	7	-76/+107

2010-05-06	* Store attribute positions in the AST and report duplicate attribute	Eelco Dolstra	5	-54/+53
	errors with position info. * For all positions, use the position of the first character of the first token, rather than the last character of the first token plus one.
2010-04-23	* Don't need the test program anymore.	Eelco Dolstra	2	-135/+0

2010-04-22	* Simplify the implementation of `with'. This gives a 7% speedup in	Eelco Dolstra	4	-30/+15
	evaluating the NixOS system configuration.
2010-04-22	* Check for duplicate attribute names / function arguments. `make	Eelco Dolstra	2	-44/+48
	check' now succeeds :-) * An attribute set such as `{ foo = { enable = true; }; foo.port = 23; }' now parses. It was previously rejected, but I'm too lazy to implement the check. (The only reason to reject it is that the reverse, `{ foo.port = 23; foo = { enable = true; }; }', is rejected, which is kind of ugly.)
2010-04-22	* String equality tests should take the context into account. All the	Eelco Dolstra	2	-4/+12
	evaluation test cases now succeed.
2010-04-21	* Fix the interpretation of ''\<character> in indented strings.	Eelco Dolstra	1	-1/+1