depot - monorepo for the virus lounge

Age	Commit message (Collapse)	Author	Files	Lines
2012-07-25	prim_import: When importing .drvs, allocate the intermediate attrset on the ↵	Shea Levy	1	-1/+1
	heap just in case it escapes the stack frame.
2012-07-25	import: If the path is a valid .drv file, parse it and generate a derivation ↵	Shea Levy	1	-1/+25
	attrset. The generated attrset has drvPath and outPath with the right string context, type 'derivation', outputName with the right name, all with a list of outputs, and an attribute for each output. I see three uses for this (though certainly there may be more): * Using derivations generated by something besides nix-instantiate (e.g. guix) * Allowing packages provided by channels to be used in nix expressions. If a channel installed a valid deriver for each package it provides into the store, then those could be imported and used as dependencies or installed in environment.systemPackages, for example. * Enable hydra to be consistent in how it treats inputs that are outputs of another build. Right now, if an input is passed as an argument to the job, it is passed as a derivation, but if it is accessed via NIX_PATH (i.e. through the <> syntax), then it is a path that can be imported. This is problematic because the build being depended upon may have been built with non-obvious arguments passed to its jobset file. With this feature, hydra can just set the name of that input to the path to its drv file in NIX_PATH
2012-07-12	builtins.storePath: resolve symlinks	Eelco Dolstra	1	-1/+5
	Needed for Charon/Hydra interaction.
2012-06-27	nix-store -r: do substitutions in parallel	Eelco Dolstra	1	-1/+1
	I.e. when multiple non-derivation arguments are passed to ‘nix-store -r’ to be substituted, do them in parallel.
2012-02-04	* Inline some functions and get rid of the indirection through	Eelco Dolstra	1	-0/+1
	EvalState::eval(). This gives a 12% speedup on ‘nix-instantiate /etc/nixos/nixos/ -A system --readonly-mode’ (from 1.01s to 0.89s).
2012-01-26	* Fix importing a derivation. This gave a segfault.	Eelco Dolstra	1	-8/+23

2012-01-19	* Add some debug output to print the derivation name once it's known.	Eelco Dolstra	1	-1/+4
	This makes it easier to pinpoint the source of a crash.
2012-01-03	* Drop the inefficient "Path" suffix in output attribute names.	Eelco Dolstra	1	-3/+1

2012-01-03	* Move the implementation of the ‘derivation’ primop into a separate	Eelco Dolstra	1	-23/+1
	file.
2011-12-21	* The ‘foo.drvPath’ feature was already broken in read-only mode.	Eelco Dolstra	1	-1/+2
	Since it's rarely used and fixing it is too much work right now, just document it.
2011-12-21	* Simplify the context handling logic.	Eelco Dolstra	1	-24/+13

2011-12-16	* Sync with the trunk.	Eelco Dolstra	1	-14/+3

2011-12-02	* Move parseHash16or32 into libutil, and use in nix-hash.	Eelco Dolstra	1	-11/+1

2011-11-06	There's no need to mess with drvPath at all	Shea Levy	1	-6/+4

2011-11-06	Fix faulty reversion of my changes to unsafeDiscardOutputDependency	Shea Levy	1	-1/+1

2011-11-06	Respect all outputs passed to the derivation, not just the last one	Shea Levy	1	-1/+3

2011-11-06	Embed output name into the context of the *OutPath attributes and extract it ↵	Shea Levy	1	-2/+9
	for input derivations Multiple outputs test passes!
2011-11-06	Include all outputs of derivations in the closure of explicitly-passed ↵	Shea Levy	1	-2/+8
	derivation paths This required adding a queryOutputDerivationNames function in the store API
2011-11-06	The 'insert output between = signs' approach was not helpful	Shea Levy	1	-9/+2

2011-09-16	Remove the current output metadata from the string for ↵	Shea Levy	1	-1/+8
	unsaveDiscardOutputDependency
2011-09-16	Add information about which output is active to drvPath's context	Shea Levy	1	-4/+6
	This will break things that depend on being able to just strip away an equals sign, so those have to be updated next
2011-09-16	Add a currentOutput attribute to derivations keep track of which output is ↵	Shea Levy	1	-1/+4
	active
2011-09-14	First attempt at the output-as-derivation semantics	Shea Levy	1	-9/+27
	For each output, this adds a corresponding attribute to the derivation that is the same as the derivation except for outPath, which is set to the path specific to that output. Additionally, an "all" attribute is added that is a list of all of the output derivations. This has to be done outside of derivationStrict as each output is itself a derivation that contains itself (and all other outputs) as an attribute. The derivation itself is equivalent to the first output in the outputs list (or "out" if that list isn't set).
2011-08-31	* Eliminate all uses of the global variable ‘store’ from libstore.	Eelco Dolstra	1	-4/+4
	This should also fix: nix-instantiate: ./../boost/shared_ptr.hpp:254: T* boost::shared_ptr<T>::operator->() const [with T = nix::StoreAPI]: Assertion `px != 0' failed. which was caused by hashDerivationModulo() calling the ‘store’ object (during store upgrades) before openStore() assigned it.
2011-08-06	* Refactoring: move parseExprFromFile() and parseExprFromString() into	Eelco Dolstra	1	-2/+1
	the EvalState class.
2011-07-20	* Don't allow derivations with fixed and non-fixed outputs.	Eelco Dolstra	1	-43/+38

2011-07-20	* Fix a huuuuge security hole in the Nix daemon. It didn't check that	Eelco Dolstra	1	-61/+3
	derivations added to the store by clients have "correct" output paths (meaning that the output paths are computed by hashing the derivation according to a certain algorithm). This means that a malicious user could craft a special .drv file to build any desired path in the store with any desired contents (so long as the path doesn't already exist). Then the attacker just needs to wait for a victim to come along and install the compromised path. For instance, if Alice (the attacker) knows that the latest Firefox derivation in Nixpkgs produces the path /nix/store/1a5nyfd4ajxbyy97r1fslhgrv70gj8a7-firefox-5.0.1 then (provided this path doesn't already exist) she can craft a .drv file that creates that path (i.e., has it as one of its outputs), add it to the store using "nix-store --add", and build it with "nix-store -r". So the fake .drv could write a Trojan to the Firefox path. Then, if user Bob (the victim) comes along and does $ nix-env -i firefox $ firefox he executes the Trojan injected by Alice. The fix is to have the Nix daemon verify that derivation outputs are correct (in addValidPath()). This required some refactoring to move the hash computation code to libstore.
2011-07-18	* Support multiple outputs. A derivation can declare multiple outputs	Eelco Dolstra	1	-45/+84
	by setting the ‘outputs’ attribute. For example: stdenv.mkDerivation { name = "aterm-2.5"; src = ...; outputs = [ "out" "tools" "dev" ]; configureFlags = "--bindir=$(tools)/bin --includedir=$(dev)/include"; } This derivation creates three outputs, named like this: /nix/store/gcnqgllbh01p3d448q8q6pzn2nc2gpyl-aterm-2.5 /nix/store/gjf1sgirwfnrlr0bdxyrwzpw2r304j02-aterm-2.5-tools /nix/store/hp6108bqfgxvza25nnxfs7kj88xi2vdx-aterm-2.5-dev That is, the symbolic name of the output is suffixed to the store path (except for the ‘out’ output). Each path is passed to the builder through the corresponding environment variable, e.g., ${tools}. The main reason for multiple outputs is to allow parts of a package to be distributed and garbage-collected separately. For instance, most packages depend on Glibc for its libraries, but don't need its header files. If these are separated into different store paths, then a package that depends on the Glibc libraries only causes the libraries and not the headers to be downloaded. The main problem with multiple outputs is that if one output exists while the others have been garbage-collected (or never downloaded in the first place), and we want to rebuild the other outputs, then this isn't possible because we can't clobber a valid output (it might be in active use). This currently gives an error message like: error: derivation `/nix/store/1s9zw4c8qydpjyrayxamx2z7zzp5pcgh-aterm-2.5.drv' is blocked by its output paths There are two solutions: 1) Do the build in a chroot. Then we don't need to overwrite the existing path. 2) Use hash rewriting (see the ASE-2005 paper). Scary but it should work. This is not finished yet. There is not yet an easy way to refer to non-default outputs in Nix expressions. Also, mutually recursive outputs aren't detected yet and cause the garbage collector to crash.
2011-01-14	* builtins.substring: if "start" is beyond the end of the string,	Eelco Dolstra	1	-1/+1
	return the empty string.
2010-10-24	* When allocating an attribute set, reserve enough space for all	Eelco Dolstra	1	-11/+12
	elements. This prevents the vector from having to resize itself.
2010-10-24	* Keep attribute sets in sorted order to speed up attribute lookups.	Eelco Dolstra	1	-8/+24
	* Simplify the representation of attributes in the AST. * Change the behaviour of listToAttrs() in case of duplicate names.
2010-10-24	* Don't create thunks for variable lookups (if possible). This	Eelco Dolstra	1	-1/+1
	significantly reduces the number of values allocated (e.g. from 8.7m to 4.9m for the Bittorrent test).
2010-10-24	* Store attribute sets as a vector instead of a map (i.e. a red-black	Eelco Dolstra	1	-28/+37
	tree). This saves a lot of memory. The vector should be sorted so that names can be looked up using binary search, but this is not the case yet. (Surprisingly, looking up attributes using linear search doesn't have a big impact on performance.) Memory consumption for $ nix-instantiate /etc/nixos/nixos/tests -A bittorrent.test --readonly-mode on x86_64-linux with GC enabled is now 185 MiB (compared to 946 MiB on the trunk).
2010-10-23	* Remove allocValues().	Eelco Dolstra	1	-16/+7

2010-10-22	* Store Value nodes outside of attribute sets. I.e., Attr now stores	Eelco Dolstra	1	-36/+34
	a pointer to a Value, rather than the Value directly. This improves the effectiveness of garbage collection a lot: if the Value is stored inside the set directly, then any live pointer to the Value causes all other attributes in the set to be live as well.
2010-10-04	* Make sure that config.h is included before the system headers,	Eelco Dolstra	1	-1/+1
	because it defines _FILE_OFFSET_BITS. Without this, on OpenSolaris the system headers define it to be 32, and then the 32-bit stat() ends up being called with a 64-bit "struct stat", or vice versa. This also ensures that we get 64-bit file sizes everywhere. * Remove the redundant call to stat() in parseExprFromFile(). The file cannot be a symlink because that's the exit condition of the loop before.
2010-08-02	* intersectAttrs: optimise for the case where the second set is larger	Eelco Dolstra	1	-7/+7
	than the first set. (That's usually the case with callPackage.)
2010-06-01	* Turn build errors during evaluation into EvalErrors.	Eelco Dolstra	1	-1/+5

2010-05-12	* Implemented tryEval, the last missing primop in the fast-eval	Eelco Dolstra	1	-12/+6
	branch. Also added a test for tryEval.
2010-05-07	* Sync with the trunk.	Eelco Dolstra	1	-1/+1

2010-05-07	* Updated addErrorContext.	Eelco Dolstra	1	-6/+7

2010-05-07	* Keep track of the source positions of attributes.	Eelco Dolstra	1	-30/+36

2010-04-21	* Fixed builtins.genericClosure.	Eelco Dolstra	1	-22/+54

2010-04-21	* Store user environment manifests as a Nix expression in	Eelco Dolstra	1	-14/+17
	$out/manifest.nix rather than as an ATerm. (Hm, I thought I committed this two days ago...)
2010-04-19	* Don't use the ATerm library for parsing/printing .drv files.	Eelco Dolstra	1	-1/+1

2010-04-16	* Updated some more primops.	Eelco Dolstra	1	-48/+23

2010-04-16	* Improve sharing a bit.	Eelco Dolstra	1	-1/+1

2010-04-15	* Store lists as lists of pointers to values rather than as lists of	Eelco Dolstra	1	-11/+16
	values. This improves sharing and gives another speed up. Evaluation of the NixOS system attribute is now almost 7 times faster than the old evaluator.
2010-04-14	* Fix builtins.	Eelco Dolstra	1	-15/+11

2010-04-14	* After parsing, compute level/displacement pairs for each variable	Eelco Dolstra	1	-0/+4
	use site, allowing environments to be stores as vectors of values rather than maps. This should speed up evaluation and reduce the number of allocations.