about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
2024-11-23 r/8959 chore(tvix/nix-compat-derive-tests): update fixturesFlorian Klink1-5/+5
With more implementing NixDeserialize, this error message changed. Fixtures were regenerated by running: ``` TRYBUILD=overwrite cargo test -p nix-compat-derive-tests --all-features ``` Unfortunately, it's not possible to loop this into CI, as trybuild invokes cargo during the build. Change-Id: Ia0ab07d0907d21366845fe06e01df9fb1fe3e7cb Reviewed-on: https://cl.tvl.fyi/c/depot/+/12831 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI
2024-11-23 r/8958 refactor(users/flokli/nixos-tvix-cache): absorb otlpcollector into alloyFlorian Klink1-49/+33
We don't need a separate instance of opentelemetry-collector, alloy can also do this job for us. Change-Id: I1b671ba57d70b080f7db112e1afcfe2e0cbdd13e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12829 Reviewed-by: flokli <flokli@flokli.de> Reviewed-by: Jonas Chevalier <zimbatm@zimbatm.com> Tested-by: BuildkiteCI
2024-11-23 r/8957 fix(users/flokli/nixos-tvix-cache): bump max_traces_per_userFlorian Klink1-0/+2
These are quite bursty, and I've seen messages about getting rate limited. Change-Id: I73058140957cb5718971fa432c003c2d1b0305e3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12828 Tested-by: BuildkiteCI Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
2024-11-23 r/8956 feat(users/flokli/nixos/nixos-tvix-cache): also collect system metricszimbatm1-0/+26
Use grafana-alloy to collect system metrics. Change-Id: I592e64ca722701d4f12e69a531a434b54954955a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12827 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-11-23 r/8955 fix(tvix/nar-bridge): explicitly select fields to add to spanFlorian Klink2-5/+5
We got some double-quoted strings at narinfo_str, and it didn't align well with our other field names. Change-Id: I5c08786d2c4435542bf39ff44b9d4ada5400550d Reviewed-on: https://cl.tvl.fyi/c/depot/+/12826 Tested-by: BuildkiteCI Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
2024-11-23 r/8954 fix(tvix/castore): instrument blob uploads with current spanFlorian Klink1-0/+2
Change-Id: I67e18486c48f06787fad8be506e95eecc23e994d Reviewed-on: https://cl.tvl.fyi/c/depot/+/12825 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Jonas Chevalier <zimbatm@zimbatm.com>
2024-11-23 r/8953 fix(tvix/nar-bridge): set correct service nameFlorian Klink1-1/+1
We should be able to distinguish tvix-store and nar-bridge. Change-Id: I616c8e0c1ce2dbacab92975582dd36141b673aa2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12824 Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: BuildkiteCI
2024-11-23 r/8952 feat(tvix/nar-bridge): wire up metrics layerFlorian Klink7-5/+112
This provides some global HTTP statistics. Change-Id: I8bd3e034123154a49d94720b0c8d0c3babde5ae3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12557 Reviewed-by: Jonas Chevalier <zimbatm@zimbatm.com> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-11-23 r/8951 feat(tvix/tracing): configure metrics supportFlorian Klink1-25/+69
This creates and registers a global meter provider, which uses the same mechanism to get notified of flushes. Change-Id: I856a67f0b282d494de3b2c2a1b79c06ae8ffe252 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12556 Reviewed-by: Jonas Chevalier <zimbatm@zimbatm.com> Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-11-23 r/8950 feat(users/flokli/nixos/nixos-tvix-cache): collect metricsFlorian Klink1-57/+61
This enables routing of metrics to an instance of VictoriaMetrics, and configures opentelemetry-collector to route metrics there. Change-Id: If765191a4cc70ddcaad821d45132b96a10a12148 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12812 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Jonas Chevalier <zimbatm@zimbatm.com>
2024-11-23 r/8949 feat(users/flokli/nixos/nixos-tvix-cache): initFlorian Klink8-0/+555
This is a fetch-through mirror of cache.nixos.org, hosted by NumTide. The current machine is a SX65 Hetzner dedicated server with 4x22TB SATA disks, and 2x1TB NVMe disks. The goals of this machine: - Exercise tvix-store and nar-bridge code - Collect usage metrics (see https://nixos.tvix.store/grafana) - Identify bottlenecks - Replace cache.nixos.org? Be however aware that there's zero availability guarantees. Since Tvix doesn't support garbage collection yet, we either will delete data or order a bigger box. Change-Id: Id24baa18cae1629a06caaa059c0c75d4a01659d5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12811 Tested-by: BuildkiteCI Reviewed-by: Jonas Chevalier <zimbatm@zimbatm.com> Reviewed-by: flokli <flokli@flokli.de>
2024-11-23 r/8948 chore(tvix): bump opentelemetry to 0.27Florian Klink8-510/+218
Change-Id: I3afbd8c94e0bc2cdf30da1886ae05b922f8a718f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12822 Reviewed-by: Jonas Chevalier <zimbatm@zimbatm.com> Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI
2024-11-23 r/8947 feat(tvix/store): add xp-store-composition-cli feature flagFlorian Klink4-3/+10
This can be used to transitively enable the `xp-composition-cli` feature flag in the `tvix-store` crate, which is unnecessarily hard to do with crate2nix. Change-Id: I3f7c505a3fd505561c9a7b2f063b6540532cdfd4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12809 Tested-by: BuildkiteCI Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
2024-11-22 r/8946 fix(users/flokli/nixos): add source_upFlorian Klink1-0/+2
This got lost somehow, but is necessary to keep `mg` in `$PATH`. Change-Id: I2100d68225284bfe825bcc5ab01628891ebd09a3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12810 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: flokli <flokli@flokli.de>
2024-11-20 r/8945 chore(tvix/nix-daemon): Implement framed protocolVova Kryachko2-0/+191
When sending nars over the wire to the nix-daemon, nix protocol versions >= 1.23 use this framing protocol. This change implements an AsyncRead for this protocol, to be used in AddToStoreNar and any other operations when necessary. Change-Id: I5f7972fe1c9ea145780bf449321bd3efeb833d18 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12814 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-11-20 r/8944 chore(tvix/nix-daemon): Implement STDERR_READ protocolVova Kryachko5-3/+400
When sending nars over the wire to the nix-daemon, nix protocol versions 1.21 to 1.23 use this framing protocol. This change implements an AsyncRead for this protocol, to be used in AddToStoreNar and any other operations when necessary. Change-Id: I571f1adbb2343c14c98503d1a2c12eea4c783ec9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12813 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-11-20 r/8943 fix(corp/website): typo s/existence/assistance/Thomas Koch1-1/+1
Change-Id: Ic35bf4706cb660a09fdc36e6ed1d291d429ec7ea Reviewed-on: https://cl.tvl.fyi/c/depot/+/12786 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-11-18 r/8942 refactor(tvix/tracing): simplify flushing channelFlorian Klink1-32/+29
The TracingHandle::flush function allowed a user to pass in their own (optional) oneshot::Sender<()> to get notified once the flush is completed, but that's making things unnecessary complicated. By simply having the flush() function await the flush, we make its interface more intuitive, and callsites (only inside tvix-tracing itself so far) simpler. We can also remove the Option around the oneshot::Sender entirely, as we now always call it with that. For some more clarity, we can remove the channel from the struct fields entirely if otlp support isn't compiled in. Change-Id: I0870b9e8e88c6be6494a9c201c1c70b87e0f0810 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12801 Reviewed-by: flokli <flokli@flokli.de> Reviewed-by: Marijan Petričević <marijan.petricevic94@gmail.com> Tested-by: BuildkiteCI
2024-11-18 r/8941 chore(fun/paroxysm): regenerate Cargo.nix with crate2nix 0.14.1sterni1-65/+127
This should get rid of some deprecation warnings in 🦙. Change-Id: I8588169553a312a4df01d9bf71de7d673f28c431 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12808 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Autosubmit: sterni <sternenseemann@systemli.org>
2024-11-18 r/8940 chore(3p/sources): bump channels & overlayssterni5-16/+22
* //3p/overlays/tvl: build nixos-option with latest Nix version (2.24) as is required now. It would be nice to avoid this somehow to prevent NixOS machines in depot having to carry around two versions of Nix. Maybe we can at least use a statically linked nixos-option? * //3p/{gerrit,gerrit_plugins}: update deps hash * //tvix/eval: adjust our nixVersion “user agent” so that it'll pass the new 2.3.17 minimum version nixpkgs prescribes (to check for zstd support when substituting from the binary cache). Change-Id: I4eb715afdc3dbb857340839f08ce86612aa7f117 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12805 Reviewed-by: flokli <flokli@flokli.de> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2024-11-18 r/8939 chore(sterni/machines/edwin): removesterni3-144/+0
This machine hasn't existed for a while. Seems like I forgot to remove the expression after its final month ran out. Change-Id: I0e4abbd9af75eabfab0db106f851a1e43aa8c90f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12807 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2024-11-18 r/8938 fix(sterni/ingeborg/monitoring): declare missing dep on nginx modulesterni1-0/+1
Change-Id: I68777a6c57068afaa7adfd842778a6f991b9e86a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12806 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2024-11-18 r/8937 feat(sterni/ingeborg/monitoring): expose netdata via nginxsterni3-1/+37
Change-Id: Iea81625180526a36f8646539e8da0ccdaed79d43 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12804 Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2024-11-18 r/8936 chore(sterni/code.sterni.lv): deny indexingsterni1-0/+8
All repositories under code.sterni.lv are mirrors, so there's no value in AI startups endlessly crawling the nixpkgs git history on code.sterni.lv… Change-Id: Iaac296315f325ced3cfd0852ae1d8d3f3815ea5b Reviewed-on: https://cl.tvl.fyi/c/depot/+/12803 Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2024-11-18 r/8935 refactor(sterni/ingeborg/monitoring): simplify mkIrcMessagersterni1-20/+9
I want to add a warpper script to the mdmonitor program anyways, so there's not really a point in this. Change-Id: I92166bd44b54507b782a8d19b9676d91d8fa0f99 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12802 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2024-11-17 r/8934 chore(sterni/ingeborg/minecraft): 1.21.1 -> 1.21.3sterni2-6/+20
Again, 1.21.3 only fixes uninteresting bugs compared to 1.21.2. Change-Id: I406fe9692f21537480db734cf77eca183b6caaad Reviewed-on: https://cl.tvl.fyi/c/depot/+/12799 Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2024-11-17 r/8933 chore(sterni/ingeborg/minecraft): 1.20.4 -> 1.21.1sterni2-6/+23
1.21.1 fixes an exploit in 1.21 without any other changes, so we can safely skip it. Change-Id: I72503c9f3869d7bafdfc78842b61804627a1d452 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12798 Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2024-11-15 r/8932 feat(users/flokli/kb): enable mouse supportFlorian Klink5-7/+37
This switches to a ZMK branch with support for mouse movement, and sets MIRYOKU_KLUDGE_MOUSEKEYSPR so miryoku makes use of the functionality. Change-Id: I3d4f48f10d50c202f909bec15189106a1bbcc1b3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12796 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-11-15 r/8931 feat(sterni/code.sterni.lv): hide emails in cgitsterni1-2/+3
Change-Id: If48823b7992aa61fee9b1a6f458434a596bead90 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12795 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2024-11-15 r/8930 refactor(sterni/code.sterni.lv): downgrade network-online to wantssterni1-1/+1
`requires` is not recommended in this context. I think I tried it out of desperation trying to combat the issue that these units would be started before they were able to resolve names in switch-to-configuration. Unfortunately, network access during switch-to-configuration can't be detected using network-online.target, it seems. Change-Id: Ia98a0a3b505ffa56eb37fb58a5375a1215d6cb1b Reviewed-on: https://cl.tvl.fyi/c/depot/+/12794 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2024-11-15 r/8929 fix(sterni/code.sterni.lv): gc after mirroring repositoriessterni1-0/+3
Repositories (especially nixpkgs) WILL grow to ridiculous sizes otherwise, killing cgit performance in the process. Change-Id: I3bef3e5dc5a61152e89fd53e31f14e78193a4888 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12793 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2024-11-15 r/8928 docs(sterni/machines/ingeborg): add example ssh config for unlocksterni1-0/+7
Mostly it's important (which I did this time at least) to remember that with how things work at the moment, the initrd sshd is only reachable via IPv4. Change-Id: Ie9a87b6a38b2e128a8a2141d2221bbe7cfe24cdb Reviewed-on: https://cl.tvl.fyi/c/depot/+/12792 Autosubmit: sterni <sternenseemann@systemli.org> Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2024-11-15 r/8927 chore(sterni/machines/ingeborg): add usbhid kernel modulesterni1-0/+1
nixos-generate-config claims I need this, so let's add it… Change-Id: I3d852ffce5d0e7c65d9a1bbe887d3de15136698a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12791 Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Autosubmit: sterni <sternenseemann@systemli.org>
2024-11-15 r/8926 fix(ops/modules/irccat): only start after network is onlinesterni1-0/+2
I've discovered that it is possible for irccat to fail enough times to run into the restart limit before network is online after booting. Change-Id: Ia54a46d56bdc765a825fee50e7bdc8206718edc0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12790 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: sterni <sternenseemann@systemli.org>
2024-11-15 r/8925 chore(3p/sources): bump channels & overlays (2024-11-14)Vincent Ambo14-117/+94
* update wasm-bindgen in all wasm projects * //users/wpcarro/website: declare missing dependency on string-conversions. Presumably this was propagated before from some other dependency which got updated now. Change-Id: Ib93de576408974441d532196601e6e53d22cdafe Reviewed-on: https://cl.tvl.fyi/c/depot/+/12770 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: tazjin <tazjin@tvl.su>
2024-11-15 r/8924 chore(web/tvl): restrict owners to myselfVincent Ambo1-0/+3
Change-Id: I4800c542b2af0bc2a5e389342f3574b4928b1704 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12789 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2024-11-15 r/8923 chore(users/flokli/kb/k6_pro): drop unusedFlorian Klink3-119/+0
I don't have this keyboard anymore, no need to build the firmware anymore. Change-Id: I1ab25dfaa71d03dc7006312ecab86453d6f90333 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12788 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-11-15 r/8922 feat(users/flokli/kb): add chocofiFlorian Klink6-48/+88
`buildSplitKeyboard`, as well as all the patching of `miryoku_zmk` is independent of the specific keyboard used, so it can be moved one layer up. `config-flat` is now provided through a helper function, accepting the name of the keymap to use when rendering the config. This all makes the amount of code added for the new keyboard itself pleasantly small. Change-Id: I2216aa246502eddaf9bc4f4d126b0639d574ad87 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12787 Reviewed-by: flokli <flokli@flokli.de> Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-11-14 r/8921 chore(web): Add self to tvl graphVova Kryachko1-0/+2
Change-Id: Ia57768d30db4a841f74c4305cfbae45c9e26522e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12767 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-11-14 r/8920 fix(tazjin/emacs): set telega video player commandVincent Ambo1-1/+2
Change-Id: If5296eb7aa7304801ade7a2c3a1aa6907b051e4f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12768 Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2024-11-14 r/8919 feat(ops/users): add user thkThomas Koch1-0/+5
Change-Id: Ib5e518359e152553d0a9ebf6c674f1acc846800a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12785 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de> Reviewed-by: lukegb <lukegb@tvl.fyi>
2024-11-14 r/8918 feat(nix-daemon): Implement stubs for QueryReferrers, QueryRealizationsVova Kryachko1-1/+18
These are required to support certain nix's local-overlay store operations, it's safer to return empty results for these operations than failing with "operation not implemented" errors. Change-Id: Ic9b69d75dd52af5a826bfb6a8b283b082a0f6bcf Reviewed-on: https://cl.tvl.fyi/c/depot/+/12766 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-11-13 r/8917 feat(nix-daemon): Implement more nix daemon operations.Vova Kryachko16-60/+538
In particular QueryPathFromHashPart, QueryValidPaths, QueryValidDerivers Change-Id: Ie6ad83cec5ce9580044b85e201e4e23394f87075 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12762 Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu> Reviewed-by: flokli <flokli@flokli.de>
2024-11-12 r/8916 feat(tvix-store): Improve tvix-store copy.Vova Kryachko3-12/+117
This change contains 2 improvements to the tvix-store copy command: 1. Allows reading the reference graph from stdin, using `-` argument 2. Supports json representation produced by `nix path-info --json` command. In general it makes is easier and faster to import arbitrary closures from an existing nix store with e.g the following command: ``` nix path-info ./result --json --closure-size --recursive | \ jq -s '{closure: add}' | \ tvix-store copy - ``` Change-Id: Id6eea2993da233ecfbdc186f1a8c37735b686264 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12765 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
2024-11-12 r/8915 refactor(nix-compat/nix_daemon): drop Sync requirement for StorePathFlorian Klink1-5/+6
By manually writing out the async function, and moving the owned String we can avoid for S to be Sync in the NixSerialize for StorePath<S> impl. Co-Authored-By: edef@edef.eu Change-Id: I8427b38d2bd61de2818088728cbad79cda69d17d Reviewed-on: https://cl.tvl.fyi/c/depot/+/12764 Reviewed-by: Vladimir Kryachko <v.kryachko@gmail.com> Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI
2024-11-12 r/8914 docs(tvix): document Store configurationFlorian Klink3-2/+175
This describes the current composition system used for BlobService / DirectoryService / PathInfoService, why it's hidden, how to expose it, and adds some common examples to explain it. Change-Id: I2ce7da40992cc988947c3e924499f8157c5e4937 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12749 Tested-by: BuildkiteCI Reviewed-by: yuka <yuka@yuka.dev>
2024-11-12 r/8913 refactor(nix-compat/store_path): use AsRef<str>Florian Klink5-34/+48
Implement PartialEq/Eq ourselves instead of deriving, by proxying to name.as_ref() (and digest of course). Also implement Hash on our own, clippy doesn't like this to be derived, while Eq/PartialEq is not. Change-Id: Idbe289a23ba3bc8dabf893d4d8752792ae2778c3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12744 Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu> Autosubmit: flokli <flokli@flokli.de>
2024-11-12 r/8912 docs(tvix/eval): update string context documentFlorian Klink1-3/+4
NixString doesn't contain a `HashSet<BuildReference>` anymore, there's a more packed internal data structure. We don't need to be overly specific in the docs, just say we expose an API. Change-Id: I13380c49293f9a86d1916909fdfeefbe64d9024b Reviewed-on: https://cl.tvl.fyi/c/depot/+/12755 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu>
2024-11-12 r/8911 refactor(tvix/eval): rm From<(T, Option<Box<NixContext>>)> for NixStringFlorian Klink2-20/+1
This conversion was a bit too magic, and we can just use `NixString::new_context_from` without having to worry about the distinction between an empty context or no context, as NixString::new_context_from already deals with that internally. Change-Id: I3e5d57ecfa0f7456aa6c526863e49f2523afaec3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12754 Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu> Autosubmit: flokli <flokli@flokli.de>
2024-11-12 r/8910 refactor(tvix/castore/digest): stop using bytes::Bytes internallyFlorian Klink1-24/+25
Change-Id: I07a13da0ae4aee4298025fca4345d738f40cfe5a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12757 Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI