about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
4 days r/8938 fix(sterni/ingeborg/monitoring): declare missing dep on nginx modulesterni1-0/+1
Change-Id: I68777a6c57068afaa7adfd842778a6f991b9e86a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12806 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
4 days r/8937 feat(sterni/ingeborg/monitoring): expose netdata via nginxsterni3-1/+37
Change-Id: Iea81625180526a36f8646539e8da0ccdaed79d43 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12804 Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
4 days r/8936 chore(sterni/code.sterni.lv): deny indexingsterni1-0/+8
All repositories under code.sterni.lv are mirrors, so there's no value in AI startups endlessly crawling the nixpkgs git history on code.sterni.lv… Change-Id: Iaac296315f325ced3cfd0852ae1d8d3f3815ea5b Reviewed-on: https://cl.tvl.fyi/c/depot/+/12803 Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
4 days r/8935 refactor(sterni/ingeborg/monitoring): simplify mkIrcMessagersterni1-20/+9
I want to add a warpper script to the mdmonitor program anyways, so there's not really a point in this. Change-Id: I92166bd44b54507b782a8d19b9676d91d8fa0f99 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12802 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
4 days r/8934 chore(sterni/ingeborg/minecraft): 1.21.1 -> 1.21.3sterni2-6/+20
Again, 1.21.3 only fixes uninteresting bugs compared to 1.21.2. Change-Id: I406fe9692f21537480db734cf77eca183b6caaad Reviewed-on: https://cl.tvl.fyi/c/depot/+/12799 Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
4 days r/8933 chore(sterni/ingeborg/minecraft): 1.20.4 -> 1.21.1sterni2-6/+23
1.21.1 fixes an exploit in 1.21 without any other changes, so we can safely skip it. Change-Id: I72503c9f3869d7bafdfc78842b61804627a1d452 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12798 Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
6 days r/8932 feat(users/flokli/kb): enable mouse supportFlorian Klink5-7/+37
This switches to a ZMK branch with support for mouse movement, and sets MIRYOKU_KLUDGE_MOUSEKEYSPR so miryoku makes use of the functionality. Change-Id: I3d4f48f10d50c202f909bec15189106a1bbcc1b3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12796 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
6 days r/8931 feat(sterni/code.sterni.lv): hide emails in cgitsterni1-2/+3
Change-Id: If48823b7992aa61fee9b1a6f458434a596bead90 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12795 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
6 days r/8930 refactor(sterni/code.sterni.lv): downgrade network-online to wantssterni1-1/+1
`requires` is not recommended in this context. I think I tried it out of desperation trying to combat the issue that these units would be started before they were able to resolve names in switch-to-configuration. Unfortunately, network access during switch-to-configuration can't be detected using network-online.target, it seems. Change-Id: Ia98a0a3b505ffa56eb37fb58a5375a1215d6cb1b Reviewed-on: https://cl.tvl.fyi/c/depot/+/12794 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
6 days r/8929 fix(sterni/code.sterni.lv): gc after mirroring repositoriessterni1-0/+3
Repositories (especially nixpkgs) WILL grow to ridiculous sizes otherwise, killing cgit performance in the process. Change-Id: I3bef3e5dc5a61152e89fd53e31f14e78193a4888 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12793 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
6 days r/8928 docs(sterni/machines/ingeborg): add example ssh config for unlocksterni1-0/+7
Mostly it's important (which I did this time at least) to remember that with how things work at the moment, the initrd sshd is only reachable via IPv4. Change-Id: Ie9a87b6a38b2e128a8a2141d2221bbe7cfe24cdb Reviewed-on: https://cl.tvl.fyi/c/depot/+/12792 Autosubmit: sterni <sternenseemann@systemli.org> Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
6 days r/8927 chore(sterni/machines/ingeborg): add usbhid kernel modulesterni1-0/+1
nixos-generate-config claims I need this, so let's add it… Change-Id: I3d852ffce5d0e7c65d9a1bbe887d3de15136698a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12791 Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Autosubmit: sterni <sternenseemann@systemli.org>
6 days r/8926 fix(ops/modules/irccat): only start after network is onlinesterni1-0/+2
I've discovered that it is possible for irccat to fail enough times to run into the restart limit before network is online after booting. Change-Id: Ia54a46d56bdc765a825fee50e7bdc8206718edc0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12790 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: sterni <sternenseemann@systemli.org>
6 days r/8925 chore(3p/sources): bump channels & overlays (2024-11-14)Vincent Ambo14-117/+94
* update wasm-bindgen in all wasm projects * //users/wpcarro/website: declare missing dependency on string-conversions. Presumably this was propagated before from some other dependency which got updated now. Change-Id: Ib93de576408974441d532196601e6e53d22cdafe Reviewed-on: https://cl.tvl.fyi/c/depot/+/12770 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: tazjin <tazjin@tvl.su>
7 days r/8924 chore(web/tvl): restrict owners to myselfVincent Ambo1-0/+3
Change-Id: I4800c542b2af0bc2a5e389342f3574b4928b1704 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12789 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
7 days r/8923 chore(users/flokli/kb/k6_pro): drop unusedFlorian Klink3-119/+0
I don't have this keyboard anymore, no need to build the firmware anymore. Change-Id: I1ab25dfaa71d03dc7006312ecab86453d6f90333 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12788 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
7 days r/8922 feat(users/flokli/kb): add chocofiFlorian Klink6-48/+88
`buildSplitKeyboard`, as well as all the patching of `miryoku_zmk` is independent of the specific keyboard used, so it can be moved one layer up. `config-flat` is now provided through a helper function, accepting the name of the keymap to use when rendering the config. This all makes the amount of code added for the new keyboard itself pleasantly small. Change-Id: I2216aa246502eddaf9bc4f4d126b0639d574ad87 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12787 Reviewed-by: flokli <flokli@flokli.de> Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
7 days r/8921 chore(web): Add self to tvl graphVova Kryachko1-0/+2
Change-Id: Ia57768d30db4a841f74c4305cfbae45c9e26522e Reviewed-on: https://cl.tvl.fyi/c/depot/+/12767 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
7 days r/8920 fix(tazjin/emacs): set telega video player commandVincent Ambo1-1/+2
Change-Id: If5296eb7aa7304801ade7a2c3a1aa6907b051e4f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12768 Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
7 days r/8919 feat(ops/users): add user thkThomas Koch1-0/+5
Change-Id: Ib5e518359e152553d0a9ebf6c674f1acc846800a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12785 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de> Reviewed-by: lukegb <lukegb@tvl.fyi>
7 days r/8918 feat(nix-daemon): Implement stubs for QueryReferrers, QueryRealizationsVova Kryachko1-1/+18
These are required to support certain nix's local-overlay store operations, it's safer to return empty results for these operations than failing with "operation not implemented" errors. Change-Id: Ic9b69d75dd52af5a826bfb6a8b283b082a0f6bcf Reviewed-on: https://cl.tvl.fyi/c/depot/+/12766 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
8 days r/8917 feat(nix-daemon): Implement more nix daemon operations.Vova Kryachko16-60/+538
In particular QueryPathFromHashPart, QueryValidPaths, QueryValidDerivers Change-Id: Ie6ad83cec5ce9580044b85e201e4e23394f87075 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12762 Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu> Reviewed-by: flokli <flokli@flokli.de>
9 days r/8916 feat(tvix-store): Improve tvix-store copy.Vova Kryachko3-12/+117
This change contains 2 improvements to the tvix-store copy command: 1. Allows reading the reference graph from stdin, using `-` argument 2. Supports json representation produced by `nix path-info --json` command. In general it makes is easier and faster to import arbitrary closures from an existing nix store with e.g the following command: ``` nix path-info ./result --json --closure-size --recursive | \ jq -s '{closure: add}' | \ tvix-store copy - ``` Change-Id: Id6eea2993da233ecfbdc186f1a8c37735b686264 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12765 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
9 days r/8915 refactor(nix-compat/nix_daemon): drop Sync requirement for StorePathFlorian Klink1-5/+6
By manually writing out the async function, and moving the owned String we can avoid for S to be Sync in the NixSerialize for StorePath<S> impl. Co-Authored-By: edef@edef.eu Change-Id: I8427b38d2bd61de2818088728cbad79cda69d17d Reviewed-on: https://cl.tvl.fyi/c/depot/+/12764 Reviewed-by: Vladimir Kryachko <v.kryachko@gmail.com> Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI
9 days r/8914 docs(tvix): document Store configurationFlorian Klink3-2/+175
This describes the current composition system used for BlobService / DirectoryService / PathInfoService, why it's hidden, how to expose it, and adds some common examples to explain it. Change-Id: I2ce7da40992cc988947c3e924499f8157c5e4937 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12749 Tested-by: BuildkiteCI Reviewed-by: yuka <yuka@yuka.dev>
10 days r/8913 refactor(nix-compat/store_path): use AsRef<str>Florian Klink5-34/+48
Implement PartialEq/Eq ourselves instead of deriving, by proxying to name.as_ref() (and digest of course). Also implement Hash on our own, clippy doesn't like this to be derived, while Eq/PartialEq is not. Change-Id: Idbe289a23ba3bc8dabf893d4d8752792ae2778c3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12744 Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu> Autosubmit: flokli <flokli@flokli.de>
10 days r/8912 docs(tvix/eval): update string context documentFlorian Klink1-3/+4
NixString doesn't contain a `HashSet<BuildReference>` anymore, there's a more packed internal data structure. We don't need to be overly specific in the docs, just say we expose an API. Change-Id: I13380c49293f9a86d1916909fdfeefbe64d9024b Reviewed-on: https://cl.tvl.fyi/c/depot/+/12755 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu>
10 days r/8911 refactor(tvix/eval): rm From<(T, Option<Box<NixContext>>)> for NixStringFlorian Klink2-20/+1
This conversion was a bit too magic, and we can just use `NixString::new_context_from` without having to worry about the distinction between an empty context or no context, as NixString::new_context_from already deals with that internally. Change-Id: I3e5d57ecfa0f7456aa6c526863e49f2523afaec3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12754 Tested-by: BuildkiteCI Reviewed-by: edef <edef@edef.eu> Autosubmit: flokli <flokli@flokli.de>
10 days r/8910 refactor(tvix/castore/digest): stop using bytes::Bytes internallyFlorian Klink1-24/+25
Change-Id: I07a13da0ae4aee4298025fca4345d738f40cfe5a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12757 Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI
10 days r/8909 docs(tvix): document more componentsFlorian Klink1-0/+6
Change-Id: I0e75445a34d3ee11e535e6948c6d762f4fb15105 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12760 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Domen Kožar <domen@cachix.org> Reviewed-by: flokli <flokli@flokli.de>
10 days r/8908 feat(nix-daemon): Implement QueryPathInfo and IsValidPath.Vova Kryachko4-12/+182
Change-Id: Ia601e2eae24a2bc13d8851b2e8ed9d6c1808bb35 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12745 Reviewed-by: flokli <flokli@flokli.de> Autosubmit: Vladimir Kryachko <v.kryachko@gmail.com> Tested-by: BuildkiteCI
10 days r/8907 feat(nix-daemon): Implement client handler.Vova Kryachko25-253/+1822
This change includes only the basic nix handshake protocol handling and sets up a client session. The only supported operation at this point is SetOptions. Additional operations will be implemented in subsequent cls. Change-Id: I3eccd9e0ceb270c3865929543c702f1491768852 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12743 Autosubmit: Vladimir Kryachko <v.kryachko@gmail.com> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu> Reviewed-by: Brian Olsen <me@griff.name>
10 days r/8906 fix(tvix): use tracing::field::Empty for all indicatif.pb_showFlorian Klink4-4/+4
This prevents the field from getting printed to stderr, apparently. Change-Id: Ia9860e4ff37224003154db88ee5f83103060e626 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12756 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
10 days r/8905 feat(tvix/nar-bridge): make root_nodes_cache_capacity configurableFlorian Klink2-11/+14
Allow this to be overridden via the CLI, also getting rid of the unsafe because this doesn't need to be const anymore. Change-Id: I5e51b52e42522a21f59ef69628b464477c0764d1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12753 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
10 days r/8904 feat(tvix/nar-bridge): avoid unnecessary NAR uploadsFlorian Klink2-8/+32
When uploading a Store Path to a Nix HTTP Binary Cache, Nix first does a HEAD request for $outhash.narinfo, and if that's not found, for `{narhash}.nar[.compression_suffix]`. If the NAR is already present, only the NARInfo is uploaded. Even though we don't have a service allowing to globally look up from NARHash to root node, `root_nodes` in `AppState` at least contains recently uploaded NARHashes. If we find it in there, we can prevent Nix unnecessarily uploading NARs if the same contents have already been recently uploaded. We also promote this key, chances are high Nix will subsequently upload a NARInfo referring to this NARHash. Change-Id: I34e3fd9b334b695abe945e64cd291e30f303c2a2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12752 Tested-by: BuildkiteCI Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Autosubmit: flokli <flokli@flokli.de>
10 days r/8903 refactor(tvix/castore/blob): use near/far for CombinedBlobServiceFlorian Klink2-37/+37
Align this naming with CachePathInfoService. Change-Id: Ib9a0d73b8ca57a93e9fc027ae907fc6ed370842a Reviewed-on: https://cl.tvl.fyi/c/depot/+/12751 Tested-by: BuildkiteCI Reviewed-by: yuka <yuka@yuka.dev>
10 days r/8902 refactor(tvix/store): move Cache to cache modFlorian Klink2-4/+2
This being in combinators makes it harder to find. Change-Id: If7984bdbd43f164c670548639bb4846d859f6695 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12750 Reviewed-by: yuka <yuka@yuka.dev> Tested-by: BuildkiteCI
10 days r/8901 docs(tvix/[ca]store): improve docstrings, remove wildcard importsFlorian Klink4-14/+31
Extend the docstrings of `add_default_services`, and add one for `addrs_to_configs` as well as the module-wide one at `tvix_store::composition`. Change-Id: Ie9b449988eb210cd65b19b174094bbe0c4af2fd6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12748 Tested-by: BuildkiteCI Reviewed-by: yuka <yuka@yuka.dev>
10 days r/8900 refactor(tvix/[ca]store): rename store composition feature flagsFlorian Klink8-22/+20
tvix-castore already supports composition without any additional feature flags, the only thing that can be explicitly enabled is referring to other stores via an anonymous url. Rename that feature flag to "xp-composition-url-refs". tvix-store effectively only controls the CLI surface, so rename this to "xp-composition-cli". The "store" in the feature name was dropped, as it's already apparent from being in the tvix-[ca]store crate. Change-Id: I1175dc6280cbba4cbcdfb7fd4b35fce713b45fc4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12747 Tested-by: BuildkiteCI Reviewed-by: yuka <yuka@yuka.dev>
10 days r/8899 refactor(tvix/store/composition): rename 'default' to 'root'Florian Klink9-26/+26
This becomes the root of the composition. `default` implies we can directly access anything else, which we cannot. `root` makes this more understandable, and it's all internal only anyways. Change-Id: I297511bc05a7c32c59510b9d192b40d1bd937b5f Reviewed-on: https://cl.tvl.fyi/c/depot/+/12746 Reviewed-by: yuka <yuka@yuka.dev> Tested-by: BuildkiteCI
11 days r/8898 refactor(nix-compat): Move serialization machinery into wire.Vova Kryachko28-49/+45
This groups most `wire` feature gated logic into a single module. The nix_daemon module will be gated by a feature that adds nix-compat-derive as a dependency. All of this is a way to break the crate2nix dependency cycle between nix-compat and nix-compat-derive(which depends on nix-compat for its doctests). Change-Id: I95938a6f280c11967371ff21f8b5a19e6d3d3805 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12761 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
12 days r/8897 fix(users/flokli/2024-10-25-nixcon-tvix): fix dateFlorian Klink1-1/+1
Change-Id: Icd81415c208c26ae606673f3476bfdf0525eec89 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12759 Reviewed-by: flokli <flokli@flokli.de> Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
13 days r/8896 feat(tvix): add instance_name to instrumentation of *ServicesBob van der Linden23-137/+270
Currently it is not possible to distinguish between tracing of the same *Service type whenever there are multiple of them. Now the instance_name of ServiceBuilder is passed into the *Service and used in the existing instrument as the `instance_name` field. Places that did not already have a instance_name in its context use `"default"`. In tests I used `"test"`. Change-Id: Ia20bf2a7bb849a781e370d087ba7ddb3be79f654 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12739 Tested-by: BuildkiteCI Autosubmit: Bob van der Linden <bobvanderlinden@gmail.com> Reviewed-by: flokli <flokli@flokli.de>
2024-11-07 r/8895 feat(tvix/tracing): Allow configuring additional layersVova Kryachko1-49/+61
This will be used by tvix-daemon to write tracing data into the active client's connection socket. Change-Id: I8889dd0a638e004ee2c8cb312946b029c9779313 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12734 Tested-by: BuildkiteCI Autosubmit: Vladimir Kryachko <v.kryachko@gmail.com> Reviewed-by: flokli <flokli@flokli.de>
2024-11-06 r/8894 fix(users/flokli/kb/dilemma): fix one more RALTFlorian Klink1-1/+1
This makes it quite hard to press Alt+Number otherwise. Change-Id: Id1cc4fbfa1575cc213014106f734bec035d46f2c Reviewed-on: https://cl.tvl.fyi/c/depot/+/12737 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de>
2024-11-04 r/8893 feat(tvix/nix-compat): Add nix serialization supportBrian Olsen20-15/+2339
This change implements the serialization part that is needed to implement the nix daemon protocol. Previously was add deserialization and derivers for that and this then adds the other part of that equation so that you can write types that can then be read using deserialization. Change-Id: I2917de634980a93822a4f5a8ad38897b9ce16d89 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12729 Autosubmit: Brian Olsen <me@griff.name> Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-11-04 r/8892 fix(tvix/nix-compat-derive): Better errors for defaultBrian Olsen2-7/+13
This adds a span to default handling so that any error message gives a more precise location as a hint for why the error occurred instead of just pointing to the type. Change-Id: I7bf6cf38e0284f9726d670ea50a94a6b1edd8a94 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12728 Reviewed-by: Vladimir Kryachko <v.kryachko@gmail.com> Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Autosubmit: Brian Olsen <me@griff.name>
2024-11-04 r/8891 feat(tvix/eval): use with_capacity instead of a growing vecBob van der Linden1-1/+1
Change-Id: I4d89663eb9ac772ce1008ed5ee218bc7016164e7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12733 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-11-04 r/8890 refactor(tvix/eval): remove Value::Json and related functionalityBob van der Linden8-109/+27
Currently Value::Json is used in combination with VMRequest::ToJson to recursively convert tvix Value to serde_json::Value. This functionality is used in builtins.toJSON as well as derivation __structuredAttrs. Both Value::Json and VMRequest::ToJson were removed in this commit. Related functionality in vm.rs is also removed: vm.rs does not know about JSON anymore. Recursively converting to serde_json now happens without going through the VM. Thrown errors that are part of the value of toJSON are now directly propagated as ErrorKind, were-as previously there was a split between CatchableErrorKind and ErrorKind, where eventually CatchableErrorKind would be converted to ErrorKind::Catchable. Change-Id: I066f064926c491e4c087a984f07af43d19124cfe Reviewed-on: https://cl.tvl.fyi/c/depot/+/12732 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2024-11-04 r/8889 test(tvix/eval): test throw in __toString with toJSONBob van der Linden2-1/+4
Change-Id: Ia4a9a04c7e157b6add94dc8901ffab35486fe344 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12731 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>