about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
2022-01-27 r/3687 refactor(wpcarro/emacs): Remove TODOs from window-manager.elWilliam Carroll1-40/+2
Some of these are obsolete; I'm dropping others; fixed some. Change-Id: I0e5e39354176824b1028452355216b68206034ae Reviewed-on: https://cl.tvl.fyi/c/depot/+/5039 Tested-by: BuildkiteCI Autosubmit: wpcarro <wpcarro@gmail.com> Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-01-27 r/3686 fix(wpcarro/fish): Drop unused git aliasWilliam Carroll1-1/+0
This *should've been* `git pull --rebase` (not `push`). Then I realized that I don't really use this alias; it's sort of a pre-magit workflow. Change-Id: Ibe02d2c960f60e7d735981171780ef755a50a5b9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5041 Tested-by: BuildkiteCI Autosubmit: wpcarro <wpcarro@gmail.com> Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-01-27 r/3685 feat(wpcarro/website): Update footerWilliam Carroll1-0/+5
Add link to donate caffeine. Change-Id: I49aa95dd481778433fd303c6166a9d60c077a08a Reviewed-on: https://cl.tvl.fyi/c/depot/+/5042 Tested-by: BuildkiteCI Autosubmit: wpcarro <wpcarro@gmail.com> Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-01-27 r/3684 refactor(wpcarro/emacs): Move KBD to keybindings.elWilliam Carroll2-2/+2
This is part of a larger effort to remove the statements from `window-manager.el` to convert it to a pure library. Change-Id: I3078a9a73ec049704ac2dbbe822a6e57f4c9cf48 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5037 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-01-27 r/3683 feat(wpcarro/fish): Define gpr aliasWilliam Carroll1-4/+5
Another Urbint-era `git` alias. Change-Id: I5c833250bf87eec26fe66e2738756f541ec4328d Reviewed-on: https://cl.tvl.fyi/c/depot/+/4999 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-01-27 r/3682 refactor(wpcarro/emacs): Move ivy-pass to ui.elWilliam Carroll2-3/+2
Alongside other ivy use-package declarations. Change-Id: I5a60c06f287146ecd671ec9a5d8299539ea89dea Reviewed-on: https://cl.tvl.fyi/c/depot/+/5036 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-01-27 r/3681 refactor(wpcarro/emacs): Drop window-manager-logoutWilliam Carroll2-60/+8
TL;DR: - undefine `window-manager-logout` - define window-manager customization group - publicize `window-manager--xsecurelock` - rename `window-manager--xsecurelock` -> `window-manager-screenlocker` - remap `workspace "l"` to always lock the screen Change-Id: I77df883b94e786c4584351c9ebf1dcf0d5a84a33 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5035 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-01-27 r/3680 refactor(wpcarro/emacs): Reduce dependency on display.elWilliam Carroll1-14/+0
Trying to disentangle some of my Elisp modules... Change-Id: I61173fc05557dca63e382c2e00d6f48c95701194 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5034 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-01-27 r/3679 feat(wpcarro/configs): Define {import,export}-gpg in NixWilliam Carroll4-3/+72
Note: Calling `export-gpg` (relying on the symlink to `__dispatch.sh`) hangs because it's prompting the user for the password to decrypt the secrets, but for some reason no prompt displays. When I call... ```shell $ nix-build /depot -A users.wpcarro.configs.export-gpg $ ./result ``` ...it WAIs. I need to debug this, but I'm committing the work for now because it's making my `magit-status` noisy. TODO(wpcarro): Merge and reconcile configs, dotfiles. Change-Id: I2b91323824cab37daa9d880cbb42f38e33ca10e1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4998 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-01-27 r/3678 feat(wpcarro/fish): Define glp aliasWilliam Carroll1-0/+1
Good ole `glp` (from the Urbint days). Change-Id: I04b8e6f40b2922c49a625d32c1214038a8c08293 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4997 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-01-26 r/3677 chore(3p/lisp/mime4cl): remove CMUCL specific codesterni7-18/+11
Having #+cmu all over the place suggests that we maintain CMUCL support or test with CMUCL which is not the case. Change-Id: Ia0828cb1ac48e49acdee6fef7a0fa2c04c1805b3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5068 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-26 r/3676 refactor(3p/lisp/mime4cl): use trivial-gray-streamssterni4-51/+16
This should be a net positive for portability and lets us drop some of the CMUCL cruft (which we don't test anyway, CMU support may have regressed regardless). Change-Id: I85664d82d211177da1db9eebea65c956295b09f7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5067 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-26 r/3675 style(3p/lisp): expand tabs in npg, mime4cl and sclfsterni25-2467/+2467
Done using find third_party/lisp/{sclf,mime4cl,npg} \ -name '*.lisp' -or -name '*.asd' \ -exec bash -c 'expand -i -t 8 "$0" | sponge "$0"' {} \; Change-Id: If84afac9c1d5cbc74e137a5aa0ae61472f0f1e90 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5066 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-26 r/3674 feat(3p/lisp/cl-date-time-parser): init at 00d6fc7sterni1-0/+21
Change-Id: I6a04c5bb611f011e66c1a8d7089e0b2bff3d2fdf Reviewed-on: https://cl.tvl.fyi/c/depot/+/5002 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: tazjin <tazjin@tvl.su>
2022-01-26 r/3673 feat(users/sterni/emacs): open inbox.org on startupsterni1-0/+1
Change-Id: Ic73455e25b0d98501dfccbf414fff322e7f44b14 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5061 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-25 r/3672 fix(wpcarro/nix): Temporarily disable simple_vimWilliam Carroll1-1/+2
neovim is failing to build for some reason (nixpkgs bump maybe?) Change-Id: I49e7cebe490d339565b759d24d25843fb3e3bbae Reviewed-on: https://cl.tvl.fyi/c/depot/+/5059 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-01-25 r/3671 feat(wpcarro/fish): Define rebuild-system aliasWilliam Carroll1-0/+2
This allows me to call rebuild-system from outside of /depot. Change-Id: I6bb627df173b1889522e03d5a6ff37e8119aaaa2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5058 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-01-25 r/3670 feat(fish): Define alias to cd /depot/users/wpcarroWilliam Carroll1-0/+1
Simplifying my life... Change-Id: I84aabb337727fa56d79c72e81acf7b11c7308839 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5057 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-01-25 r/3669 fix(wpcarro/simple_vim): Quote $@ argsWilliam Carroll1-1/+1
self-evident Change-Id: I762c4aa3486a167b3de10f91639fa662ba50f109 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5056 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2022-01-24 r/3668 feat(nix/buildkite): Support un-gated post-build extra stepsVincent Ambo1-2/+7
Allows users to define steps with `postBuild = true` which always run after :duck:, but do not require human approvals. This can be useful for things like unconditional release steps. Change-Id: Idbf6c48a9dedcfc6cc9b7f098423364e2fa72d2d Reviewed-on: https://cl.tvl.fyi/c/depot/+/5052 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: tazjin <tazjin@tvl.su>
2022-01-24 r/3667 refactor(nix/buildkite): Restrict step conditionals to refs onlyVincent Ambo1-11/+9
The previous `condition` abstraction which allowed the full set of Buildkite conditionals is way too leaky (it lets users to very Buildkite-specific things which we may not want to allow, and which are mostly not relevant to a pure evaluation). Supporting only the `branches` condition (native to Buildkite) should make it possible to port this to other future CI systems later. Change-Id: Ib8adcc41db4f1a3566cbeecf13a4228403105c1f Reviewed-on: https://cl.tvl.fyi/c/depot/+/5051 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com> Autosubmit: tazjin <tazjin@tvl.su>
2022-01-24 r/3666 feat(nix/buildkite): Add support for gated stepsVincent Ambo1-7/+69
Adds support for extra build steps that specify a `prompt`. These steps will be run at the end of the pipeline and will be gated by human approval. This mechanism can be used to, for example, stage releases of software released from depot that are subject to approval. Change-Id: I97bb505664a2ccf01142286f14e20a370afaa345 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5033 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com> Autosubmit: tazjin <tazjin@tvl.su>
2022-01-23 r/3665 refactor(wpcarro/emacs): Expose env as kwarg in withEmacsPathWilliam Carroll1-4/+9
This allows me to remove google-briefcase references. Change-Id: I61234b2ac20e0de0f3d0d820a471342124d72f2d Reviewed-on: https://cl.tvl.fyi/c/depot/+/4996 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-01-23 r/3664 feat(wpcarro/fish): Define fish configuration as dotfileWilliam Carroll1-0/+30
TODO(wpcarro): Figure out how this is sourced on NixOS machines. Change-Id: Iafddab003699f57bbfd09cd29cb9382dadf6a147 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4995 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-01-23 r/3663 fix(wpcarro/docs): Fix references to google-briefcaseWilliam Carroll1-2/+2
It now resides at `/google-briefcase` 🙂 Change-Id: I64640c7c969f08a687cbc6fde9b69b61a9e0016b Reviewed-on: https://cl.tvl.fyi/c/depot/+/4994 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-01-22 r/3662 feat(views/kit): Check Buildkite pipeline into repositoryVincent Ambo2-0/+10
Change-Id: Id005703531ed3626c911b839d8f692f65a28e1e6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5053 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-22 r/3661 fix: Display build status badge from correct branchVincent Ambo1-1/+1
This was still showing the build status for a manually created ref on Buildkite which had not seen any updates since mid-2020. Change-Id: I42786ce2c0ac598f3d6b8ef9379b18294814a5ec Reviewed-on: https://cl.tvl.fyi/c/depot/+/5054 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: tazjin <tazjin@tvl.su>
2022-01-22 r/3660 fix(grfn/home): Use glimpse from nixpkgsVincent Ambo1-2/+1
This extra nixpkgs import has been around for a while, but seems to no longer be needed (this software is in nixpkgs). Change-Id: I9932fe01bda97bd8b50ec9192ab185bea69657f9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5050 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi>
2022-01-22 r/3659 refactor(ops/pipelines): Move :anchor: into postBuildStepsVincent Ambo2-18/+18
There is no need for this step to be part of the static pipeline (it should not run if the build fails anyways). Change-Id: I71400a452d6f8f4708d146b346eaffda5da2f766 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5049 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com>
2022-01-22 r/3658 feat(ops/pipelines): Upload post-build steps in static pipelineVincent Ambo1-0/+15
Change-Id: I5ce6d51837c734951fe10c4f21806cf0fc57ed23 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5048 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com>
2022-01-22 r/3657 refactor(ops/pipelines): Split build/post steps into separate chunksVincent Ambo2-17/+10
This will create `build-chunk-$n.json` files for steps that should run _before_ duck, and `post-chunk-$n.json` files for steps that should run after duck. The post steps are not yet uploaded to Buildkite, but we also don't have any right now. Change-Id: I7e1b59cf55a8bf1d97266f6e988aa496959077bf Reviewed-on: https://cl.tvl.fyi/c/depot/+/5047 Tested-by: BuildkiteCI Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com> Autosubmit: tazjin <tazjin@tvl.su>
2022-01-22 r/3656 refactor(ops/pipelines): Use branches filter for canon-only stepsVincent Ambo1-2/+2
Using this instead of a conditional leads to nicer output in the UI, but has no semantic difference. Change-Id: I5b368d663f417d256e4792d2d46b84fc50d42d0e Reviewed-on: https://cl.tvl.fyi/c/depot/+/5045 Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com> Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su>
2022-01-22 r/3655 refactor(ops/pipelines): Move :git: step up in the pipelineVincent Ambo1-14/+15
This step is independent of the build result and can be scheduled at the beginning while pipeline eval is still in progress. Change-Id: I2ee268e4c333efa654dcb12c0b1562b43231d241 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5044 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com>
2022-01-22 r/3654 feat(ops/pipelines): Always upload entire pipeline outputVincent Ambo1-1/+1
Previously we only stored the drvmap, but we will also need the build chunks to refactor the generation of dynamic post-steps. Change-Id: I256fffe13af8f8c4521835257f5d87dda323b248 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5043 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com>
2022-01-21 r/3653 refactor(depotfmt): Move formatting check into an extra stepVincent Ambo2-9/+6
Change-Id: I7e4cf6bb2351bd11a5396f1663c0d4cc97c0d94e Reviewed-on: https://cl.tvl.fyi/c/depot/+/5009 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: grfn <grfn@gws.fyi> Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com>
2022-01-21 r/3652 feat(nix/buildkite): Add support for extra stepsVincent Ambo1-17/+85
This introduces a new feature to our CI system in which targets can declare extra steps in `meta.ci.extraSteps`. See the comment in //nix/buildkite/default.nix for an explanation of how these extra steps are defined. Change-Id: Icce2890c743286dd37f43024cd390dcebac8cdba Reviewed-on: https://cl.tvl.fyi/c/depot/+/5008 Tested-by: BuildkiteCI Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com>
2022-01-20 r/3651 chore(nix/buildkite): Drop `--fork-point` parameterVincent Ambo1-1/+1
The --fork-point parameter is dependent on reflog data which may get garbage collected. This can lead to flaky behaviour where it returns no results and fails if `git gc` recently ran (Buildkite will do this occasionally). Though the parameter is semantically closer to what we're looking for, the output is *usually* the same commit since we're not dealing with more than one thing to compare. Change-Id: Idc31e7a26fda2b7113edfa162d9d3811b1a01bf6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5032 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-20 r/3650 feat(ops/pipelines): Trigger pipeline for tvl-kit through canonVincent Ambo1-0/+10
This CI pipeline in Buildkite verifies the external (josh-provided) view of the depot at //views/kit. See https://buildkite.com/tvl/tvl-kit Note that this always triggers a build of HEAD. This is because we don't know the transformed commit ID, and we currently have no way to pass a ref through. The pipeline is configured to skip intermediate builds. I asked Buildkite for some ideas on how to improve this, lets see. Change-Id: I6c60fb1ea7606c1c90219ef04fd7bada64661529 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5010 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-20 r/3649 refactor(grfn/home): Tweak screenlayout for new desk layoutGriffin Smith1-2/+2
Change-Id: Idca10ee66ed3b083fa914140fef421198462f794 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5029 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2022-01-20 r/3648 feat(grfn/system): Always add teensy udev rulesGriffin Smith1-0/+8
Basically any system I have is going to want to be able to flash an ergodox, so it makes sense to have these always present Change-Id: I88f556d4484e282e712062a488321bf80baa87ac Reviewed-on: https://cl.tvl.fyi/c/depot/+/5028 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2022-01-20 r/3647 refactor(grfn/mugwump): Move buildkite secrets into ageGriffin Smith4-2/+30
Use agenix for the buildkite ssh key and agent token on mugwump, instead of storing stuff in /etc/secrets Change-Id: I56951587b949fc0854e56f5c4e33b601e9cd964e Reviewed-on: https://cl.tvl.fyi/c/depot/+/5027 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2022-01-20 r/3646 feat(grfn/keyboard): Add a scroll lock keyGriffin Smith1-1/+1
somehow I managed to turn this *on*, but had no way of turning it off as I didn't have a key. Change-Id: Icd3d3c23595d73da634fc269fc1881f82650c1e5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5026 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2022-01-20 r/3645 fix(grfn/mugwump): Update for new ddclient config formatGriffin Smith3-16/+12
There's a passwordFile option now! Change-Id: I7aa21891c3502ceddcb0bb08a83a5a3a8a6bcdc9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5025 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2022-01-20 r/3644 fix(grfn/emacs): disable ligaturesGriffin Smith2-41/+41
these render very strangely, Change-Id: I51f34007e49cdb9a4dc2d440459561b733183d86 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5024 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2022-01-20 r/3643 feat(grfn/bbbg): Add delete event buttonGriffin Smith3-13/+50
Change-Id: I763e7a6b367ea5b474ab3aa13c7ff21e99db34af Reviewed-on: https://cl.tvl.fyi/c/depot/+/5023 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2022-01-20 r/3642 fix(grfn/bbbg): Allow non-numeric meetup user IDsGriffin Smith1-3/+1
Apparently meetup will just make the user ID the username sometimes... idk what's up with this. Change-Id: I19eaade2fd3394e6ff81c30692bf4a2899985025 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5022 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2022-01-20 r/3641 fix(grfn/bbbg): Fix RSVP label in UIGriffin Smith1-1/+1
Change-Id: I7d4a1d0b9878fa732915c790217af2f2d15d00fa Reviewed-on: https://cl.tvl.fyi/c/depot/+/5021 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2022-01-20 r/3640 fix(nix/buildkite): prevent swallowing errors from git-merge-baseVincent Ambo1-5/+7
The `local` usage we had before would silently swallow non-zero exit statuses from the substituted git commands. For some (as of yet unknown) reason, `git merge-base` seems to sometimes silently fail and produce no output, which broke the rest of the script logic. This change will lead to an earlier error, but we don't know if it is a fix for the actual cause of the git-merge-base problem because the shape of that problem is unclear. Change-Id: I4555c8638da450263fa2fd2c274dfdb69f65578e Reviewed-on: https://cl.tvl.fyi/c/depot/+/5012 Tested-by: BuildkiteCI Reviewed-by: kn <klemens@posteo.de>
2022-01-20 r/3639 fix: Fix build inclusion logicVincent Ambo1-1/+1
The `or` statement is a *single* expression, leading to an incorrect negation. Change-Id: I46fa85c22cf145b9204bf26b85b963494b069d06 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5013 Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2022-01-20 r/3638 refactor: Replace 'meta.ci' -> 'meta.ci.skip'Vincent Ambo4-5/+5
We need 'meta.ci' to be an attribute set for new CI features. Change-Id: I83d04e2d74e42e49fe739b049ee4ba799f6d5d86 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5007 Tested-by: BuildkiteCI Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com> Reviewed-by: wpcarro <wpcarro@gmail.com>