about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
2022-01-20 r/3640 fix(nix/buildkite): prevent swallowing errors from git-merge-baseVincent Ambo1-5/+7
The `local` usage we had before would silently swallow non-zero exit statuses from the substituted git commands. For some (as of yet unknown) reason, `git merge-base` seems to sometimes silently fail and produce no output, which broke the rest of the script logic. This change will lead to an earlier error, but we don't know if it is a fix for the actual cause of the git-merge-base problem because the shape of that problem is unclear. Change-Id: I4555c8638da450263fa2fd2c274dfdb69f65578e Reviewed-on: https://cl.tvl.fyi/c/depot/+/5012 Tested-by: BuildkiteCI Reviewed-by: kn <klemens@posteo.de>
2022-01-20 r/3639 fix: Fix build inclusion logicVincent Ambo1-1/+1
The `or` statement is a *single* expression, leading to an incorrect negation. Change-Id: I46fa85c22cf145b9204bf26b85b963494b069d06 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5013 Reviewed-by: tazjin <tazjin@tvl.su> Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2022-01-20 r/3638 refactor: Replace 'meta.ci' -> 'meta.ci.skip'Vincent Ambo4-5/+5
We need 'meta.ci' to be an attribute set for new CI features. Change-Id: I83d04e2d74e42e49fe739b049ee4ba799f6d5d86 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5007 Tested-by: BuildkiteCI Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com> Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-01-19 r/3637 refactor(nix/buildkite): Move fetch-parent-targets script hereVincent Ambo2-1/+1
This is no longer TVL-specific and should live here with the other generalised stuff. Change-Id: I95a1b4c0321f34812162d6fd40568269abf639dd Reviewed-on: https://cl.tvl.fyi/c/depot/+/5006 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com>
2022-01-19 r/3636 refactor(ops/pipelines): Generalise fetch-parent-targets scriptVincent Ambo2-14/+15
Removes all TVL-specific values in favour of environment variables supplied by Buildkite. This makes it possible to reuse this script outside of TVL. Change-Id: Ic543bc41e4c81e65ee349ad241c515231e97ab30 Reviewed-on: https://cl.tvl.fyi/c/depot/+/5005 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: ezemtsov <eugene.zemtsov@gmail.com>
2022-01-19 r/3635 feat(3p/lisp): add metabang-bindsterni1-0/+16
Change-Id: I6efcb07b7763c4d108baff717d07097cb324ba4f Reviewed-on: https://cl.tvl.fyi/c/depot/+/5003 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-19 r/3634 fix(nix/buildLisp): use filtered deps for native deps in testSuitesterni1-1/+1
allDeps filters the lisp deps according to the given implementation, processing any implementation conditional attribute sets. These are not understood by allNative, so we need to pass it the already filtered input or evaluation would fail. Change-Id: I9eb2d0c3b2bf70d759d03490cf31fc585283ce7f Reviewed-on: https://cl.tvl.fyi/c/depot/+/5001 Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2022-01-19 r/3633 feat(ops/besadii): make text 'cl' posted BuildKite configurableÅsmund Østvold1-4/+20
Some companies do not know the 'cl' term. They do know of 'change' and would maybe not like to introduce one more synonym. This cl introduce an optional entry 'gerritChangeName' in besadii.json. The string has to match `^[a-z0-9]+$` for readability. Change-Id: Id70fcb1e45158869f88bf37669be49b8b8a3b295 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4825 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: asmundo <asmundo@gmail.com>
2022-01-19 r/3632 feat(kit): Export TVL kit as a josh workspaceVincent Ambo5-0/+57
This creates a josh workspace called `views/kit` which exports all dependencies needed by external users of the TVL kit. The intention of this is to have a single clonable "virtual repo" which provides everything needed to run a system like TVL, but without the projects that we develop *in* TVL. Right now this is limited to the basic Nix code (readTree, pipeline generation) and things required for Gerrit integration. The workspace maps depot paths into slightly different (simpler) locations inside the exported view, to avoid a nested, mostly empty structure. Note: This is not an "external API" or some such of depot, it is simply a convenience for exporting some of our tooling. Change-Id: Ied24aaef117fc2e0c188ec742ae7cd993a5babd3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4991 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-19 r/3631 chore(3p/nixpkgs): Make externally importableVincent Ambo1-2/+4
This change is required for using our package set in exported josh workspaces. It has no functional impact on depot itself. Change-Id: Id48b40f067b5d53a2b7386a0ba1146a72268b923 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4990 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-19 r/3630 chore(tazjin/emacs): Remove stale note about ImagemagickVincent Ambo1-7/+0
cl/5000 GET! Note: This CL was pushed back via josh. Change-Id: I83eee8a19d6163f0c181aa0bfeafab3823c2fe9f Reviewed-on: https://cl.tvl.fyi/c/depot/+/5000 Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2022-01-18 r/3629 refactor(wpcarro/gnupg): Improve UX for gnupg/{import,export}.shWilliam Carroll2-15/+35
TL;DR: - Ensure that export.sh -> import.sh -> export.sh can round-trip without intermediate tools. - Remove default values for variables like ${1}, which only seem to complicate things. - Add `trap cleanup EXIT` to scripts. - Remove noisy full-paths from `zip` (note: a more intuitive, less configurable `zip`, `unzip` should exist). Change-Id: Ibbd98d1f0156639138175fcb89e9dfbd17fdae5f Reviewed-on: https://cl.tvl.fyi/c/depot/+/4993 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-01-18 r/3628 fix(wpcarro/emacs): Ensure pasting in evil visual WAIWilliam Carroll1-1/+1
The variable, `evil-visual-update-x-selection`, must've updated to `evil-visual-update-x-selection-p`. When I moved from ~/briefcase to /depot I adopted the newer version of nixpkgs. Change-Id: I27de45c73833325f64b1e176b8793a0d05233331 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4992 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-01-18 r/3627 chore(wpcarro/*): Remove some dead codeVincent Ambo2-18/+7
Found this while looking for non-3p uses of builtins.fetchGit. The hailgun package is in the package set now, and the other thing was unused (and it's also in the package set). Change-Id: I6f519fd6014bbed90fc6cee695bed7afbcf55717 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4984 Tested-by: BuildkiteCI Autosubmit: tazjin <tazjin@tvl.su> Reviewed-by: wpcarro <wpcarro@gmail.com>
2022-01-18 r/3626 feat(3p/josh): Bump to latest masterVincent Ambo2-53/+2
Change-Id: I32104d1cdc6d9cd72543d66bbe2f146e8ac27f6d Reviewed-on: https://cl.tvl.fyi/c/depot/+/4988 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-18 r/3625 chore(tazjin/tverskoy): Reduce systemd stop timeout to 10sVincent Ambo1-0/+6
Change-Id: Id477c50489fa45fae63120c201839a95aa21bd36 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4987 Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2022-01-18 r/3624 feat(tazjin/tverskoy): persist keyring data across rebootsVincent Ambo1-0/+1
Change-Id: I9602ae6c8fcd56fb9bbccc7ceacb08d23cd99a4f Reviewed-on: https://cl.tvl.fyi/c/depot/+/4986 Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2022-01-17 r/3623 chore(3p): bump NixOS channels to 2022-01-15sterni1-6/+6
Change-Id: I1dede07f7b0bac6585c3ecfc788f7fcc10980d52 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4985 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2022-01-17 r/3622 refactor(tools/emacs-pkgs): move sly-from-depot to tvl.elsterni2-35/+36
The function is depot specific and thus uses tvl-depot-path, so it belongs in `tvl.el`. Since non-sly-users won't need it, we tie its definition to loading the sly package. Change-Id: I8b104deab455d218d3df6a800e35cc104220a841 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4960 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2022-01-17 r/3621 refactor(tools/emacs-pkgs/nix-util): drop unused var nix-depot-pathsterni1-2/+0
Change-Id: Iffff21277a35e8da8125425412a4a3a3f5ffd1ce Reviewed-on: https://cl.tvl.fyi/c/depot/+/4942 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2022-01-17 r/3620 chore(tazjin/*): Remove some dead codeVincent Ambo7-180/+0
Change-Id: Ic938bc9ae446620f132d912e4787f4b42ffd9341 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4983 Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
2022-01-17 r/3619 fix(3p): Move away from builtins.fetchGitVincent Ambo17-36/+71
Moves to the derivation-based git fetchers everywhere in third-party. This might help with forward-compatibility with newer Nix versions, though that's not our primary concern right now. Change-Id: I565bb72585b8639893e9ea3a9e233338aede63a9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3903 Tested-by: BuildkiteCI Reviewed-by: zseri <zseri.devel@ytrizja.de>
2022-01-17 r/3618 feat(tazjin/tverskoy): Install fractal system-wideVincent Ambo1-1/+1
Change-Id: Ie29c7e9fe8187dd632742d6c923805743db03339 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4945 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su>
2022-01-17 r/3617 feat(tazjin/tverskoy): Enable & persist gnome-keyringVincent Ambo1-2/+5
Required by Fractal. Change-Id: Ic82b0d83f6d7c30639c2e149dad79ba4c1a30e88 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4943 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: tazjin <tazjin@tvl.su>
2022-01-17 r/3616 fix(ops/oauth2_proxy): Fix cookie secret lengthVincent Ambo2-1/+1
The cookie secret in the encrypted file was too long, because the generation command in the oauth2_proxy docs is also wrong. Should probably fix that upstream as well. Also noticed that an extra '2' snuck into the service name and fixed that. Change-Id: I9a344a75993ab1f98299a8d45e7f5b2e146b7fc5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4957 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-17 r/3615 refactor(users/sterni/emacs): use more persistent tmp dirsterni1-1/+4
Change-Id: I703b7678405f29bc4f0f04e1b42fd35025a80971 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4982 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-17 r/3614 feat(users/sterni/emacs): save command and search historysterni1-0/+4
Change-Id: Ied633801d4dd2b41f46ec702a345732f553142d9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4959 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-17 r/3613 feat(users/sterni/emacs): save undo historysterni1-1/+4
Change-Id: I75ca7b2011f14244cac8af7762b6d2f6ce284055 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4958 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-17 r/3612 feat(users/sterni/emacs): set sentence boundssterni1-0/+1
Change-Id: Ic6d01e8d9b28a884eceeda4d9888e611f0d5abb8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4956 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-17 r/3611 feat(users/sterni/emacs): enable buffer size indicatorssterni1-0/+2
Change-Id: Ibd3ad27017c69eff65ee37678b6bbad264dcdadc Reviewed-on: https://cl.tvl.fyi/c/depot/+/4955 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-17 r/3610 feat(users/sterni/emacs): add bind for listing bufferssterni1-0/+1
Change-Id: I2ccc9e3277eb871cf5064fe242934e46a6a49583 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4954 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-17 r/3609 feat(users/sterni/emacs): enable fido-modesterni1-0/+6
Change-Id: Iaa8b3fe3d9485a2bff0a0227e7fa5af64f4b320b Reviewed-on: https://cl.tvl.fyi/c/depot/+/4953 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-17 r/3608 refactor(users/sterni/emacs): set-default → setq-defaultsterni1-1/+1
Change-Id: I0f9339bfabeace66cab0ea7402b181113048a568 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4952 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-17 r/3607 feat(users/sterni/emacs): enable pareditsterni2-2/+15
Change-Id: I318ccf75fa470f442c05df6ae6f8df8772a7c1d6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4951 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-17 r/3606 fix(users/sterni/emacs): reverse search in insert mode for slysterni1-1/+1
Change-Id: Id324c98912ba5ce08f06d8db260cd7ee129dd27d Reviewed-on: https://cl.tvl.fyi/c/depot/+/4950 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-17 r/3605 fix(users/sterni/emacs): make save files even less annoyingsterni1-0/+2
Change-Id: I765fee99d2c37ee64d7858f69ed52ce126451640 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4949 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-17 r/3604 fix(users/sterni/emacs): set tvl-depot-path correctlysterni1-1/+3
Change-Id: I5f9928816c86495addab31ca33e51141b415d42a Reviewed-on: https://cl.tvl.fyi/c/depot/+/4948 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: sterni <sternenseemann@systemli.org>
2022-01-17 r/3603 feat(ops/pipelines): Fetch parent target map for pipeline generationVincent Ambo2-1/+51
Change-Id: I1c7d48fc0974549d67146a15f79ddb0b6ddfe805 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4947 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-17 r/3602 feat(nix/buildkite): Check target map of parent to determine skipsVincent Ambo3-25/+31
This changes the logic for build pipeline generation to inspect an (optional) parentTargetMap attribute which contains the derivation map of a target commit. Targets that existed in a parent commit with the same drv hash will be skipped, as they are not considered to have changed. This does not yet wire up any logic for retrieving the target map from storage, meaning that at this commit all targets are always built. The intention is that we will have logic to fetch the target map (initially from Buildkite artefact storage), which we then pass to the depot via externalArgs when actually generating the pipeline. Change-Id: I3373c60aaf4b56b94c6ab64e2e5eef68dea9287c Reviewed-on: https://cl.tvl.fyi/c/depot/+/4946 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-17 r/3601 feat(ops/pipelines): Create drvmap structure for each commitVincent Ambo3-10/+40
Always create a structure that maps all targets to derivations, and persist it as a JSON file. This relates to some of the ideas expressed in: https://docs.google.com/document/d/16A0a5oUxH1VoiSM8hyFyLW0WiUYpNo2e2D6FTW4BlH8/edit The file is always uploaded to Buildkite as an artifact. This allows for retrieving it based on the commit ID in a Buildkite GraphQL query. By default, Buildkite stores artefacts for 6 months. Storage location can be overridden (with custom retention) through some environment variables, but for now at TVL the Buildkite-managed storage is fine. See also: https://buildkite.com/docs/pipelines/artifacts In the subsequent filtering implementation, when diffing commits across a time-range that exceeds artefact retention time, we should simply default to building everything. Change-Id: I6d808461cd1c1fdd6983ba8c8ef075736d42caa7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3662 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-16 r/3600 fix(users/Profpatsch/blog): fix path check assocProfpatsch1-2/+2
It would left-associate in some nix version, this way it’s clear that you want to join a path segment. Change-Id: I82a00de720187d1faf908c842e396301ea435a97 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4886 Reviewed-by: Profpatsch <mail@profpatsch.de> Reviewed-by: sterni <sternenseemann@systemli.org> Autosubmit: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
2022-01-15 r/3599 fix(tools/emacs-pkgs/nix-util): require missing dependenciessterni2-1/+5
We can't use cl-lib as that apparently doesn't contain lexical-let*. Change-Id: I8e65d20215ae5667bb92b71e6318ad9d66125320 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4941 Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
2022-01-14 r/3598 fix(gerrit-tvl): Handle "broken" (skipped) jobs correctlyVincent Ambo1-1/+7
by simply skipping them Change-Id: I9cbec3b79469ae01b1873d6a42e990b98cc4110a Reviewed-on: https://cl.tvl.fyi/c/depot/+/4921 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi>
2022-01-14 r/3597 fix(gerrit-tvl): Exclude non-command jobs from check resultsVincent Ambo1-0/+5
Change-Id: I13727d30ac7a568f02614a4bbc778afed6a286ba Reviewed-on: https://cl.tvl.fyi/c/depot/+/4891 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi> Autosubmit: tazjin <tazjin@tvl.su>
2022-01-14 r/3596 fix(gerrit-tvl): Explicitly specify patchset on check runsVincent Ambo1-0/+1
Since we now group patchsets inside of Buildkite, the results are no longer guaranteed to be for the right patchset. There might be some metadata passed in from Gerrit that would let us do this with the commit ID instead, but I haven't checked. Change-Id: I5b74a17697511160fcc89d3dbef23517d974dc6f Reviewed-on: https://cl.tvl.fyi/c/depot/+/4890 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi> Autosubmit: tazjin <tazjin@tvl.su>
2022-01-14 r/3595 fix(gerrit-tvl): Mark job as failed on all failure statesVincent Ambo1-1/+1
Change-Id: If0fa85d8178b9e457305d0244ddf67d12a4b3051 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4889 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi> Autosubmit: tazjin <tazjin@tvl.su>
2022-01-14 r/3594 fix(gerrit-tvl): Support all documented Buildkite job statusesVincent Ambo1-12/+58
I'm not sure where the previous list originated, but it was missing some officially documented statuses. However, the API definitely returns statuses that are documented to only appear in other types, so this commit simply maps ALL statuses that Buildkite has documented for any type. Also adds a log statement in case we encounter a brand new, unknown, undocumented status. Change-Id: Iff003a3bd2608702019ae0f4137958435ad0856f Reviewed-on: https://cl.tvl.fyi/c/depot/+/4888 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi>
2022-01-14 r/3593 fix(gerrit-tvl): Fix construction of ref used in BuildkiteVincent Ambo1-3/+2
... and remove a spammy log statement. This changed in besadii a while ago and lead to the behaviour of failing silently, instead of failing with an error saying "undefined undefined". Note that with this change merged the plugin probably still won't work again, but it gets us a step closer to the real error. Change-Id: I3db25d246f4b1c634d316cd92574e27fb220d769 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4887 Autosubmit: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi>
2022-01-14 r/3592 feat(besadii): Skip builds of patchsets with no code changesVincent Ambo1-2/+8
Currently Gerrit is configured to copy forward the scores of the 'Verified' label if the tree of the commit does not change (e.g. only author information or commit message is modified). Besadii still triggers builds for these patchsets though. With this change it will inspect the (previously ignored) "kind" of the patchset and skip patchsets with the same tree as their predecessor. See Gerrit docs for the semantics of "kind": https://gerrit-review.googlesource.com/Documentation/json.html#patchSet Note that an argument can be made that we should do the exact opposite - stop carrying over 'Verified' at all and always build all patchsets. I think this depends on whether we intend to use commit metadata in CI runs at all. Adding a few people to the review for opinions. Change-Id: I48a96a1ad1e07d92330d84e5cfdc820a39395297 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4867 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> Reviewed-by: asmundo <asmundo@gmail.com> Reviewed-by: sterni <sternenseemann@systemli.org>
2022-01-13 r/3591 fix(web/panettone): make (who:html-mode) sticksterni2-3/+4
(who:html-mode) needs to be set at macro expansion time to properly take effect which wasn't the case before, but is ensured now by :compile-toplevel. :load-toplevel ensures that who inside the repl will behave the same. Since the :html5 behavior is now actually used, we need to adjust some of the test cases to account for the different :html5 escaping mode. Change-Id: I4dfe1d2db38da6a2486fde86596f7e5f50ed8b9f Reviewed-on: https://cl.tvl.fyi/c/depot/+/4885 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi>
generated by cgit-pink 1.4.1 (git 2.44.2) at 2024-11-21T13·29+0000