about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
2021-04-12 r/2493 feat(whitby): Enable Prometheus instance on whitbyVincent Ambo1-1/+24
Enables Prometheus with a local node exporter, and nothing else for now. Some additional collectors have been enabled for things that might be relevant on whitby: * systemd: all our services run in systemd * processes: might be interesting for build-related stats * logind: might be interesting for interactive usage stats Change-Id: I48dacdd9c68b4be9edff7b3cb6256dad562498c4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2930 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> Reviewed-by: lukegb <lukegb@tvl.fyi>
2021-04-12 r/2492 feat(ops/pipelines): pass --show-trace to nix-buildsterni1-1/+1
--show-trace should make it easier to debug tricky evaluation errors without running nix-build -A ops.pipelines.depot locally again. Change-Id: Ice540562c3b389fc2a49ec1fc0adacb17db2a528 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2947 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-12 r/2491 refactor(gws.fyi): Remove cloudfront invalidation stepGriffin Smith1-3/+0
I'm not using cloudfront for gws.fyi anymore, so this invalidation step on deploy is pointless Change-Id: I153848666dc70acfc456b5dcf276bab2410c4716 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2946 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-12 r/2490 feat(gs/home): Install amberGriffin Smith1-0/+1
Change-Id: I26a397dd0d9f288fe43db8178e2f22089771ebc0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2945 Reviewed-by: grfn <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2021-04-12 r/2489 chore(grfn): Fix remaining references to glittersharkVincent Ambo2-4/+4
Change-Id: I60a60635dfef5c73f758fa6808992aeea3137301 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2944 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-12 r/2488 fix(grfn/home): Correct delta config for syntax-themeGriffin Smith1-1/+1
this got renamed apparently Change-Id: Ic616469eafc4b56eaaccc3df24988b0af73d90e2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2943 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-12 r/2487 feat(grfn/home): Script to rebuild home-managerGriffin Smith1-0/+6
Looks kinda like rebuild-mugwump, only for home yes, yes, this could gc halfway through, that's so unlikely that I don't care Change-Id: Iab3fdac15796e9f8158a9778b897bc3fe88e536e Reviewed-on: https://cl.tvl.fyi/c/depot/+/2942 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-12 r/2486 feat(grfn/home): Install cargo-flamegraphGriffin Smith1-0/+1
Change-Id: I5102abfe8c0d486e22d8dc1c744bf542753cc870 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2941 Reviewed-by: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-04-12 r/2485 refactor(users/glittershark): Rename to grfnGriffin Smith362-56/+52
Rename my //users directory and all places that refer to glittershark to grfn, including nix references and documentation. This may require some extra attention inside of gerrit's database after it lands to allow me to actually push things. Change-Id: I4728b7ec2c60024392c1c1fa6e0d4a59b3e266fa Reviewed-on: https://cl.tvl.fyi/c/depot/+/2933 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: glittershark <grfn@gws.fyi>
2021-04-12 r/2484 feat(3p): upgrade sbcl to 2.1.2sterni4-10/+10
sbcl 2.0.9 introduced a new warning: > minor incompatible change: the compiler signals a warning at > compile-time when an initform of T, NIL or 0 does not match > a STANDARD-CLASS slot's declared type. This broke a few packages, but they all have been fixed upstream in the meantime and we only need to bump their versions. The culprits are: * defclass-std which possibly has become unmaintained since the fix (december 2020). * cl-prevalence which also needs one symbol from bt now * lisp-binary which also includes a new file now Change-Id: I06bb47a129d5ef912a623315c1281aedd1ceac2a Reviewed-on: https://cl.tvl.fyi/c/depot/+/2934 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: glittershark <grfn@gws.fyi>
2021-04-12 r/2483 docs(readTree): Add SPDX license header on readTreeVincent Ambo2-0/+7
Change-Id: I9a6eafa7d4bb3d590dfa35d368adfd25aeed7f64 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2936 Reviewed-by: Profpatsch <mail@profpatsch.de> Tested-by: BuildkiteCI
2021-04-11 r/2482 refactor(ops): Split //ops/nixos into different locationsVincent Ambo38-60/+41
Splits //ops/nixos into: * //ops/nixos.nix - utility functions for building systems * //ops/machines - shared machine definitions (read by readTree) * //ops/modules - shared NixOS modules (skipped by readTree) This simplifies working with the configuration fixpoint in whitby, and is overall a bit more in line with how NixOS systems in user folders currently work. Change-Id: I1322ec5cc76c0207c099c05d44828a3df0b3ffc1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2931 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: glittershark <grfn@gws.fyi>
2021-04-11 r/2481 chore(3p): Bump channels to 2021-04-09Vincent Ambo11-389/+25
Fixes included: * exposed gtest in the package set, required for protobuf * pinned SBCL to version 2.0.8: The channel moved it to >2.1, and a bunch of warnings seemed to be killing our builds - we should investigate this later. * removed kernel patches from //users/tazjin/frog: this machine is currently out of service anyways, not worth fixing while it's offline * removed steam & lutris from frog (they're currently broken) * removed Haskell overrides for hedgehog-classes & hgeometry-combinatorial * use gRPC sources from upstream and inject Abseil via Nix instead * fix for renamed grpc import in //third_party/nix * use libfprint-tod from upstream nixpkgs in glittershark/yeren and delete glittershark/pkgs/fprintd entirely, since all of the patches used there are available and working from upstream now (and stopped working here after the bump) Change-Id: Ia90e6f774f7b88bc9e60d28351b900ca43ee2695 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2901 Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: lukegb <lukegb@tvl.fyi> Tested-by: BuildkiteCI
2021-04-11 r/2480 fix(pipelines/depot): Buildkite refers to branches by full refVincent Ambo1-1/+1
This change is required to run the :anchor: step on canon builds. Change-Id: Ib3cebac67c9f5337b27a948f120b0a9ba834ef2a Reviewed-on: https://cl.tvl.fyi/c/depot/+/2932 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: glittershark <grfn@gws.fyi>
2021-04-11 r/2479 fix(3p/haskellPackages): re-add random 1.2.0 to fix xanthoussterni2-8/+5
The random_1_2_0 attribute of haskellPackages currently holds random 1.2.0 which is what we want to have. We need to disable tests because they cause an infinite recursion as basically all testing libraries depend on random. This has the nice side effect that we no longer need import from derivation for random 1.2.0 (but owothia and xanthous still use it). Re-enable CI for xanthous. Additinonally we need to deal with the fallout of the haskellPackages overlay now also being pulled in for some machines since cl/2910 and let pandoc compile with random 1.2.0. Change-Id: I78d220e5bd35f3469d80d69e77e712a529f21d33 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2924 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: glittershark <grfn@gws.fyi>
2021-04-11 r/2478 feat(panettone): don't use `_` for em in inline markdownsterni2-6/+5
Since we are still using third_party, underscores are kind of common in issue titles and are probably often forgotten to escape. Let's just support `*` for emphasized text in titles for now. Change-Id: I305bcf4d4c59123bba4ce816a6da2ee8b022c34e Reviewed-on: https://cl.tvl.fyi/c/depot/+/2926 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: glittershark <grfn@gws.fyi>
2021-04-11 r/2477 feat(ops/pipelines): Add gcroots for depot builds on canonVincent Ambo2-2/+28
Adds a conditional build step that only runs on the canon branch, and only if :duck: (the status reporting step) succeeds, which creates a new Nix GC root for all depot targets named `depot-canon`. In practice this might be a bit racey, as canon builds are not guaranteed to succeed in order (though it is likely). This shouldn't matter much in practice: We only want to prevent rebuilds of the whole world. This fixes b/102 Change-Id: Id3d0bf4158bffcb1ed6929888a29d31609b6ece1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2904 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2021-04-11 r/2476 fix(tvl-buildkite): Set agents' primary group to buildkite-agentsVincent Ambo1-2/+5
This ensures files created by the Buildkite agents are always owned by the same group, without having to manually chgrp afterwards. Change-Id: Idbaedec43c16b2ee137d1a95719a05d46db8f900 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2929 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
2021-04-11 r/2475 chore(eta/keys): add eta's new yubikey-agent SSH keyeta1-2/+3
I have two YubiKeys now, and using the older one is more painful. Add the new one, so I don't have to faff with gpg-agent in order to submit CLs. Change-Id: I3fcd82cdb53f88dc00025de97666872802e270e2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2928 Reviewed-by: eta <eta@theta.eu.org> Tested-by: BuildkiteCI
2021-04-11 r/2474 feat(tvl): remove aranea from tvl.doteta1-3/+0
I've been told that they don't want to be in this any more, so references are removed in this CL by request. Change-Id: I80a04b714fc57781e57e8dce977d0aec2da4f009 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2927 Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: eta <eta@theta.eu.org> Reviewed-by: lukegb <lukegb@tvl.fyi> Tested-by: BuildkiteCI
2021-04-11 r/2473 feat(3p/nixpkgs): Plumb through externalArgs.nixpkgsBisectPathVincent Ambo2-4/+17
This lets the import of the depot root accept an additional argument called `externalArgs`, which can be used to pass additional arguments into a depot package set. This is used in //third_party/nixpkgs for replacing the source of the nixos-unstable channel with a path. With this we can bisect the nixpkgs used in third_party easily. Change-Id: I4f65eb3d6b521ed9f437649b7b068f1e6ab8210f Reviewed-on: https://cl.tvl.fyi/c/depot/+/2925 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-10 r/2472 fix(glittershark/system): Build yerenSystem in CIVincent Ambo1-1/+1
This wasn't working because yerenSystem wasn't actually accessing the `system` attribute (like the other systems), which meant it was just an attribute set full of stuff. Change-Id: I0abe56f0a1f18e4e542cb458dfcdf81e8a0ddc01 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2923 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2021-04-10 r/2471 fix(3p/nix): Fix dependency inclusion and reenable CIVincent Ambo1-9/+6
Change-Id: Ic2b7db4abe636b73b4c71e6a2f1501d3b4b8b90e Reviewed-on: https://cl.tvl.fyi/c/depot/+/2922 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-10 r/2470 refactor: Move nixpkgs attribute to `third_party.nixpkgs`Vincent Ambo46-490/+278
Please read b/108 to make sense of this. This gets rid of the explicit list of exposed packages from nixpkgs, and instead makes the entire package set available at `third_party.nixpkgs`. To accommodate this, a LOT of things have to be very slightly shuffled around. Some of this was done in already submitted CLs, but this change is unfortunately still quite noisy. Pay extra attention to: * overlay-like functionality that was partially moved to actual overlays (partially as in, the minimum required to get a green build) * modified uses of the package set path, esp. in NixOS systems Special notes: * xanthous has been disabled in CI because of issues with the Haskell overlay * //third_party/nix has been disabled because of other unclear dependency issues Both of these will be tackled in a followup CL. Change-Id: I2f9c60a4d275fdb5209264be0addfd7e06c53118 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2910 Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2021-04-10 r/2469 chore(tazjin/emacs): Use telega from nixpkgsVincent Ambo2-24/+5
adisbladis fixed the tdlib/telega versioning issues in nixpkgs at some point, so this isn't required anymore. Change-Id: Ib98e73d0e4394765f08f5f3741f70adab459c22f Reviewed-on: https://cl.tvl.fyi/c/depot/+/2909 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-10 r/2468 feat(ops/nixos/www): Enable short links for b/ and cl/Vincent Ambo2-0/+15
This configures accepting requests for b/ and cl/ on plain HTTP ports, and redirecting to b.tvl.fyi & cl.tvl.fyi appropriately. Additionally, Panettone request URIs that only contain decimals are redirected to `/issues/$request_uri` to enable issue short-links. This fixes b/32. Change-Id: I56954d8d69a3624267778b467520c509f4daa6c5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2908 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-10 r/2467 feat(gerrit): Auto link 'cl/123'-style shortlinksVincent Ambo1-0/+6
Same as linking to bugs (e.g. b/108). Change-Id: I447020bc07059c98c53322d745f961d8d471d9a4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2919 Reviewed-by: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI
2021-04-10 r/2466 refactor(3p/overlays): Move haskell overlay to new tree locationVincent Ambo3-2/+8
nixpkgs_exposed is going away, and the haskell overlay is independent from that. See also b/108, cl/2910 Change-Id: I3aea6dfc427a914f3f88146fd0b45d60dfd45a1a Reviewed-on: https://cl.tvl.fyi/c/depot/+/2918 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-10 r/2465 refactor(3p/dhall): Move easy-dhall-nix import into separate folderVincent Ambo4-18/+26
This is part of paving the way for clearly distinguishing between packages from nixpkgs and //third_party. See also: b/108, cl/2910 Change-Id: I28b5abd1f0f9fa3c4478c9f255b2025f4a4139f1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2917 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org> Reviewed-by: Profpatsch <mail@profpatsch.de> Reviewed-by: tazjin <mail@tazj.in>
2021-04-10 r/2464 refactor(ops): Consistent use of depot.third_party vs. pkgsVincent Ambo4-16/+13
In preparation for the solution of b/108, we need to consistently use `depot.third_party` for packages that are only packed in the TVL depot and `pkgs` for things that come from nixpkgs. This commit cleans up a huge chunk of these uses in //ops Change-Id: I00faeb969eaa70760a26256274925b07998c2351 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2915 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-10 r/2463 refactor(cheddar): Consistent use of depot.third_party vs. pkgsVincent Ambo1-3/+3
In preparation for the solution of b/108, we need to consistently use `depot.third_party` for packages that are only packed in the TVL depot and `pkgs` for things that come from nixpkgs. Change-Id: I49d82726b2f3bd7d4923effdd9a7e3f67ddc0659 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2916 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-10 r/2462 refactor(fun): Consistent use of depot.third_party vs. pkgsVincent Ambo6-14/+13
In preparation for the solution of b/108, we need to consistently use `depot.third_party` for packages that are only packed in the TVL depot and `pkgs` for things that come from nixpkgs. This commit cleans up a huge chunk of these uses in //fun Change-Id: I45a7b392a9749fa7859ff5100dcea415bda807c3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2914 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-10 r/2461 refactor(third_party): Consistent use of depot.third_party vs. pkgsVincent Ambo47-111/+111
In preparation for the solution of b/108, we need to consistently use `depot.third_party` for packages that are only packed in the TVL depot and `pkgs` for things that come from nixpkgs. This commit cleans up a huge chunk of these uses in //third_party Change-Id: Ic382c0cdea7330a84d5f0b7d109c824ddceb94e7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2912 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-10 r/2460 refactor(sterni): use pkgs over third_party to import from nixpkgssterni2-5/+4
This should ease migrating to a distinction between depot.third_party and pkgs (as in nixpkgs) in the future. Ref cl/2910, b/108. Change-Id: I53a854071fddd7c0d0526cc4c5b16998202082c6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2913 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-10 r/2459 fix(panettone): always use displayname in subjectssterni1-2/+2
Emails for (re)opening and closing where send out with the user's DN in the subject which is probably not what we want. Using displayname-if-known is probably not necessary as there is not really a case where (not *user*) wouldn't justify a 500 in this context. Change-Id: Id12d3d9619f42eb5337c2d3482b7c1646b5d6a81 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2911 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-09 r/2458 feat(tazjin/tverskoy): Set search domain to 'tvl.su'Vincent Ambo1-0/+1
Change-Id: I33ae590481abae9e20ed1ac7db5de66187f26925 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2907 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-09 r/2457 feat(tvl-buildkite): Add all buildkite agent users to a local groupVincent Ambo1-0/+9
This lets us grant permissions to them, e.g. on local folders. Change-Id: I823ac414be1cb7d6baa4f17d95003709e5911b04 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2905 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-09 r/2456 refactor(whitby): Extract Buildkite agents into a moduleVincent Ambo2-16/+41
There will be more Buildkite-agent specific configuration, and it's already more than just the module setup, so extracting this makes sense. Change-Id: I56ce205c0cb4365317ed7ed5f2d525a0b425b861 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2906 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-07 r/2455 feat(gs/yeren): Add KolideGriffin Smith3-0/+50
Add kolide, the endpoint monitoring system / MDM we're using at work, to the system derivation for my work computer. I hate MDMs almost universally, and this one is no different, but SOC2 waits for no one. Change-Id: I99bcb5341182a81512699d50b279efd9e1b2194b Reviewed-on: https://cl.tvl.fyi/c/depot/+/2903 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2021-04-07 r/2454 feat(3p/buzz): InitGriffin Smith2-0/+40
Package buzz, a desktop email notifier that uses passive (push-based) IMAP connections to get email notifications quickly. Change-Id: Idbd175db882cdab975b0928cd6920954500954a1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2902 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-07 r/2453 feat(gerrit-tvl): add Buildkite-backed Checks plugin implementationLuke Granger-Brown1-0/+131
This small(*) pile of JavaScript queries the Buildkite API for the latest builds for the depot and displays the results in the rebooted Check UI. Change-Id: I7025a1c6d0d0afa000a9df4682133e03824ea10d Reviewed-on: https://cl.tvl.fyi/c/depot/+/2881 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-06 r/2452 feat(ops/gerrit-tvl): init TVL Gerrit pluginLuke Granger-Brown6-1/+59
This is just going to be a grab bag of things which do TVL-specific things to Gerrit, whether that be exposing new Prolog predicates or, as I intend to do as the first thing, expose Buildkite builds as checks. Change-Id: Iaeab987a1fdbd078b85e274691c986489903bf3a Reviewed-on: https://cl.tvl.fyi/c/depot/+/2872 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-06 r/2451 feat(3p/gerrit): expose the Gerrit API in the outputLuke Granger-Brown2-3/+9
Writing Gerrit plugins that don't use the in-tree build system is more convenient if the API is actually exposed in the derivation's output. Change-Id: I3408d35498ca879576d532b005e36fde8ff2ea61 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2871 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-06 r/2450 chore(3p/gerrit): update gerrit and pluginsLuke Granger-Brown11-66/+281
This reverts commit 9551b628d02323b01ecb80220342eea488f7200e (i.e. this is a rollfoward for https://cl.tvl.fyi/c/depot/+/2817) Change-Id: Iaffcf1cdbe119d26ecb09cc88f9a56436b374c08 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2870 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2021-04-06 r/2449 fix(panettone): set external-format for stream from cheddarsterni1-1/+1
drakma ignores the :external-format-in parameter if :want-stream is t: > If want-stream is true, the message body is NOT read and instead > the (open) socket stream is returned as the first return value. > If the sixth value of HTTP-REQUEST is true, the stream should be > closed (and not be re-used) after the body has been read. The > stream returned is a flexi-stream with a chunked stream as its > underlying stream. If you want to read binary data from this > stream, read from the underlying stream which you can get with > FLEXI-STREAM-STREAM. Since it doesn't return a plain CL stream which would just work with SBCL, we need to set the external format on the resulting flexi-stream. Fixes b/107. Change-Id: I6e3178123c0927ef21fabf8118d9d357c8afbd42 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2869 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: glittershark <grfn@gws.fyi>
2021-04-06 r/2448 refactor(panettone): remove code duplication in render-markdownsterni1-20/+13
Move the common part (encoding/decoding json and connecting to cheddar) into request-markdown-from-cheddar. The two render-markdown implementations are now only thin wrappers around that function. Change-Id: I81bb34b684af44228dcad02fca541082e6d060ce Reviewed-on: https://cl.tvl.fyi/c/depot/+/2868 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-04-06 r/2447 fix(3p/cgit): fix max-width for #summarysterni1-1/+1
Having a space between the number and the unit is not valid CSS. I was aware of this problem, but apparently forgot to amend the fix. Change-Id: I74936db515799763038669d0a11da53f28f722be Reviewed-on: https://cl.tvl.fyi/c/depot/+/2867 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi>
2021-04-05 r/2446 fix(web/converse): Update to use mime_guess::from_pathVincent Ambo2-3/+1
... instead of its deprecated predecessor. Change-Id: I8af286c6b1ee7c25c153f1209d094ae4f5eb53cc Reviewed-on: https://cl.tvl.fyi/c/depot/+/2860 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-05 r/2445 refactor(web/converse): Use crimp instead of reqwestVincent Ambo5-379/+115
This simpler, curl-based HTTP client (which I wrote years ago) is a first step towards cleaning up the dependency mess of converse. Dependency stats: +4, -28 Change-Id: I4f5f3c9307895d261bfb0a6bcf2337b747f9a4c0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2859 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-04-05 r/2444 chore(web/converse): Apply 'cargo fix --edition'Vincent Ambo7-29/+29
This does not yet change up `extern crate` and `macro_use` statements, but since we still depend on Diesel that also wouldn't work right now. Change-Id: I36de1b7b56f7d220f567346e13bad8da06461517 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2858 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>