about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
2021-12-25 r/3401 feat(whitby): Configure initial Keycloak setupVincent Ambo4-1/+59
Trialing this as an alternative to CAS that is a little easier to configure and can help us delegate authentication to other OIDC services. Change-Id: Iad63724d349334910af8fed0b148e4ba428f796b Reviewed-on: https://cl.tvl.fyi/c/depot/+/4608 Tested-by: BuildkiteCI Autosubmit: tazjin <mail@tazj.in> Reviewed-by: lukegb <lukegb@tvl.fyi>
2021-12-25 r/3400 chore(wpcarro/emacs): Annotate (some of) my Emacs TODOs with wpcarroWilliam Carroll1-6/+10
...so that they can be properly tracked 馃 Change-Id: I1e33bd5f0e0a114ef441a5f3f61f387b7afd8708 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4611 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-25 r/3399 chore(wpcarro/emacs): Drop support for lsp-haskellWilliam Carroll2-9/+0
1. This is spamming my Emacs's *Warnings* buffer on init. 2. I recall this being buggy. 3. I'm not doing active Haskell development at the moment. 4. I'd prefer code-intelligence efforts be put into SourceGraph. Change-Id: I57ba28ec0b2fa3607cd67261a90d134107166c47 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4610 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-25 r/3398 fix(wpcarro/marcus): Prefer tzupdate 馃寧William Carroll1-3/+1
I couldn't get services.localtime to behave, but services.tzupdate WAIs. As long as I have internet, my timezone on this laptop should synchronize with my location. Change-Id: Ie2fd0e742e080fb7d6dd1adcc87c9fd22eae032d Reviewed-on: https://cl.tvl.fyi/c/depot/+/4609 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-25 r/3397 feat(wpcarro/nixos): Enable locateWilliam Carroll1-0/+2
Periodically run updatedb. Change-Id: Ia1b70e84f991ae3b584b8479f59b45639cd28a59 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4603 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-25 r/3396 feat(wpcarro/marcus): Enable localtime serviceWilliam Carroll1-0/+2
Ensure my laptop's timezone is updated as I move around. Change-Id: Ifc2d1bbff2e59c0f7e0a3506152d720986ceab58 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4602 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-25 r/3395 refactor(wpcarro/nixos): Define common.programs mixinWilliam Carroll3-17/+21
DRYing-up more configuration. Change-Id: I390cedd6a325ac17ef06c0887d3e0ac2b387b85b Reviewed-on: https://cl.tvl.fyi/c/depot/+/4601 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-25 r/3394 refactor(wpcarro/nixos): Define common.servicesWilliam Carroll3-18/+12
DRY things up with this mixin. Change-Id: I5791a50b01902734dff91d391e1aa90a21ce4fbb Reviewed-on: https://cl.tvl.fyi/c/depot/+/4600 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-25 r/3393 feat(wpcarro/diogenes): Set EDITORWilliam Carroll1-0/+7
I should be doing most of my remote file editing using Emacs and Tramp, but sometimes a CLI command triggers the EDITOR, which is `nano` by default. I can control `vim` better than I can control `nano` within a vterm session, so I'm trying this configuration for now. Change-Id: I2023beadfe05a957bc5ddd6e6793a891521f301d Reviewed-on: https://cl.tvl.fyi/c/depot/+/4599 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-25 r/3392 fix(wpcarro/emacs): Only render unicode emojisWilliam Carroll1-0/+4
Disable ASCII and Github styles. Change-Id: Ie68fa2f0129573ea8b893db22214136d69429702 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4598 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-25 r/3391 feat(wpcarro/emacs): Support emojis in Emacs 馃帀William Carroll3-0/+12
The future has arrived... Change-Id: Ib4e57018cbf9168e43f403e4e0b640d0e0035352 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4595 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-25 r/3390 feat(sterni/aoc/2021): day 20 solutionsterni1-0/+29
Change-Id: Id864d6e6f0722c2da5d3487bd38da80e6bff2161 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4566 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-12-25 r/3389 feat(sterni/aoc/2021): day 6 solutionsterni1-6/+21
Change-Id: Icd21b0f0c92b596fbb369d6f08715a6554259572 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4558 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
2021-12-25 r/3388 feat(depot-scanner): forward non-processed stderr outputzseri1-0/+5
previously, depot-scanner swallowed/ignored all non-processed stderr output of nix-instantiate, which makes diagnosing failures of nix-instantiate (e.g. failed with exit status 1) difficult. This commit fixes that by always forwarding the remaining stderr messages. Example previous error message: panic: nix-instantiate failed: exit status 1 goroutine 1 [running]: main.main() /nix/store/8vb2j13bd7j5ipl7dhsnwvgr7nrrsqsi-main.go:160 +0xeb4 Example new error message: nix-inst> error: unrecognised flag '--trace-file-access' nix-inst> Try '/run/current-system/sw/bin/nix-instantiate --help' for more information. panic: nix-instantiate failed: exit status 1 goroutine 1 [running]: main.main() /nix/store/qy7v79a3harddirzmc0432vbzqhyf91i-main.go:165 +0xeb4 Change-Id: I666f3490fc648f77a5384b95edd74f6115f7920d Reviewed-on: https://cl.tvl.fyi/c/depot/+/4553 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2021-12-25 r/3387 chore(zseri/store-ref-scanner): use tailored fuzz inputzseri1-8/+5
Change-Id: Ib061154c2329432469e8f7bef4598402a56bd0c3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4606 Reviewed-by: zseri <zseri.devel@ytrizja.de> Tested-by: BuildkiteCI
2021-12-25 r/3386 refactor(zseri/store-ref-scanner): get rid of proc_unroll dependencyzseri8-1123/+96
Change-Id: I0d4a8b2af814fd2870c3eb4218ee4fbaba1216f5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4605 Tested-by: BuildkiteCI Reviewed-by: zseri <zseri.devel@ytrizja.de>
2021-12-25 r/3385 fix(zseri/store-ref-scanner): no_std support and runtime panicszseri11-608/+238
This also changes the fuzzing infrastructure from proptest to cargo-fuzz, and this lead to the discovery of two mishandlings of edge-cases: * when a "path_to_store" is at the end of the input, it tried to access the input slice out-of-bounds (the `just_store` test covers that now) * non-ASCII characters lead to an out-of-bounds access in HalfBytesMask (the `non_ascii` test covers that now) Change-Id: Icaa2518dcd93e1789a2c0da4cf0fec46016d3bad Reviewed-on: https://cl.tvl.fyi/c/depot/+/4604 Tested-by: BuildkiteCI Reviewed-by: zseri <zseri.devel@ytrizja.de>
2021-12-25 r/3384 chore(zseri/store-ref-scanner): fix clippy warningszseri2-17/+6
Change-Id: I0e75feb501c56a98a73048443c36132308245945 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4597 Tested-by: BuildkiteCI Reviewed-by: zseri <zseri.devel@ytrizja.de>
2021-12-25 r/3383 feat(zseri): Add store-ref-scanner cratezseri8-0/+2018
This crate implements the scanner for finding references to store paths in uncompressed binary blobs and text files. It is currently a minimally working prototype and it is probably a good idea to polish the interface further. Change-Id: I8406f9d52d254fc3d660ea2b9bc9b7841cc815ec Reviewed-on: https://cl.tvl.fyi/c/depot/+/4596 Tested-by: BuildkiteCI Reviewed-by: zseri <zseri.devel@ytrizja.de>
2021-12-25 r/3382 chore(wpcarro/diogenes): Fix formattingWilliam Carroll1-2/+2
This is the result of `evil-indent` going wrong. Change-Id: I8d68bcb790da03b974d478760bf1224b38d56249 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4594 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-25 r/3381 fix(wpcarro/diogenes): programs.fish.enable = trueWilliam Carroll1-3/+6
Hopefully this installs the KBDs for fzf, which is already installed. Change-Id: Ice7555c45d38e2e07f9fb16d3ddfc5b971c93cf6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4593 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-24 r/3380 refactor(wpcarro): Define common.shell-utilsWilliam Carroll4-60/+57
DRYing up some of my configuration. Change-Id: I137692789426efc6a6c6880029e605813674fdbe Reviewed-on: https://cl.tvl.fyi/c/depot/+/4592 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-24 r/3379 feat(wpcarro/marcus): Require python3William Carroll1-0/+1
I use `python3` REPL as a calculator most often. Side note: I don't have a clear model of which binaries belong in NixOS configurations and which belong in my Emacs configuration. Here's a sketch of what I'm thinking: - shared (wpcarro's coreutils for fzf, ripgrep, git, etc) - marcus - diogenes - wpcarros-emacs (see footnote) Footnote: It might be redundant to install wpcarro's coreutils in Emacs on NixOS environments, but I install wpcarros-emacs in non-NixOS environments, so I depend on them there. Change-Id: Ib2b87c8e4e04d167ccbf837e0f85606cbf272828 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4591 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-24 r/3378 feat(wpcarro/emacs): Require ispell dependencyWilliam Carroll1-14/+15
Also sort my dependencies, which is why this diff is noisy. Change-Id: I998ca354d94d4c6283f9fdf76b06c08b9972ced5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4590 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-24 r/3377 feat(wpcarro/emacs): Support wpcarro@wpcarro.dev in ssh.elWilliam Carroll1-5/+3
I'm accustomed to using vim in a GUI terminal to edit remote files. I'm trying to ween-off of this dependency in favor of using Emacs. Change-Id: Ib71d18135a7a9ef6ef61dfce814fffbea79a36f7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4589 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-24 r/3376 feat(grfn/bbbg): Add styling for active nav itemGriffin Smith3-7/+28
Change-Id: I5fbbd5ea6965d107cb9a44dff89ac77d0598c1f1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4588 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-12-24 r/3375 feat(grfn/bbbg): Style home pageGriffin Smith2-1/+27
This is just a Big Old Button Change-Id: I19f5d15562fe2e0ef26de0cc61d06604e92c9c00 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4587 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-12-24 r/3374 feat(grfn/bbbg): Make nav width responsiveGriffin Smith1-2/+19
Change-Id: Ie0cebb48d555aa9ed894d3491d27293838b4ea7e Reviewed-on: https://cl.tvl.fyi/c/depot/+/4586 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-12-24 r/3373 feat(tazjin/emacs): Use Emacs input methods in X11 buffersVincent Ambo2-2/+17
This is much easier than the shitty keyboard layout switcher which caused all kinds of terrifying bugs. Unfortunately the layout switcher remains additionally because this doesn't work with Quassel (Qt dropped support for XIM). Change-Id: I7c58cebf9391216b6e7134d8c283d52cb18332de Reviewed-on: https://cl.tvl.fyi/c/depot/+/3497 Tested-by: BuildkiteCI Autosubmit: tazjin <mail@tazj.in> Reviewed-by: tazjin <mail@tazj.in>
2021-12-24 r/3372 feat(grfn/bbbg): Add styling for flash messagesGriffin Smith3-4/+29
Change-Id: Ic8594217e6acceaad041dda8acf135bf7f3408e9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4585 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-12-24 r/3371 feat(depotfmt): run formatting checks in CIVincent Ambo1-6/+19
Right now this only includes Go, but more is to come. Change-Id: Idd8fc27c0eb25e82688ef8337ba20810d834f4b6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4504 Reviewed-by: zseri <zseri.devel@ytrizja.de> Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI Autosubmit: tazjin <mail@tazj.in>
2021-12-24 r/3370 feat(depotfmt): add terraform formatting to depotfmtVincent Ambo1-0/+5
Change-Id: I235e7fcbd49f11e71127ce31da9c11da4d220ff6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4584 Autosubmit: tazjin <mail@tazj.in> Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi>
2021-12-24 r/3369 feat(ops/glesys): Provide tf-glesys wrapperVincent Ambo3-0/+13
This provides the right Terraform provider with a wrapper in $PATH. Change-Id: Idcb4fa89dff0161e8a73addfce81959e825c331e Reviewed-on: https://cl.tvl.fyi/c/depot/+/4562 Tested-by: BuildkiteCI Autosubmit: tazjin <mail@tazj.in> Reviewed-by: grfn <grfn@gws.fyi>
2021-12-24 r/3368 feat(3p/terraform-provider-glesys): init at v0.3.1Vincent Ambo1-0/+23
Change-Id: I1c7e398dca824a8606461ac8274f74cbb0764941 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4560 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: Profpatsch <mail@profpatsch.de> Autosubmit: tazjin <mail@tazj.in>
2021-12-24 r/3367 style(ops/glesys): apply terraform fmtVincent Ambo1-10/+10
Change-Id: Ibbba78aaecc3b3cba23961a1b10ce5a8eb8ff296 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4580 Tested-by: BuildkiteCI Autosubmit: tazjin <mail@tazj.in> Reviewed-by: grfn <grfn@gws.fyi>
2021-12-24 r/3366 feat(ops/glesys): Add gitignore for Terraform filesVincent Ambo1-0/+3
Change-Id: I67b971f875819fd9daa3b2e952604206b89ee216 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4578 Tested-by: BuildkiteCI Autosubmit: tazjin <mail@tazj.in> Reviewed-by: grfn <grfn@gws.fyi>
2021-12-24 r/3365 feat(ops/glesys): Create objectstorage key for litestreamVincent Ambo1-0/+5
Change-Id: I8b3e4f767440ae7763c1e6ce9fd97c557fe516ee Reviewed-on: https://cl.tvl.fyi/c/depot/+/4577 Tested-by: BuildkiteCI Autosubmit: tazjin <mail@tazj.in> Reviewed-by: grfn <grfn@gws.fyi>
2021-12-24 r/3364 feat(ops/glesys): Move Terraform state to GleSYS bucketVincent Ambo1-0/+11
Change-Id: Ib14fba9a5f06ecdb065dd14580c8088f98e9cb3a Reviewed-on: https://cl.tvl.fyi/c/depot/+/4576 Tested-by: BuildkiteCI Autosubmit: tazjin <mail@tazj.in> Reviewed-by: grfn <grfn@gws.fyi>
2021-12-24 r/3363 feat(ops/glesys): Create bucket & key for storing terraform stateVincent Ambo1-0/+14
Change-Id: I73cfaa614d46afb65ba312e767d1e924669fbae1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4575 Tested-by: BuildkiteCI Autosubmit: tazjin <mail@tazj.in> Reviewed-by: grfn <grfn@gws.fyi>
2021-12-24 r/3362 feat(ops/glesys): Import existing object storage instanceVincent Ambo1-0/+22
Change-Id: I5a5269ef0d385d864dd8f62eb2332e6ae2cb2672 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4574 Tested-by: BuildkiteCI Autosubmit: tazjin <mail@tazj.in> Reviewed-by: grfn <grfn@gws.fyi>
2021-12-24 r/3361 feat(grfn/bbbg): Begin stylesGriffin Smith20-19/+256
Start working on styles for the app, beginning with a global stylesheet/reset and styles for the nav. Change-Id: Ie15e549d7bb4e0116582f4099752aa2503eb9ce7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4583 Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi> Tested-by: BuildkiteCI
2021-12-24 r/3360 feat(wpcarro/diogenes): Install digWilliam Carroll1-0/+1
I'm pretty often using dig server-side. Change-Id: I030b52875e13cac7ec7a5e7658db2e09ec5afba9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4582 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-24 r/3359 feat(wpcarro/diogenes): Enable ssh-agentWilliam Carroll1-0/+6
Change-Id: I38fe1fcf4be2423acc29c43449cb778c8890df01 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4581 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI
2021-12-24 r/3358 feat(wpcarro/irc): Support Quassel client/serverWilliam Carroll2-4/+27
- server: diogenes - client: marcus Change-Id: Ifc3a58370f6d68aec35ef363a40d03a8429f8012 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4579 Tested-by: BuildkiteCI Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com>
2021-12-24 r/3357 feat(grfn/bbbg): Allow creating events with attendeesGriffin Smith2-23/+38
Change-Id: I91a6a54921b90098040eb315d8b5385bd42879ac Reviewed-on: https://cl.tvl.fyi/c/depot/+/4573 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi>
2021-12-24 r/3356 feat(grfn/bbbg): Add an import attendees button to event pageGriffin Smith3-14/+38
Change-Id: Iab69500f927a3f5a70d294ece3f95891853b63c3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4572 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi>
2021-12-24 r/3355 fix(grfn/bbbg): Properly use dynamic var for auth checkGriffin Smith1-1/+1
Change-Id: If457999d1f4b6d3f2f6b6de8cdbdbceb8f399796 Reviewed-on: https://cl.tvl.fyi/c/depot/+/4571 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi>
2021-12-24 r/3354 feat(grfn/bbbg): Allow importing event attendeesGriffin Smith15-29/+242
Add support for importing the tsv that meetup exports into a list of upserted attendees, and event-attendee joins. Change-Id: I5f4ddc9fc63bcc6b0334bc3e1d3cbc4d5b99c21b Reviewed-on: https://cl.tvl.fyi/c/depot/+/4570 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi>
2021-12-24 r/3353 feat(grfn/home): Set git.config.advice.skippedCherryPicks=falseGriffin Smith1-0/+1
Git recently started warning about this behavior, which it's always had and I've always liked, and I don't want the warning. Change-Id: I19ae397770b271924cc975e5f8c50d6351ed29ce Reviewed-on: https://cl.tvl.fyi/c/depot/+/4569 Tested-by: BuildkiteCI Reviewed-by: grfn <grfn@gws.fyi> Autosubmit: grfn <grfn@gws.fyi>
2021-12-24 r/3352 fix(wpcarro/emacs): Disable ligaturesWilliam Carroll1-1/+0
Trying to render ligatures (e.g. ->, <>) in the modeline causes Emacs to crash, so I'm disabling ligatures. I have a patch like this on my work machine. I'll eventually merge those commits into depot, but that will have to wait until I'm back in California. Change-Id: I5e408cbdb717d24c7d5f88b4c822bdf32f370eef Reviewed-on: https://cl.tvl.fyi/c/depot/+/4568 Reviewed-by: wpcarro <wpcarro@gmail.com> Autosubmit: wpcarro <wpcarro@gmail.com> Tested-by: BuildkiteCI