about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
2020-11-27 r/1937 refactor(tvix): json-to-value: use unique_ptr instead of raw pointersYorick van Pelt1-21/+18
Backported from upstream at a350d0beb0e13d0f58698510bd6a96d894cd06fd Change-Id: Ib486bc1b36ef65041fab1a4634a0a82e13036fd4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2139 Tested-by: BuildkiteCI Reviewed-by: andi <andi@notmuch.email>
2020-11-27 r/1936 fix(users/multi/home): fix tmux keybindings for tmux 3.1multi1-2/+2
The "swap-window" command swaps two windows, the 'source' and 'destination' window, exchanging the indices they occupy in the window list. In at least tmux 2.8 (which is what's in Debian Stable), if the window under focus is the source window, then focus follows that window (i.e. the focus changes to the current window's new index atomically with it being moved to that index). In more recent tmux versions, this is not the case, and the focus remains on the old index, so that the replacement window comes under focus. The former behaviour is still possible, but must be explicitly requested. Change-Id: Ieff606dfc2624b869d3bb6e1344dd4d0c6301857 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2169 Reviewed-by: multi <depot@in-addr.xyz> Tested-by: BuildkiteCI
2020-11-27 r/1935 feat(tvix): run the test-vm with ncurses supportAndreas Rammhold1-1/+1
This allows users to use C-A C to access the QEMU console while within the VM terminal. From there you can control the process (e.g. kill it). Change-Id: If2eec2e385fd27fc4e20921dcad78be7390f9d2b Reviewed-on: https://cl.tvl.fyi/c/depot/+/2167 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-11-27 r/1934 chore(tvix): avoid unnesscary rebuilds of protos and tvixAndreas Rammhold1-2/+26
For the build of tvix we can safely ignore all the files in src/protos as well as all the nix files in the root of the repository. By passing the input sources through builtins.filterSource we can make a per-file decision whether or not we want to copy it into the store (in other words: if we consider it relevant for the build). This enables much faster development on the actual build expression. Change-Id: Ib4c01dbe9cbfa9770922f6257af2a7259814ce0d Reviewed-on: https://cl.tvl.fyi/c/depot/+/2159 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: lukegb <lukegb@tvl.fyi>
2020-11-27 r/1933 fix(tvix): Don't double-up on endlines from log messagesGriffin Smith1-1/+1
Change-Id: I676dd4e9d8b1a7ff5389323e0462ba6681d62cf0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2168 Reviewed-by: andi <andi@notmuch.email> Reviewed-by: kanepyork <rikingcoding@gmail.com> Tested-by: BuildkiteCI
2020-11-27 r/1932 fix(docs/REVIEWS): mention ##tvl-dev firstKane York1-1/+1
Change-Id: I34082af6249ba1c4d16b5b5d7f5f3fd78d4767bc Reviewed-on: https://cl.tvl.fyi/c/depot/+/2151 Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-11-27 r/1931 refactor(tvix): remove signedness conversions by using std::optionalKane York1-4/+4
The different signedness of level and withLevel was causing implicit conversions. Use a nullopt instead of a -1 sentinel value. third_party/nix/src/libexpr/nixexpr.cc:242:21: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions] Change-Id: I7c2cadb6fd6bbff6c5b84028651ad4ebba423297 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2157 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: glittershark <grfn@gws.fyi>
2020-11-27 r/1930 fix(tvix): make unsigned conversion explicitKane York1-1/+1
Implicit signedness conversion was causing warnings. Perform a static_cast; this value should never be out of range. third_party/nix/src/libmain/shared.cc:310:12: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions] Change-Id: I34fe53d186ae33f970147135bbe3894fb39a0ec7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2156 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: glittershark <grfn@gws.fyi>
2020-11-27 r/1929 fix(tvix): sqlite bind argument number is signedKane York1-1/+1
third_party/nix/src/libstore/sqlite.cc:89:33: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions] Change-Id: I1dbc01acaecc4f382f63e7108429cd814ff05f4f Reviewed-on: https://cl.tvl.fyi/c/depot/+/2155 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: glittershark <grfn@gws.fyi>
2020-11-27 r/1928 fix(panettone): only scroll if content is too wideAlyssa Ross1-1/+1
Guessing Griffin uses a Mac with invisible scroll bars. ;-) Change-Id: I1771f941f149d5ab5816e67861b6bcd91001e652 Cc: Griffin Smith <grfn@gws.fyi> Reviewed-on: https://cl.tvl.fyi/c/depot/+/2163 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-11-27 r/1927 chore(tazjin/rlox): Wire scanner to interpreter to reduce warningsVincent Ambo2-1/+18
... they're just noisy at the moment. This isn't complete because it doesn't thread through scanner errors. Change-Id: I0f75d2b20fa3f57be1af5d1d8aa8059856855825 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2162 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-11-27 r/1926 feat(tazjin/rlox): Implement multi-character scanningVincent Ambo1-0/+16
Change-Id: Ic5a246a7f5834477aeb97824fa30ba74a8422bc1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2161 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-11-27 r/1925 refactor(tazjin/rlox): Use &[char] instead of &str in scannerVincent Ambo1-7/+3
This makes it easier to work with the Unicode issue. The original string representation can be discarded. Change-Id: I740be4cb9654679ea7950f3899c5c709b1e7a739 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2160 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-11-27 r/1924 feat(tvix): builtins.fromJSON: use nlohmann/json parser instead of custom parserYorick van Pelt1-153/+114
backported from upstream at f1fac0b5c3b75efab781949fdff2b67ffdda2cb3 Change-Id: I788e3a9b930351118a5f248b356c351afd7f5391 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2138 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-11-27 r/1923 feat(tazjin/covid): Add jq script for wrangling CDC dataVincent Ambo1-0/+36
Change-Id: Ia23f528d28126d6a2d0dd2d7327ec686c7e90df4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2158 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-11-26 r/1922 feat(users/riking/fish): add nix-env to shellKane York1-0/+141
Change-Id: Ic889506b8d4506093b4080d67e93cf9877916850 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2153 Reviewed-by: kanepyork <rikingcoding@gmail.com> Tested-by: BuildkiteCI
2020-11-26 r/1921 feat(gs/system): Enable docker on dev machinesGriffin Smith2-0/+6
This was locked away in the urbint-specific module, but I use it elsewhere. Change-Id: Ifced2196dc22a9dbed74a18d4e1fed9488eb0e26 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2152 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-11-26 r/1920 fix(gs/system): lorri as a home-manager svc doesn't work on DarwinGriffin Smith1-2/+0
Change-Id: Ieaf14d955157c759f12d70ddfd518789281dab1a Reviewed-on: https://cl.tvl.fyi/c/depot/+/2150 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-11-26 r/1919 chore(glittershark): Remove everything Urbint relatedGriffin Smith9-197/+7
bye urbint! Change-Id: I87ded275e6e5298e4e29c38775bae47a8fc07bac Reviewed-on: https://cl.tvl.fyi/c/depot/+/2149 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-11-26 r/1918 feat(tvl-slapd): add jamie to slapdJamie McClymont1-0/+5
o/ - Jamie Change-Id: I9c21e9a58c4514160f08133465a9cca720055cbf Reviewed-on: https://cl.tvl.fyi/c/depot/+/2148 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-11-25 r/1917 feat(glittershark): Get everything working on DarwinGriffin Smith8-42/+46
Update everything in home-manager to properly work on darwin (including adding dobharchu as a top-level attribute from //users/glittershark/home) and also fix font faces and sizes in emacs config Change-Id: Ica889dd212876030d5c2a916a71d8b614e6964f1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2147 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-11-23 r/1916 feat(users/multi/home): add readline configuration and nix-shell handling to ↵multi1-3/+40
bashrc. This adds my standard inputrc to my home-manager configuration, via the latter's readline module, and adds nix-shell detection to my bash prompt string. Additionally, nix-shell is wrapped in a shell function, so that entering a nix-shell environment automatically runs bash as a subprocess where appropriate, as the default environment spawned by nix-shell is not to my liking. Change-Id: Id5b1b9415a185ad9920f268c66de32d6ccc0b452 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2146 Reviewed-by: multi <depot@in-addr.xyz> Tested-by: BuildkiteCI
2020-11-23 r/1915 fix(gs/home): Don't override alacritty versionGriffin Smith1-14/+0
This was only done to get an upgraded version, which is no longer necessary with the nixpkgs bump but was also causing incompatibilities with opengl Change-Id: Ic398b4ac6caf24a1d40b7a4917b5053fba12d97a Reviewed-on: https://cl.tvl.fyi/c/depot/+/2145 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-11-23 r/1914 feat(tazjin/rlox): Implement single-character scanningVincent Ambo3-0/+139
... still not that interesting, but at this point slightly divergent from the book: The book embraces mutability for interpreter state, initially for tracking whether an error condition has occured. I avoid this by instead defining an error type and collecting the error values, to be handled later on. Notes: So far nothing special, but this is just the beginning of the book. I like the style it is written in and it has pointed to some interesting resources, such as a 1965 paper titled "The Next 700 Languages". Change-Id: I030b38438fec9eb55372bf547af225138908230a Reviewed-on: https://cl.tvl.fyi/c/depot/+/2144 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-11-23 r/1913 feat(tazjin/rlox): Add basic program structureVincent Ambo3-10/+36
... as well as a Nix derivation, because why not. Change-Id: Iaf2591ab72676fe0732c3f807b3aa0cff13fb4ef Reviewed-on: https://cl.tvl.fyi/c/depot/+/2143 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-11-23 r/1912 feat(tazjin/rlox): Bootstrap programVincent Ambo5-0/+48
This is going to be the first of two interpreters from "Crafting Interpreters". Change-Id: I354ddd2357444648d0245f35d92176dd176525d8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2142 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-11-22 r/1911 feat(tazjin/emacs): Enable midnight.elVincent Ambo1-1/+4
Change-Id: I22bedd80c6e99ccefefa7840ec37496360937842 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2137 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-11-22 r/1910 feat(tvix): Support a --quiet argument to nix-buildGriffin Smith1-0/+2
This is passed by some third-party tools, notably home-manager. At some point we should fully revamp argument parsing and log verbosity setting, but for now this gets us to more of a working state Fixes: b/78 Change-Id: I4134b17315e30145fd43d3659f407d7121ce8876 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2136 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-11-22 r/1909 fix(tvix): Add endlines to build log messagesGriffin Smith1-16/+19
Change-Id: Id6e871a2b7fbb24fb5c8e84e1638bfe94e363b57 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2135 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-11-22 r/1908 feat(tvix): Convert some DLOGs to VLOGsGriffin Smith6-10/+10
It seems like the amount of logging is causing things to move a little slower - even if that's not really the case, it gets in the way of debugging things. Refs: b/76 Change-Id: I9ea99a3b16e3307a0b0371bad22d03b0e2175af6 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2134 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-11-22 r/1907 feat(whitby): Move wigglydonke.rs to whitbyGriffin Smith3-6/+16
Mugwump is too unstable for such an important internet service Change-Id: Ic714200ce5ce51f366777f538b4a6f443f010960 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2124 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-11-22 r/1906 feat(tvix): Add a pos field to more expr classesGriffin Smith2-6/+14
To aid in both debugging and (eventually) printing stacktraces, add a Pos member to a few more Expr variants. Change-Id: Ic1d2a056fc7e6c07bc3e79fa38845cb4a5da5ca5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2133 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-11-22 r/1905 feat(ops/nixos): Give all nixoses a config.depotGriffin Smith1-1/+7
Add the depot.nix module and a depot config option to all nixos system derivations that're build through the `bin/rebuild-system` machinery. I can't imagine a scenario where we wouldn't want this level of integration. Change-Id: Ieeb98db2eee23919256adb4654bc45d540e055ec Reviewed-on: https://cl.tvl.fyi/c/depot/+/2128 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi>
2020-11-22 r/1904 fix(panettone): Prefix all IRC messages with a ZWSPGriffin Smith1-1/+4
Prefix all IRC notifications from panettone with a unicode zero-width-space so that they don't get picked up by other IRC bots (notably bslsk05). Change-Id: I350fd1b6d2145e496c22a8f56ba3530fc9f1a978 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2127 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi> Reviewed-by: tazjin <mail@tazj.in>
2020-11-22 r/1903 feat(panettone): Send notifications when issues are closedGriffin Smith1-5/+14
Send an irc notification when issues are marked closed, in a similar format to the notifications sent when new issues are created. Change-Id: I2fdde33f0dedc223a5c2265eed778161938f8e9a Reviewed-on: https://cl.tvl.fyi/c/depot/+/2126 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-11-22 r/1902 fix(users/multi/home): re-add overridden htop package to home-manager ↵multi1-0/+2
configuration. I previously removed my local package set from my HM config while the latter was being made readTree compatible. Now that both the HM config and the local package set can be built with readTree, I can re-enable the locally-overridden htop package. Change-Id: I77e20248c010bc7027e0b0a3164ec48d6ec29f31 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2132 Tested-by: BuildkiteCI Reviewed-by: multi <depot@in-addr.xyz>
2020-11-22 r/1901 refactor(user/multi/pkgs): make my local package set readTree-compatible.multi2-4/+11
This adds readTree configuration for accessing my local package set, and also adds these packages to the CI configuration. Change-Id: Icd2d16e85859343902e73a466f3c6ba8d781537f Reviewed-on: https://cl.tvl.fyi/c/depot/+/2131 Tested-by: BuildkiteCI Reviewed-by: multi <depot@in-addr.xyz>
2020-11-22 r/1900 fix(users/multi/home): use local depot checkout.multi1-2/+6
This reverts 1478317d149539d74fa4bad8414658fb7119ea07. Using depot.depotPath in my home-manager configuration results in my NIX_PATH and home-manager config file path being pointed at a copy of the depot in the nix store, which makes building from my local depot checkout a bit cumbersome. Change-Id: Ib687d3e8147cb32df071d3c19a5300294ea62c0c Reviewed-on: https://cl.tvl.fyi/c/depot/+/2130 Tested-by: BuildkiteCI Reviewed-by: multi <depot@in-addr.xyz>
2020-11-22 r/1899 refactor(users/multi): migrate whitby home-manager config to ↵multi3-69/+11
readTree-compatible version. Add a new home-manager-compatible configuration file which loads the common config attrset used by the readTree machinery into a structure which the home-manager command line tool understands. Garbage-collect the old home-manager configuration file used on whitby, and update the HOME_MANAGER_CONFIG path to point at the new shim config. Instead of having a per-environment HM configuration (not that I have more than one environment), there's now a single configuration which evaluates to an attrset of configurations, which can be loaded and built using "home-manager build -A $attr". Change-Id: Id8b35dc89aabffedf1a4dadfa0d3d4b914e4e2e7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2129 Tested-by: BuildkiteCI Reviewed-by: multi <depot@in-addr.xyz>
2020-11-22 r/1898 refactor(users/multi): make my user directory CI-compatible.multi3-0/+93
My home-manager config is not currently readTree compatible, which means that it's not built by CI. This constructs a house of cards around home-manager to make this buildable in CI. Change-Id: I80480f24ff47347f46d708edbbf34d59fa76adac Reviewed-on: https://cl.tvl.fyi/c/depot/+/2123 Tested-by: BuildkiteCI Reviewed-by: multi <depot@in-addr.xyz>
2020-11-22 r/1897 refactor(users/multi/whitby): use the depot's own source location attribute.multi2-9/+2
The depot knows where it is, not because it knows where it isn't, but because it does an "import ./." at the top level and then makes this path value available in the attrset passed to the rest of the tree. My home-manager config on whitby previously involved manual specification of the depot checkout location on whitby, however this isn't necessary when the depot can already magically tell us where it is. Change-Id: I68577c8ef2cda6ba5bc46cf8f4821aac021c8066 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2122 Tested-by: BuildkiteCI Reviewed-by: multi <depot@in-addr.xyz>
2020-11-22 r/1896 feat(panettone): Bring back + fix irccat issue creation announcementGriffin Smith4-6/+43
This reverts commit e1067b1497b3dea0c37ae51bba21f42f1e7d35b5. The original issue here was misusing ISSUE-ID instead of ID, but also the associated username for the message should've been CN instead of DN Change-Id: I1629c0cb7597ff2ee2867f27870378eecdafe126 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2125 Tested-by: BuildkiteCI Reviewed-by: eta <eta@theta.eu.org>
2020-11-21 r/1895 fix(users/multi/whitby): fix home-manager configuration on whitby.multi1-1/+1
"let pkgs = import <nixpkgs> {}; in pkgs.home-manager.src" evaluates to the source derivation for home-manager, however home-manager's configuration machinery expects to be passed the store path of this derivation instead of the derivation object itself. Change-Id: I6b0ba3efaff9d080900349529576443192b058e9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2121 Reviewed-by: multi <depot@in-addr.xyz> Tested-by: BuildkiteCI
2020-11-21 r/1894 chore(3p): Bump nixpkgs to nixos-unstable from 2020-11-21Vincent Ambo17-91/+71
Included fixes for random breakage: * 3p/awscli: pick from the stable channel; it is broken on unstable * 3p/googletest: bumped version & removed patches that nixpkgs applies * 3p/lisp/cffi: bumped library version for SBCL compat * 3p/nix: fix libsystemd attribute * 3p/nix: reformatted (clang-format handling of ternaries changed) * glittershark/home: Use home-manager from nixkpgs * glittershark/kernel: bumped linux-ck patch hash * glittershark/kernel: removed "patch patch" * multi/whitby: Use home-manager from nixpkgs * tazjin/frog: drop Sourcetrail (it doesn't build currently) Note that in addition to these changes, some previous CLs updated the versions of git and cgit which was necessary for this channel bump, but which could not be done in the same commit due to the nature of the subtree merges. Change-Id: If2563e8a68e2750c4b913a976ff7b93b42e8b7f3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2110 Tested-by: BuildkiteCI Reviewed-by: multi <depot@in-addr.xyz> Reviewed-by: glittershark <grfn@gws.fyi>
2020-11-21 r/1893 fix(glittershark/kernel): Ensure kernel changes cachebust linux-ckVincent Ambo1-0/+1
Previously changed kernel versions would not cachebust the patch download, because it would still be using the same SHA hash. Forcing a different store path (by adding the version to the name) also forces a redownload of the patch (and in turn cause the hash to mismatch), avoiding this as a silent cause of failures in channel updates. Change-Id: I81a136ee2401126795cf042b0aadf2a1e7a707b4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2114 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-11-21 r/1892 fix(3p/cgit): Rename remaining 'sha1' references to 'oid'Vincent Ambo1-2/+2
This changed upstream & upstream-upstream, but was still used in our patches. Change-Id: Id33f868a4f188deb3348425276bc5b4c4b36aff9
2020-11-21 r/1891 merge(3p/cgit): subtree merge at adcc4f82Vincent Ambo26-135/+299
Change-Id: I16941629a17a2f39b9324cb85dc0cec6b104dfe4
2020-11-21 r/1890 merge(3p/git): Merge git subtree at v2.29.2Vincent Ambo1485-100645/+232762
This also bumps the stable nixpkgs to 20.09 as of 2020-11-21, because there is some breakage in the git build related to the netrc credentials helper which someone has taken care of in nixpkgs. The stable channel is not used for anything other than git, so this should be fine. Change-Id: I3575a19dab09e1e9556cf8231d717de9890484fb
2020-11-21 r/1889 merge(3p/absl): subtree merge of Abseil up to e19260fVincent Ambo854-5218/+11182
... notably, this includes Abseil's own StatusOr type, which conflicted with our implementation (that was taken from TensorFlow). Change-Id: Ie7d6764b64055caaeb8dc7b6b9d066291e6b538f
2020-11-21 r/1888 chore(tvix): Use StatusOr API available in Abseil's versionVincent Ambo4-8/+13
The Abseil version of `StatusOr` does not come with the status macros or the `Consume*` family of functions. This change modifies the existing code to use the common denominator of the API that is available between Abseil's own implementation of `StatusOr` and the one from Tensorflow that we are currently using. Change-Id: I5c37f68636a1fd54d153f95d7303ab8644abb774
generated by cgit-pink 1.4.1 (git 2.44.2) at 2024-11-09T11·18+0000