about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
2020-08-01 r/1529 feat(3p/nix): Implement a few more RPC callsGriffin Smith3-3/+59
Implement the RPC client calls for QueryPathFromHashPart, QuerySubstitutablePaths, and QuerySubstitutablePathInfos, and the handler for QuerySubstitutablePathInfos. Refs: #29 Change-Id: Idf383b771f159f267d8f65367bc4af3d239e32b7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1515 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com>
2020-08-01 r/1528 fix(3p/nix/libexpr): fix GC tracing in valueSizeKane York2-26/+29
Change-Id: I2f6bef7b090d44f50bd27fbd19b50f9cf100b238 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1506 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in>
2020-08-01 r/1527 feat(3p/nix): remove External values featureKane York5-113/+10
External values are only useful when using the plugin framework, which we are not interested in carrying forward. Reverts commit 320659b0cd161249c95e736c3fb309b1a73ea728 Change-Id: Ib4929c349bbb33f16224fc674e94c7b7d5953c6a Reviewed-on: https://cl.tvl.fyi/c/depot/+/1505 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in>
2020-08-01 r/1526 fix(3p/nix): Use a proper pointer in Env to carry with-attrsKane York2-5/+9
This eliminates the value-smuggling that would trip up the GC. Change-Id: I8057df78cf0bf6bea9faf1b44233aa9820ae44f5 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1504 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in>
2020-08-01 r/1525 chore(3p/nix/libexpr): Cleanups and notes in eval.ccKane York2-3/+17
Add two more garbage-collection flags. Annotate how terrible tExternal is. Prepare to fix the smuggle casting in ExprWith. Add a static_cast. Change-Id: I20f980abc8cb192e094f539185900a6df5457c29 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1503 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in>
2020-08-01 r/1524 feat(gs/emacs): Use semantic imenu in cpp buffersGriffin Smith1-0/+5
Change-Id: Icec8ddb8230102286510d6af025bf19cdb33d0d0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1542 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-01 r/1523 feat(whitby): Enable daily PostgreSQL backupsVincent Ambo1-0/+7
... daily is just the default cron pattern for this, but we might also want this to happen more frequently. Not sure yet. Change-Id: I4e433fefebd93488891e765b5842fdb6537e3c6d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1518 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com>
2020-08-01 r/1522 fix(gerrit): Don't do a deep fetchLuke Granger-Brown1-4/+2
I don't know what I was smoking. Change-Id: I650777bbbd24a1922f26967fbbd7da06d14b6781 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1514 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-01 r/1521 feat(tazjin/frog): Install screen & xsecurelockVincent Ambo1-0/+2
rather than using nix-shell each time ... Change-Id: If84a84bca4ed892d0d38c5dcfc23a073cbb89e64 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1512 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-08-01 r/1520 chore(tazjin): Move wallpapers into my user folderVincent Ambo22-0/+0
Change-Id: I30901967ff0d65ae4a12a5b74c3baec9a6406971 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1511 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-08-01 r/1519 feat(3p/nix): Implement AddToStore proto handlerGriffin Smith7-13/+141
Implement the proto handler for AddToStore, which adds a nix path to the store. This is implemented by adding a new (probably soon-to-be-generalized) Source concretion that wraps a grpc ServerReader for the stream of data we're receiving from the client - this is less than ideal, as it's perpetuating the source/sink thing that's going on and storing entire nars in memory, but is at the very worst an incremental step towards a functioning nix that we can refactor in the future. Paired-With: Perry Lorier <isomer@tvl.fyi> Paired-With: Vincent Ambo <mail@tazj.in> Change-Id: I48db734e7460a47aee4a85dd5137b690980859e3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1441 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: tazjin <mail@tazj.in>
2020-08-01 r/1518 fix(ops/paroxysm): Ensure paroxysm is started on bootVincent Ambo1-0/+1
Change-Id: Iba6557cbf4e0001277bd996df59318b4308fc92e Reviewed-on: https://cl.tvl.fyi/c/depot/+/1510 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-01 r/1517 fix(web/panettone): Don't try to markdownify eventsGriffin Smith1-3/+3
Events - which are interleaved with comments - don't have bodies, so they can't be converted to markdown. Change-Id: Iba818b95dab59cae5a08c8b4eca94955e11e584b Reviewed-on: https://cl.tvl.fyi/c/depot/+/1509 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-08-01 r/1516 fix(3p/nix/hash): param of Unknown allows any hash typeKane York1-1/+6
Fixes a crash in the self-hosting instantiate test: NIX_REMOTE="$(mktemp -d)" nix-instantiate -E 'let depot = import ./default.nix {}; in depot.third_party.nix.outPath' Change-Id: If99494aa07ec248d3894d4709ab0fde7fa81aff3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1508 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-08-01 r/1515 chore(3p/nix/hash): prefer StatusOr over throwing constructorKane York15-49/+97
The use of `unwrap_throw` can be used as a later grep target. Change-Id: I8c54ed90c4289f07aecb8a1393dd10204c8bce4e Reviewed-on: https://cl.tvl.fyi/c/depot/+/1493 Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-08-01 r/1514 fix(3p/nix/hash): initialize HashSink.ctxKane York2-1/+22
Fixup for CL 1492 (addcba11b05500ba28ade309de6bd53f8153a6c4) Additionally, add a test to verify functionality of HashSink. Change-Id: I2a74b925a1b93ed4d3add29021d759c93e813424 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1507 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-31 r/1513 feat(ops/nixos): Add module for running paroxysm on whitbyVincent Ambo2-0/+29
Change-Id: I415e3b046d4e0fcd7e800ddab0c7f1aeb639c5e2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1502 Tested-by: BuildkiteCI Reviewed-by: eta <eta@theta.eu.org>
2020-07-31 r/1512 feat(owothia): I'm a noun, owoGriffin Smith1-24/+47
Change-Id: I793c2c011a12c82d45fab6f72a9578ee07878762 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1501 Tested-by: BuildkiteCI Reviewed-by: eta <eta@theta.eu.org>
2020-07-31 r/1511 feat(web/panettone): Render issues+comments as MarkdownGriffin Smith3-4/+64
Use the new cheddar markdown endpoint to render issue bodies and comment bodies as JSON. I've checked, and this *also* appears to be XSS safe (yay) Change-Id: Ib4b19fd581b0cf40ba03f5d13443535d17df6632 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1500 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-07-31 r/1510 feat(web/panettone): Display issue historyGriffin Smith6-35/+94
Display the history of an issue (which currently is just opening and closing) inline with the issue's comments on the issue show page Change-Id: Id167bceef765cb4c24e86983d1dcd6624d0e5956 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1497 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-31 r/1509 feat(web/panettone): Log when users change issue statusesGriffin Smith7-112/+215
Log in the database, in a way that will generalize to tracking edit history as well, when users change the status of an issue. To facilitate easily knowing who is currently authenticated (without introducing a circular dependency) the authentication-relaated code has also been factored out into its own package, which is nice because we want to replace that sooner rather than later anyway. Fixes: #13 Change-Id: I65a544fab660ed1c295ee8f6b293e0d4945a8203 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1496 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-31 r/1508 feat(web/panettone): persist original-uri through failed authGriffin Smith1-1/+2
Even if the user fails to log in, maintain the original-uri param if present, so that if they eventually succeed at logging in they still get where they were originally trying to get. Change-Id: I2faa5eced002ab899c803cf19095cea76897d92d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1499 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-31 r/1507 feat(web/panettone): Redirect to original URL after loginGriffin Smith1-1/+6
Add an original-uri query param to the target of the Log In link pointing at the current URL, so that when the user eventually successfully logs in they are redirected to the page they were originally on Fixes: #21 Change-Id: I75ed7b75fa00b1b09c8b26bf4dcf5bc6b6d7f53a Reviewed-on: https://cl.tvl.fyi/c/depot/+/1498 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-29 r/1506 fix(3p/nix/hash): smart pointers in HashSinkKane York2-17/+18
Change-Id: Ib2aaf42c8b234ee343c4653eb03f328c113dea86 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1492 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-29 r/1505 refactor(web/panettone): Remove prevalenceGriffin Smith4-115/+4
Now that we've migrated over all the data to postgresql, we can get rid of cl-prevalence as a dependency from Panettone along with all code that mentions it. Change-Id: I945f50a88fea5770aac5b4a058342b8269c0bea2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1495 Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-07-28 r/1504 fix(3p/nix/hash): provide a Status-returning constructorKane York5-52/+123
Additionally, add IsValidBase16() to restore the behavior of rejecting invalid base16, which absl's HexStringToBytes does not do. Change-Id: I777a36f5dc787aa54a2aa316d6728f68da129768 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1484 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-28 r/1503 chore(3p/nix/hash): eliminate exposed global variableKane York3-38/+61
Change-Id: I3b34e3e17a751e225831ae599c6c6bb782a25679 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1486 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-28 r/1502 feat(ops/nixos): Use database password for PanettoneGriffin Smith2-6/+18
It appears this didn't even *work* without a password, so we've been forced into being more secure. Change-Id: I4ff9d04961a703a85299dafb79e8447b0a933fc1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1491 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-28 r/1501 fix(web/panettone): Fix reference to undefined functionGriffin Smith1-1/+1
I have been. Very tired. Change-Id: Iab9d21e53630be092080cc73196da90534b06553 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1490 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-28 r/1500 fix(ops/nixos): allow connections on hostnosslGriffin Smith1-0/+1
This is how panettone is currently connecting, so this needs to be here in order for it to work. Shortly I'll update all of this to use passwords, but for now this gets things up and running again Change-Id: If87f4dbce0800dcbc4f7bf10e88f3e591410b416 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1488 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-28 r/1499 chore(3p/nix/hash): add decoding testsKane York1-0/+19
Change-Id: Ifbeaf1822fa920f929482510ee79a5b24d7976ae Reviewed-on: https://cl.tvl.fyi/c/depot/+/1485 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-28 r/1498 fix(panettone): Add missing util.lisp to buildGriffin Smith1-0/+1
Change-Id: Id2fdd84145712d75f23844ad1ececa835cec6a84 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1487 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-07-28 r/1497 feat(panettone): Use postgres as the storage backendGriffin Smith5-116/+394
Switch from cl-prevalence to postgres (via postmodern) as the storage backend for panettone. The first time the application starts up after this commit, it will (idempotently) initialize the db schema and migrate over all data from the prevalence snapshot to the database - the plan is then to get rid of the prevalence classes and dependency once that's deployed. Change-Id: I4f35707efead67d8854f1c224ef67f8471620453 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1467 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: eta <eta@theta.eu.org>
2020-07-27 r/1496 chore: Move //fun/tvldb -> //fun/paroxysmVincent Ambo18-9/+10
Say ~my~ its name! Change-Id: I7890318aef984af0f6bc011de32282f16e01cbb3 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1483 Tested-by: BuildkiteCI Reviewed-by: eta <eta@theta.eu.org>
2020-07-27 r/1495 fix(3p/nix): apply all clang-tidy fixesKane York65-497/+580
Change-Id: I265e763393422ee1881653527c91024458060825 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1432 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-27 r/1494 feat(whitby): Create a Postgres database for PanettoneGriffin Smith2-1/+70
Create a running Postgres database server along with a user and database for Panettone, and pass configuration for it to the panettone module Change-Id: I333994288131be328e62069382d6d40f8034c400 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1466 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-27 r/1493 fix(3p/nix): convert local-store asserts into throwsKane York1-13/+12
This fixes a clang-tidy DeadStore warning by turning debug asserts into production checks. Updates: #11 Change-Id: Ia6e5a4cb1b56594c9844c6bbd3d152f84b426d09 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1409 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-27 r/1492 feat(nix/buildLisp): Add abstraction for test suitesGriffin Smith2-50/+142
Add support for explicitly specifying tests as part of a buildLisp program or library. Change-Id: I733213c1618f0fa60f645465560bce0522641efd Reviewed-on: https://cl.tvl.fyi/c/depot/+/1481 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-27 r/1491 feat(3p/lisp): Add checklGriffin Smith2-0/+46
Change-Id: Ib73ed9637b7e22050727ac5ec117241e18d3cc45 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1472 Tested-by: BuildkiteCI Reviewed-by: eta <eta@theta.eu.org>
2020-07-27 r/1490 chore(monorepo-gerrit): add Checks plugin to Gerrit moduleLuke Granger-Brown1-0/+1
This adds the Gerrit checks plugin. Hooray. Change-Id: I784e9728256d1665b85b666d58bc0308bd6614ed Reviewed-on: https://cl.tvl.fyi/c/depot/+/1463 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-27 r/1489 feat(3p/gerrit_plugins): init Gerrit checks pluginLuke Granger-Brown2-0/+14
The Gerrit Checks plugin adds a new tab to the Gerrit UI, which is intended for display of status of automated checks which are being run. We can use this for e.g. reporting the run status of our CI builds/other stuff. Change-Id: Ib0d9a8ae68061a76191a56d467d915100b766e1b Reviewed-on: https://cl.tvl.fyi/c/depot/+/1462 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-27 r/1488 chore(3p/gerrit_plugins): add machinery for compiling Gerrit plugins from sourceLuke Granger-Brown4-10/+58
This looks particularly obnoxious for the owners plugin, because it's actually two plugins with a common library in the same repo. Other plugins are much cleaner to deal with (hence the default for overlayPluginCmd). Change-Id: Ibb9588c8a29b63e8509436fcbb70054e89349712 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1461 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-07-26 r/1487 fix(nix/buildLisp): Set LANG to C.UTF-8 on program buildsGriffin Smith1-0/+1
This was already happening for libraries, but not for programs - as a result, programs built with libraries that contained unicode (eg cl-unicode, uax-15, ...) would fail to build due to character encoding issues when loading the FASLs. Change-Id: I66149b585e85b213d0c026153140a1925536bd29 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1469 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-26 r/1486 feat(web/panettone): Add dev helpers for postgres dbGriffin Smith4-0/+28
Add a docker-compose file and lorri-based direnv for aiding in running and connecting to a postgres database during development of panettone. Change-Id: I319eee52b52cd48e1f3d2e32c558989768dc19d8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1465 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: eta <eta@theta.eu.org>
2020-07-26 r/1485 feat(3p/lisp): Add postmodernGriffin Smith4-0/+228
Change-Id: If6ffd9a2344dc98e95312ddcce14ba5c2519d004 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1420 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-07-26 r/1484 fix(web/panettone): Don't log backtracesGriffin Smith1-0/+2
The default hunchentoot behavior is to log all local variables when logging lisp backtraces - this is nice for debugging, but means that if we hit an error when checking for auth with the ldap server we log the password provided by the user. No good! Let's just turn off logging of backtraces for now. Change-Id: Ibc4242e3e0f974ac53fffc482d3724b0547425ab Reviewed-on: https://cl.tvl.fyi/c/depot/+/1471 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-07-26 r/1483 feat(3p/lisp): Add ironcladGriffin Smith2-0/+172
Add ironclad, a common lisp library for cryptography. This is a huge library with a lot of moving parts - probably most notable here is that I've had to turn off compiling with `:ironclad-assembly`, as it was causing an infinite loop in the compiler due to https://github.com/sharplispers/ironclad/blob/master/src/opt/sbcl/cpu-features.lisp#L9-L10, a mutually self-recursive function that looks like: (defun aes-ni-support-p () (aes-ni-support-p)) Without knowing much about how sbcl handles native-compiled assembly, it seems like this definition should actually be skipped entirely, due to it being defined as a `defknown` in `fndb.lisp`: (defknown ironclad::aes-ni-support-p () (boolean) (any) :overwrite-fndb-silently t) But something about how we're compiling things was causing that not to happen, and the infinite recursion caused the compiler to hang. This should be fixed at some point, but given I only need this library as a transitive dependency down a level I'm not going to attempt to do so now. Change-Id: Id768717991404f959b003c7e2f28f1f4d532b94b Reviewed-on: https://cl.tvl.fyi/c/depot/+/1333 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com>
2020-07-26 r/1482 chore(3p/lisp): Add eta & glittershark to OWNERSVincent Ambo1-0/+5
Change-Id: I372d84b2fa979059bda14264b23f9c11adaf4222 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1470 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-07-26 r/1481 chore(web/panettone): ignore .fasl filesGriffin Smith1-0/+1
Sly spits these out as a result of the various compile commands, but we don't want them committed. Change-Id: I6f45b6de6dc978667a0575d0ed361c573045ef92 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1464 Reviewed-by: kanepyork <rikingcoding@gmail.com> Tested-by: BuildkiteCI
2020-07-26 r/1480 docs(REVIEWS): recommend remote.origin.push configKane York1-1/+14
Change-Id: I090841101b9ee0295aabb2097f953bf149f39a9d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1403 Tested-by: BuildkiteCI Reviewed-by: lukegb <lukegb@tvl.fyi>
generated by cgit-pink 1.4.1 (git 2.44.2) at 2024-11-08T13·56+0000