about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
2020-08-21 r/1699 fix(tvix): Add newlines to build logsVincent Ambo1-2/+2
.. turns out producing an entire build log on a single line is not useful. This does not use `<< std::endl` because we have run into buffering issues with the implementation of the logs->gRPC sink, but intend to replace this in the future using a structured sink for BuildEvent protos rather than a raw stream. Change-Id: Ia9b05fa804391d389e2ef53ab4436c0ec5cc452e Reviewed-on: https://cl.tvl.fyi/c/depot/+/1828 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-21 r/1698 refactor(tvix): Replace several DiscardLogsSink() with std::cerrVincent Ambo7-24/+15
Introduces the actual log sink in several places where we actually want the build logs to thread through correctly. This should cover *most* build paths. Change-Id: I735dff8a79f7e35a5874eb89b4abb980f9703dc2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1827 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-21 r/1697 feat(tvix): Write build logs into the build log sinkVincent Ambo1-3/+4
This *should* wire up the builder's logs all the way back through the gRPC client, where they are then conveniently discarded. Change-Id: I65f22526d0b5a8b8d90f28665bc1b4bc7f7c802a Reviewed-on: https://cl.tvl.fyi/c/depot/+/1825 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-21 r/1696 chore(tvix): Thread std::ostream through builder goalsVincent Ambo1-42/+66
This passes an output stream for build logs to almost all relevant functions inside of build.cc by threading it through the `Goal`-abstraction. Store calls that create goals but don't have a sink available use the DiscardLogsSink(). Change-Id: I2c0cb1aec1f9150f33113f4752055cea518ede8b Reviewed-on: https://cl.tvl.fyi/c/depot/+/1824 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-21 r/1695 chore(tvix): Add TODO comment for std::ostream in buildDerivationVincent Ambo1-0/+1
Change-Id: I1e3b6abd4606d86f00ddaa8e2a1809f51e27126d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1823 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-21 r/1694 style(tvix): Move a comment to fix a formatting issueVincent Ambo1-4/+3
Change-Id: Idd490b978c07d1b1113ee97b5d19719a27436fba Reviewed-on: https://cl.tvl.fyi/c/depot/+/1822 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-20 r/1693 feat(gs/emacs): Make forge popups 0.75 heightGriffin Smith1-0/+5
Change-Id: I019d9fc3846a66690b946fb3a0213881697d9caf Reviewed-on: https://cl.tvl.fyi/c/depot/+/1821 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-20 r/1692 refactor(gs/emacs): Make slack popups take up half the windowGriffin Smith1-1/+1
Only having a third has left me feeling like I need a little more space. Change-Id: I9424ec8bf2eeb55a62f21dd72b5ee6251670b0b4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1800 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-20 r/1691 feat(gs/emacs): Add capture template for windtunnelGriffin Smith1-0/+3
Change-Id: I6c9079318f13746d50d239dc0ca86a0f86a5920d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1799 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-20 r/1690 feat(gs/emacs): Tweak slack configGriffin Smith2-15/+32
Disable the prompt for sending thread replies to the channel, tweak the slack popup buffer settings, add some bindings, and move all the slack config to its own file. Change-Id: I670394942bd9b7e4cfc22953227c21d50a315c22 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1798 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-20 r/1689 chore(tvix): Thread a std::ostream through Store::buildPathsVincent Ambo15-43/+63
This part of the store API needs to carry a handle to the log sink from now on, so that it can be passed in as appropriate from the gRPC handlers. In all places where there is no such handler available at the moment, the discarding log sink has been inserted. This can be used as a convenient grep target in the future. Change-Id: I26628e30b4c6437dccdf8f722ca2e8ed827dfc19 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1797 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-20 r/1688 style(tvix): typedef -> using in build.cc/store-api.hhVincent Ambo2-18/+17
this shuts up a few lints ... Change-Id: I51ee9418767e97247f98b170cdad137e5b12b44d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1796 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-20 r/1687 refactor(tvix): Remove some default values from virtual methodsVincent Ambo2-6/+18
This is not actually legal code, but it kind of ... works. There are more of these around, these were just the ones Griffin stumbled upon while working on the build logs. Change-Id: Iff9821d8fe145dd426648a8ff4510a73f67c9b7d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1795 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-20 r/1686 feat(tvix): Implement std::streambuf for a build log -> gRPC sinkGriffin Smith1-0/+18
Introduces a class which implements std::streambuf by sending build log lines to the provided gRPC stream writer as individual messages. This can be used in the implementations of calls which trigger builds to forward logs back to the clients. Change-Id: I3cecba2219cc24d56692056079c7d7e4e0fc1e2c Reviewed-on: https://cl.tvl.fyi/c/depot/+/1794 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-20 r/1685 feat(tvix): Introduce build event streams in worker protocolVincent Ambo5-25/+92
Introduces a new `BuildEvent` proto type which is streamed in response to calls that trigger builds of derivations. This type can currently supply build statuses, log lines and information about builds starting. This is in preparation for threading build logs through the processes. Since we have nowhere to send the logs (yet), a null sink is used instead. Co-authored-by: Griffin Smith <grfn@gws.fyi> Change-Id: If7332337b89506c7e404cd20174acdaa1a3be4e8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1793 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: kanepyork <rikingcoding@gmail.com>
2020-08-20 r/1684 feat(tvix): Add a no-op stream buffer for discarding build logsVincent Ambo2-0/+19
In some cases we don't have anywhere for the build logs to go. Until we understand those cases fully and can get rid of them, this null sink implementation can be used. Change-Id: Ib93c43caf268e2c01c43d59737a829e8c43d223e Reviewed-on: https://cl.tvl.fyi/c/depot/+/1792 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-20 r/1683 feat(tools/depot-scanner): init projectKane York6-2/+282
depot-scanner is a tool that runs Nix and parses the --trace-file-access output to deduce what files are necessary to evaluate a derivation. Take DEPOT_ROOT from the environment. If depotRoot doesn't exist, print an error early. Fix the build of the protobuf library. Switch to the GRPC build rule, as a service is in this proto file. Create the PathType enum and parse it from cmdline flags. Change-Id: I537b5c6bceecf76ca510f7ac04ab9dad7785feb1 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1769 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in> Reviewed-by: lukegb <lukegb@tvl.fyi>
2020-08-19 r/1682 chore(3p/loxy): add OWNERSedef1-0/+3
Change-Id: I054711b07307ce9c0b3ce0f85319e58616db3639 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1790 Tested-by: BuildkiteCI Reviewed-by: V <v@anomalous.eu> Reviewed-by: tazjin <mail@tazj.in>
2020-08-19 r/1681 feat(tools/tvlc): init projectKane York5-0/+171
tvlc is a tool for managing sparse git worktrees of the TVL depot. It is still in development; near-term tasks include a setup script, Nix dependency resolution, worktree removal, and the dispatch script. See cs.tvl.fyi/depot/docs/designs/SPARSE_CHECKOUTS.md for more info. Change-Id: Iad96656f0206178980fe7dcadd3dffe70d690f8f Reviewed-on: https://cl.tvl.fyi/c/depot/+/1760 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-08-19 r/1680 chore(tvl-slapd): decapitalise V's username, use displayName insteadV2-2/+3
Change-Id: I59cf5e1c850960ae639c6a3ebeb273a4441c48bb Reviewed-on: https://cl.tvl.fyi/c/depot/+/1788 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: tazjin <mail@tazj.in>
2020-08-19 r/1679 feat(whitby): add VV3-0/+16
Change-Id: I887760edd67135df4e2f58a874314b317838d2e8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1787 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-08-19 r/1678 feat(tvl-slapd): add VV1-0/+5
Change-Id: Id9253635b73b0eac7871a6baa4f0c7417d135cfe Reviewed-on: https://cl.tvl.fyi/c/depot/+/1786 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-08-19 r/1677 fix(tazjin/emacs): Use 'Semi Light' font weight on frogVincent Ambo1-1/+10
The font weight rendering issue on frog is, for now, undefeatable and I'm resorting to just using a lighter font base weight which makes it possible to actually see bold things. Change-Id: Ida10f2e8d728039c9ab76bfab1fd0d36340fbac7 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1785 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
2020-08-18 r/1676 revert(3p/loxy): Add link to source repositorykanepyork1-1/+0
This reverts commit 4d113ae9f91acd167e4ab739025911ead66b7f2a. Reason for revert: Source repository link has been added to the homepage Change-Id: I21667fab928621ba8973c8598d01920ecbf512ef Reviewed-on: https://cl.tvl.fyi/c/depot/+/1801 Reviewed-by: lukegb <lukegb@tvl.fyi> Tested-by: BuildkiteCI
2020-08-18 r/1675 chore(3p/emacs): Enable cairo for Emacs 27.1Vincent Ambo1-1/+4
... this in turn enables support for Harfbuzz, which enables support for ligatures - maybe this will make grfn happy! Change-Id: I331c5171a829800fe532ca0b0d4910478e63ef1b Reviewed-on: https://cl.tvl.fyi/c/depot/+/1783 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-18 r/1674 fix(tvix/config): properly handle nonexistent config filesKane York1-2/+7
If the global nix config, or any available user nix config location, does not exist, then the loadConfFile() function will throw and not finish initalizing the Nix configuration. Change-Id: I6db83bca54d9b66699356d107720603476e32c23 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1657 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-18 r/1673 feat(tvix): Re-enable language tests that needed a storeKane York14-9/+59
Now that we have access to a store in tests, we can enable the tests that needed a store. Additionally, move the expected output files for disabled tests into the disabled folder. Change-Id: I2492d49d43b93c7c9b0463e4d3d2855a5a51365d Reviewed-on: https://cl.tvl.fyi/c/depot/+/1758 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-18 r/1672 chore(tvix/tests): port upstream add.sh testKane York1-0/+30
Change-Id: I5151d142d6b2b7f1df37b170b0160b8f77a89120 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1755 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-18 r/1671 chore(tvix/tests): Add OpenTemporaryStore() helperKane York2-7/+74
Change-Id: Ia655175c255f9cf5a47e4e7a20373a4ba4315ed9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1753 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-17 r/1670 feat(whitby): add etaeta3-0/+20
Change-Id: I7aa2bd2cb2c001b48ebd25b20f28cdfb0883ba3f Reviewed-on: https://cl.tvl.fyi/c/depot/+/1782 Tested-by: BuildkiteCI Reviewed-by: isomer <isomer@tvl.fyi> Reviewed-by: tazjin <mail@tazj.in>
2020-08-17 r/1669 docs: Update README for the repository itselfVincent Ambo3-50/+81
Adds a lot more information about what is actually going on here, as well as links to relevant things such as our Monorepo document. I'm aware that I didn't make all `//...` links clickable, but I realised at some point that it might be easier to just update cheddar to support highlighting those natively :-) Change-Id: Icbb212a6c07a5cf38ab8e65d83a64bec783eb8d0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1768 Tested-by: BuildkiteCI Reviewed-by: isomer <isomer@tvl.fyi> Reviewed-by: kanepyork <rikingcoding@gmail.com>
2020-08-17 r/1668 chore(nixos/sourcegraph): Bump version to 3.18.0Vincent Ambo1-1/+1
Change-Id: I5cb8b2da7e40075c99fab6bd57295c8c1d770e86 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1781 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com>
2020-08-17 r/1667 feat(nixos/clbot): Add ability to post in multiple channelsVincent Ambo2-13/+41
Adds the ability to post to multiple channels by simply running multiple instances of clbot. We should probably implement support for this in clbot itself, but right now I can't be bothered to write Go. Change-Id: I5cffd0dc10a7f6cc19c37c5834c5610166b4ae23 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1771 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com> Reviewed-by: lukegb <lukegb@tvl.fyi>
2020-08-17 r/1666 chore(tazjin/emacs): Bump my personal Emacs to 27.1Vincent Ambo1-2/+2
Change-Id: Ib7e9ac97830427b962b02cd5ea6151a67c387936 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1765 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-08-17 r/1665 chore(3p): Provide Emacs 27.1Vincent Ambo1-0/+9
This is now available in the upstream channel, and I need it on one machine for $reasons. Normally the Emacs attribute is versioned to make it clear which version we're dealing with, but not in this case. I've added an assert to check that it is indeed 27. Change-Id: I827df0d36350066bf4e177150d32af0c8d123b9b Reviewed-on: https://cl.tvl.fyi/c/depot/+/1764 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-17 r/1664 fix(gws.fyi): use www subdomainGriffin Smith1-5/+5
Change-Id: I2ff2d8cf8d2c9138497fb3fdbaed62300057b1ba Reviewed-on: https://cl.tvl.fyi/c/depot/+/1767 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-17 r/1663 feat(gs/emacs): Extract lisp configGriffin Smith3-7/+42
Change-Id: I278c79e6e59c18c2f0e2d5307eefd9ff3c92a4be Reviewed-on: https://cl.tvl.fyi/c/depot/+/1766 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-17 r/1662 chore(3p): Bump nixos-unstable channelVincent Ambo3-9/+27
This bumps the channel to a commit that includes fixes for an nginx issue we have been seeing: https://github.com/NixOS/nixpkgs/pull/95264 Includes the following compatibility fixes: - tests disabled in third_party.bufbuild: These were enabled unexpectedly by the update, but don't run in the sandbox because they want to download things from github Change-Id: I98a3b5de57f62f1fd3a37701fa1896eddeedff85 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1759 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in>
2020-08-17 r/1661 feat(glittershark/kernel): Use linuxPackages_latestVincent Ambo1-4/+4
Welcome to the future, baby! Change-Id: I23124d27df1f7597dbd2b28afd5882e62085665e Reviewed-on: https://cl.tvl.fyi/c/depot/+/1763 Reviewed-by: glittershark <grfn@gws.fyi> Tested-by: BuildkiteCI
2020-08-17 r/1660 refactor(glittershark/chupacabra): Move boot config into a blockVincent Ambo1-11/+18
This is kind of difficult to read otherwise because the boot configuration is scattered throughout the file. Change-Id: I8977b1bd2b9162c898c96aa249c40749b3d46180 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1762 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-17 r/1659 chore(3p/loxy): Add link to source repositoryVincent Ambo1-0/+1
This is not obvious otherwise. Change-Id: Ic07993a58e545345dae4529d281d6fdae35c19aa Reviewed-on: https://cl.tvl.fyi/c/depot/+/1761 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-17 r/1658 refactor(tvix): always pass Bindings by ptr, use shared/unique_ptrKane York22-103/+125
Value now carries a shared_ptr<Bindings>, and all Bindings constructors return a unique_ptr<Bindings>. The test that wanted to compare two Bindings by putting them into Values has been modified to use the new Equal() method on Bindings (extracted from EvalState). Change-Id: I8dfb60e65fdabb717e3b3e5d56d5b3fc82f70883 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1744 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi> Reviewed-by: tazjin <mail@tazj.in>
2020-08-17 r/1657 refactor(tvix): add explicit copy/move constructors for ValueKane York3-0/+129
This is in preparation for making some of Value's members into refcounted ('smart') pointers. Change-Id: Ibc54e23ac35766a2fd4e14871c9a7c936a603778 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1743 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-15 r/1656 chore(3p): Remove telega derivationVincent Ambo1-22/+0
The upstream telega.el derivation (under emacsPackages) now includes the server component. Change-Id: I49d85ea16d2fce10a505e2459fcd396706e39923 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1748 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-15 r/1655 fix(tvix): Ensure prim_sort actually uses the right outlistVincent Ambo2-4/+5
Previously the outlist would not be used, and it would sort god knows what in the out value. This was probably introduced by the std::vector refactoring, and the language test for builtins.sort was disabled. Whatever reason there was for disabling it seems to be gone, so we're re-enabling it. Change-Id: I98941c2cad78df58ff7bea1ece3aaa4133e94bf8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1757 Reviewed-by: kanepyork <rikingcoding@gmail.com> Tested-by: BuildkiteCI
2020-08-15 r/1654 feat(tvix/tests): add gtest matchers for absl::StatusKane York1-0/+83
This allows you to write EXPECT_OK(statusor), as well as EXPECT_THAT(status, IsStatusCode(StatusCode::kInvalidArgument). Change-Id: I53bed694d812c501eb305ed4ddb358e1f9a68277 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1704 Tested-by: BuildkiteCI Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-15 r/1653 fix(tazjin/emacs): Completely disable vc-modeVincent Ambo1-0/+8
vc-mode is somehow broken in this newer version of Emacs and, since it is part of the default find-file-hook, breaks pretty much everything. This disables all vc backends until I figure out what's going on. Change-Id: I104cd30d6c56f3d6423ac079b1427127bf5a1038 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1752 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-08-15 r/1652 chore(3p): Pick Emacs & friends from the default channelVincent Ambo1-9/+6
I had previously pinned Emacs to the (older) stable channel, because of a heretofore undiagnosed issue in newer versions. It turns out that the older Emacs is linking against X11-related libraries, namely <unintelligible>, which cause even *weirder* undiagnosed issues if paired with the rest of the recent packages. This commit removes the exception for Emacs and just picks it from the same channel as everything else. Change-Id: Ifce21c99f0204d4cf131bacb366dd9617fc301b8 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1751 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-08-14 r/1651 feat(whitby): enable programs.mosh.multi1-0/+1
Change-Id: Ibc8df6f6382b5b64e272bedece6b65762f9693c9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1750 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
2020-08-14 r/1650 refactor(tazjin/emacs): Use telega.el from unstable channelVincent Ambo1-2/+7
This removes the need for supplying a locally built telega-server binary, as the new upstream derivation includes this. It also ensures that the frontend/backend are synchronised, which I think has been causing some issues on vauxhall. Change-Id: If504624e607a24fa12d68516cde65fef25ed2838 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1749 Tested-by: BuildkiteCI Reviewed-by: tazjin <mail@tazj.in>
generated by cgit-pink 1.4.1 (git 2.44.2) at 2024-11-24T12·16+0000