about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorFilesLines
2014-03-29 Drop pointless #includeEelco Dolstra1-2/+0
2014-03-29 Fix potential segfault in waitForInput()Eelco Dolstra1-3/+5
Since the addition of build-max-log-size, a call to handleChildOutput() can result in cancellation of a goal. This invalidated the "j" iterator in the waitForInput() loop, even though it was still used afterwards. Likewise for the maxSilentTime handling. Probably fixes #231. At least it gets rid of the valgrind warnings.
2014-03-29 restoreSIGPIPE(): Fill in sa_maskEelco Dolstra2-1/+2
Issue #231.
2014-03-28 Don't interpret strings as format stringsEelco Dolstra3-23/+32
Ludo reported this error: unexpected Nix daemon error: boost::too_few_args: format-string refered to more arguments than were passed coming from this line: printMsg(lvlError, run.program + ": " + string(err, 0, p)); The problem here is that the string ends up implicitly converted to a Boost format() object, so % characters are treated specially. I always assumed (wrongly) that strings are converted to a format object that outputs the string as-is. Since this assumption appears in several places that may be hard to grep for, I've added some C++ type hackery to ensures that the right thing happens. So you don't have to worry about % in statements like printMsg(lvlError, "foo: " + s); or throw Error("foo: " + s);
2014-03-21 Make /dev/kvm optionalLudovic Courtès1-1/+4
The daemon now creates /dev deterministically (thanks!). However, it expects /dev/kvm to be present. The patch below restricts that requirement (1) to Linux-based systems, and (2) to systems where /dev/kvm already exists. I’m not sure about the way to handle (2). We could special-case /dev/kvm and create it (instead of bind-mounting it) in the chroot, so it’s always available; however, it wouldn’t help much since most likely, if /dev/kvm missing, then KVM support is missing.
2014-03-18 Fix tabsEelco Dolstra1-6/+6
2014-03-18 Allow recovery from isValidPath RPCs with an invalid pathLudovic Courtès1-1/+7
Currently, clients cannot recover from an isValidPath RPC with an invalid path parameter because the daemon closes the connection when that happens. More precisely: 1. in performOp, wopIsValidPath case, ‘readStorePath’ raises an ‘Error’ exception; 2. that exception is caught by the handler in ‘processConnection’; 3. the handler determines errorAllowed == false, and thus exits after sending the message. This last part is fixed by calling ‘startWork’ early on, as in the patch below. The same reasoning could be applied to all the RPCs that take one or more store paths as inputs, but isValidPath is, by definition, likely to be passed invalid paths in the first place, so it’s important for this one to allow recovery.
2014-03-17 Fix -j and other flags when using the daemonEelco Dolstra1-6/+6
2014-03-17 nix-build: Fix --cores flagEelco Dolstra1-1/+1
2014-03-12 Remove unnecessary null pointer checksEelco Dolstra1-2/+2
Fixes #225.
2014-03-12 Document nix-env -q --jsonEelco Dolstra1-0/+8
2014-03-12 Generate release notes againEelco Dolstra5-11/+34
2014-03-12 Update release notes for 1.7Eelco Dolstra1-45/+247
2014-03-11 Fix passing meta attribute to buildenv.nixEelco Dolstra1-0/+1
Since the meta attributes were not sorted, attribute lookup could fail, leading to package priorities and active flags not working correctly. Broken since 0f24400d90daf65cf20142a662f8245008437e2c.
2014-03-11 Fix typosEelco Dolstra2-3/+3
2014-03-11 Document null dynamic attrsShea Levy2-1/+15
2014-03-10 The expr of AttrNames/DynamicAttrDefs is always an ExprConcatStringsShea Levy3-12/+10
2014-03-10 If a dynamic attribute name evaluates to null, remove it from the setShea Levy3-1/+11
2014-03-05 Revert "Make ifs and asserts tail-recursive"Eelco Dolstra2-11/+4
This reverts commit 273322c7732093a354e86df82cf75d6604b8bce8.
2014-03-05 Install missing Boost headersEelco Dolstra1-0/+2
http://hydra.nixos.org/build/9328376
2014-02-28 TypoEelco Dolstra1-1/+1
2014-02-27 Set up a private /dev/pts in the chrootEelco Dolstra2-2/+14
2014-02-27 Set up a minimal /dev in chrootsEelco Dolstra8-17/+40
Not bind-mounting the /dev from the host also solves the problem with /dev/shm being a symlink to something not in the chroot.
2014-02-27 Correctly detect infinite recursion in function applicationEelco Dolstra1-2/+4
If we're evaluating some application ‘v = f x’, we can't store ‘f’ temporarily in ‘v’, because if ‘f x’ refers to ‘v’, it will get ‘f’ rather than an infinite recursion error. Unfortunately, this breaks the tail call optimisation introduced in c897bac54954373f63511702731fe2cb23c0c98e. Fixes #217.
2014-02-27 Fix deadlock in SubstitutionGoalEelco Dolstra1-0/+1
We were relying on SubstitutionGoal's destructor releasing the lock, but if a goal is a top-level goal, the destructor won't run in a timely manner since its reference count won't drop to zero. So release it explicitly. Fixes #178.
2014-02-26 DohEelco Dolstra1-1/+1
2014-02-26 Test trace and addErrorContextEelco Dolstra1-0/+4
2014-02-26 Test some more primopsEelco Dolstra9-7/+24
2014-02-26 Test executables in NARsEelco Dolstra2-0/+6
2014-02-26 And another oneEelco Dolstra2-41/+2
2014-02-26 Remove another unused functionEelco Dolstra2-22/+0
2014-02-26 Remove unused functionEelco Dolstra2-32/+0
2014-02-26 Test nix-env --switch-generationEelco Dolstra1-0/+6
2014-02-26 Test nix-env --setEelco Dolstra1-0/+6
2014-02-26 Test the -b and -s flags of nix-store -qEelco Dolstra1-0/+12
2014-02-26 Test ~/.nix-defexprEelco Dolstra1-14/+17
2014-02-26 Test nix-store --switch-profile and more daemon actionsEelco Dolstra2-51/+70
2014-02-26 Test nix-store -q --rootsEelco Dolstra1-0/+2
2014-02-26 Test nix-store -lEelco Dolstra1-1/+11
2014-02-26 Test nix-store --optimiseEelco Dolstra1-0/+17
2014-02-26 Add a test for nix-store --dump-db / --load-dbEelco Dolstra2-1/+21
2014-02-26 Installer: Handle DarwinEelco Dolstra1-1/+1
"cp -r" doesn't copy symlinks properly on Darwin, but "cp -R" does. Fixes #215.
2014-02-26 nix-store -r: Respect --add-root for non-derivationsEelco Dolstra1-1/+9
Fixes #68. Fixes #117.
2014-02-26 Also provide an option for setting the curl connection timeoutEelco Dolstra2-1/+18
2014-02-26 Respect $NIX_CONNECT_TIMEOUT properlyEelco Dolstra1-2/+4
We were 1) using CURLOPT_TIMEOUT instead of CURLOPT_CONNECTTIMEOUT; 2) not passing it to the curl child process. Issue #93.
2014-02-26 Add ~/.nix-profile/sbin to $PATHEelco Dolstra1-1/+1
Fixes #112.
2014-02-26 Warn about missing -I pathsEelco Dolstra3-5/+6
Fixes #121. Note that we don't warn about missing $NIX_PATH entries because it's intended that some may be missing (cf. the default $NIX_PATH on NixOS, which includes paths like /etc/nixos/nixpkgs for backward compatibility).
2014-02-26 Document dynamic attributesShea Levy2-4/+23
Signed-off-by: Shea Levy <shea@shealevy.com>
2014-02-26 Simplify getting use-ssh-substituter from untrusted usersEelco Dolstra2-14/+3
2014-02-26 Fix broken patchEelco Dolstra2-2/+2