about summary refs log tree commit diff
path: root/tvix/eval
diff options
context:
space:
mode:
Diffstat (limited to 'tvix/eval')
-rw-r--r--tvix/eval/docs/builtins.md2
-rw-r--r--tvix/eval/src/builtins/mod.rs23
2 files changed, 20 insertions, 5 deletions
diff --git a/tvix/eval/docs/builtins.md b/tvix/eval/docs/builtins.md
index f3a4a29c26f2..6e0c7b559516 100644
--- a/tvix/eval/docs/builtins.md
+++ b/tvix/eval/docs/builtins.md
@@ -121,7 +121,7 @@ The `impl` column indicates implementation status in tvix:
 | tryEval                       | false  |       |       |         |
 | typeOf                        | false  |       |       |         |
 | unsafeDiscardOutputDependency | false  |       |       | context |
-| unsafeDiscardStringContext    | false  |       |       | context |
+| unsafeDiscardStringContext    | false  |       |       |         |
 | unsafeGetAttrPos              | false  |       |       | todo    |
 | valueSize                     | false  |       |       | todo    |
 
diff --git a/tvix/eval/src/builtins/mod.rs b/tvix/eval/src/builtins/mod.rs
index 4cf9074fb8bf..b5adc3775fc0 100644
--- a/tvix/eval/src/builtins/mod.rs
+++ b/tvix/eval/src/builtins/mod.rs
@@ -1348,11 +1348,26 @@ mod placeholder_builtins {
 
     #[builtin("unsafeDiscardStringContext")]
     async fn builtin_unsafe_discard_string_context(
-        _: GenCo,
-        #[lazy] s: Value,
+        co: GenCo,
+        s: Value,
     ) -> Result<Value, ErrorKind> {
-        // Tvix does not manually track contexts, and this is a no-op for us.
-        Ok(s)
+        let span = generators::request_span(&co).await;
+        let mut v = s
+            .coerce_to_string(
+                co,
+                // It's weak because
+                // lists, integers, floats and null are not
+                // accepted as parameters.
+                CoercionKind {
+                    strong: false,
+                    import_paths: true,
+                },
+                span,
+            )
+            .await?
+            .to_contextful_str()?;
+        v.clear_context();
+        Ok(Value::String(v))
     }
 
     #[builtin("addErrorContext")]