diff options
Diffstat (limited to 'src/libutil')
-rw-r--r-- | src/libutil/hash.cc | 10 | ||||
-rw-r--r-- | src/libutil/logging.hh | 1 | ||||
-rw-r--r-- | src/libutil/util.hh | 51 |
3 files changed, 9 insertions, 53 deletions
diff --git a/src/libutil/hash.cc b/src/libutil/hash.cc index 49e781980f3a..aa50fceb9e3e 100644 --- a/src/libutil/hash.cc +++ b/src/libutil/hash.cc @@ -106,7 +106,7 @@ Hash parseHash(HashType ht, const string & s) string s2(s, i * 2, 2); if (!isxdigit(s2[0]) || !isxdigit(s2[1])) throw BadHash(format("invalid hash ‘%1%’") % s); - istringstream_nocopy str(s2); + std::istringstream str(s2); int n; str >> std::hex >> n; hash.hash[i] = n; @@ -165,7 +165,13 @@ Hash parseHash32(HashType ht, const string & s) unsigned int i = b / 8; unsigned int j = b % 8; hash.hash[i] |= digit << j; - if (i < hash.hashSize - 1) hash.hash[i + 1] |= digit >> (8 - j); + + if (i < hash.hashSize - 1) { + hash.hash[i + 1] |= digit >> (8 - j); + } else { + if (digit >> (8 - j)) + throw BadHash(format("invalid base-32 hash ‘%1%’") % s); + } } return hash; diff --git a/src/libutil/logging.hh b/src/libutil/logging.hh index ba99a81c3826..3e6c4b54853c 100644 --- a/src/libutil/logging.hh +++ b/src/libutil/logging.hh @@ -79,6 +79,7 @@ extern Verbosity verbosity; /* suppress msgs > this */ #define printError(args...) printMsg(lvlError, args) #define printInfo(args...) printMsg(lvlInfo, args) #define debug(args...) printMsg(lvlDebug, args) +#define vomit(args...) printMsg(lvlVomit, args) void warnOnce(bool & haveWarned, const FormatOrString & fs); diff --git a/src/libutil/util.hh b/src/libutil/util.hh index 1ede48a65ff2..50b96f7ed92c 100644 --- a/src/libutil/util.hh +++ b/src/libutil/util.hh @@ -431,55 +431,4 @@ void callSuccess( } -/* A variant of std::istringstream that doesn't copy its string - argument. This is useful for large strings. The caller must ensure - that the string object is not destroyed while it's referenced by - this object. */ -class istringbuf_nocopy : public std::streambuf -{ - const std::string & s; - decltype(s.size()) off; - decltype(s.size()) size; -public: - istringbuf_nocopy(const std::string & s) : s{s}, off{0}, size{s.size()} - { - } - -private: - int_type underflow() - { - if (off == size) - return traits_type::eof(); - return traits_type::to_int_type(s[off]); - } - - int_type uflow() - { - if (off == size) - return traits_type::eof(); - return traits_type::to_int_type(s[off++]); - } - - int_type pbackfail(int_type ch) - { - if (off == 0 || (ch != traits_type::eof() && ch != s[off - 1])) - return traits_type::eof(); - - return traits_type::to_int_type(s[--off]); - } - - std::streamsize showmanyc() - { - return size - off; - } -}; - - -struct istringstream_nocopy : public std::iostream -{ - istringbuf_nocopy buf; - istringstream_nocopy(const std::string & s) : std::iostream(&buf), buf(s) {}; -}; - - } |