diff options
Diffstat (limited to 'src/libstore/store.cc')
-rw-r--r-- | src/libstore/store.cc | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/src/libstore/store.cc b/src/libstore/store.cc index 74f182468a5d..9c5d0bab8aae 100644 --- a/src/libstore/store.cc +++ b/src/libstore/store.cc @@ -302,19 +302,16 @@ static void writeSubstitutes(const Transaction & txn, } -void registerSubstitute(const Path & srcPath, - const Substitute & sub) +void registerSubstitute(const Transaction & txn, + const Path & srcPath, const Substitute & sub) { assertStorePath(srcPath); assertStorePath(sub.storeExpr); - Transaction txn(nixDB); - Substitutes subs = readSubstitutes(txn, srcPath); if (find(subs.begin(), subs.end(), sub) != subs.end()) { /* Nothing to do if the substitute is already known. */ - txn.abort(); return; } subs.push_front(sub); /* new substitutes take precedence */ @@ -325,10 +322,9 @@ void registerSubstitute(const Path & srcPath, nixDB.queryStrings(txn, dbSubstitutesRev, sub.storeExpr, revs); if (find(revs.begin(), revs.end(), srcPath) == revs.end()) revs.push_back(srcPath); - - nixDB.setStrings(txn, dbSubstitutesRev, sub.storeExpr, revs); - txn.commit(); + // !!! O(n^2) complexity in building this + // nixDB.setStrings(txn, dbSubstitutesRev, sub.storeExpr, revs); } |