about summary refs log tree commit diff
diff options
context:
space:
mode:
-rw-r--r--ops/pipelines/depot.nix11
-rw-r--r--ops/pipelines/static-pipeline.yaml9
2 files changed, 7 insertions, 13 deletions
diff --git a/ops/pipelines/depot.nix b/ops/pipelines/depot.nix
index 709ccc9d5f83..6d4b69d5b086 100644
--- a/ops/pipelines/depot.nix
+++ b/ops/pipelines/depot.nix
@@ -75,17 +75,8 @@ let
   #
   # Pipeline steps need to stay in order.
   pipeline.steps =
-    # Zero the failure status
-    [
-      {
-        command = "buildkite-agent meta-data set 'failure' '0'";
-        label = ":buildkite:";
-      }
-      { wait = null; }
-    ]
-
     # Create build steps for each CI target
-    ++ (map mkStep depot.ci.targets)
+    (map mkStep depot.ci.targets)
 
     ++ [
       # Simultaneously run protobuf checks
diff --git a/ops/pipelines/static-pipeline.yaml b/ops/pipelines/static-pipeline.yaml
index 7a6e911ac252..c428780a0613 100644
--- a/ops/pipelines/static-pipeline.yaml
+++ b/ops/pipelines/static-pipeline.yaml
@@ -1,6 +1,8 @@
-# This file defines the static pipeline which is uploaded in the
-# Buildkite admin interface. These steps run at the beginning of each
-# build and cause the dynamic pipeline generation to run.
+# This file defines the static Buildkite pipeline which attempts to
+# create the dynamic pipeline of all depot targets.
+#
+# If something fails during the creation of the pipeline, the fallback
+# is executed instead which will simply report an error to Gerrit.
 ---
 steps:
   - label: ":llama:"
@@ -12,4 +14,5 @@ steps:
       }
 
       nix-build -A ops.pipelines.depot -o depot.yaml --show-trace || fallback
+      buildkite-agent meta-data set 'failure' '0'
       buildkite-agent pipeline upload depot.yaml || fallback