about summary refs log tree commit diff
diff options
context:
space:
mode:
-rw-r--r--src/Xanthous/Data/EntityMap/Graphics.hs3
-rw-r--r--test/Xanthous/Data/EntityMap/GraphicsSpec.hs1
2 files changed, 2 insertions, 2 deletions
diff --git a/src/Xanthous/Data/EntityMap/Graphics.hs b/src/Xanthous/Data/EntityMap/Graphics.hs
index d523c0555e4f..0f2f2bfe16d6 100644
--- a/src/Xanthous/Data/EntityMap/Graphics.hs
+++ b/src/Xanthous/Data/EntityMap/Graphics.hs
@@ -56,8 +56,7 @@ linesOfSight (view _Position -> pos) visionRadius em
 visibleEntities :: Entity e => Position -> Word -> EntityMap e -> EntityMap e
 visibleEntities pos visionRadius
   = fromEIDsAndPositioned
-  . fold
-  . map (\(p, es) -> over _2 (Positioned p) <$> es)
+  . foldMap (\(p, es) -> over _2 (Positioned p) <$> es)
   . fold
   . linesOfSight pos visionRadius
 
diff --git a/test/Xanthous/Data/EntityMap/GraphicsSpec.hs b/test/Xanthous/Data/EntityMap/GraphicsSpec.hs
index 55ae0d79dbb8..fd37548ce864 100644
--- a/test/Xanthous/Data/EntityMap/GraphicsSpec.hs
+++ b/test/Xanthous/Data/EntityMap/GraphicsSpec.hs
@@ -19,6 +19,7 @@ test = testGroup "Xanthous.Data.EntityMap.Graphics"
   [ testGroup "visiblePositions"
     [ testProperty "one step in each cardinal direction is always visible"
       $ \pos (Cardinal dir) (Positive r) (wallPositions :: Set Position)->
+          pos `notMember` wallPositions ==>
           let em = review _EntityMap . map (, Wall) . toList $ wallPositions
               em' = em & atPosition (move dir pos) %~ (Wall <|)
               poss = visiblePositions pos r em'