diff options
| author | Griffin Smith <grfn@gws.fyi> | 2021-05-23T12·22+0200 |
|---|---|---|
| committer | grfn <grfn@gws.fyi> | 2021-05-23T14·41+0000 |
| commit | a7d07e1a8a78ee8e5ecdd7f0f63d0c69e67a3396 (patch) | |
| tree | a5e2f96ea11e8e39fe3069196b07107785fa75de /web | |
| parent | ba6bee80fb90a80c41118991ca754a4ba5b73440 (diff) | |
fix(panettone): Fix username display on issue events r/2614
7aebba7, which added anchor links to comments, also incorrectly added only the *key* for the `:id` attribute to the `li` element for issue *events*, swallowing up the next form (which happened to be the username) as the value. this adds a *proper* value for the `:id` attribute, bringing back the actual display of the username. Fixes: b/97 Change-Id: I33ee628ddfd4a291e069980512fcc5f74014aac4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/3141 Tested-by: BuildkiteCI Reviewed-by: sterni <sternenseemann@systemli.org>
Diffstat (limited to 'web')
| -rw-r--r-- | web/panettone/src/panettone.lisp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/web/panettone/src/panettone.lisp b/web/panettone/src/panettone.lisp index 0b1af742c838..87b39ad9461d 100644 --- a/web/panettone/src/panettone.lisp +++ b/web/panettone/src/panettone.lisp @@ -317,11 +317,12 @@ (who:esc (format-dottime (created-at comment)))))))))) (defmethod render/issue-history-item ((event model:issue-event)) - (let ((user (find-user-by-dn (acting-user-dn event)))) + (let ((user (find-user-by-dn (acting-user-dn event))) + (fragment (format nil "event-~A" (id event)))) (who:with-html-output (*standard-output*) (:li :class "event" - :id + :id fragment (who:esc (displayname-if-known user)) (if (string= (field event) "STATUS") (who:htm |