feat(todolist): use static slapd user data for knownUsers r/2131

Since the slapd data is static and generated using nix, we can simply
move the user list into ops/users, so it's recognized by readTree and we
can use it as ops.users both in ops/nixos/tvl-slapd and web/todolist as
a general purpose user registry for depot.

Update docs/REVIEWS.md as well.

Change-Id: I35caaaab70a5578c47cedc7f33077dd513766290
Reviewed-on: https://cl.tvl.fyi/c/depot/+/2419
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>

1 files changed, 2 insertions, 9 deletions

diff --git a/web/todolist/default.nix b/web/todolist/default.nix
index 8a12d0121256..d66a05baf8c3 100644
--- a/web/todolist/default.nix
+++ b/web/todolist/default.nix
@@ -20,19 +20,12 @@ let
     fromJSON
     head
     readFile
+    map
     ;
 
   inherit (lib) concatStringsSep;
 
-  # We should extract this from TVL slapd, but that data is not easily
-  # accessible right now.
-  knownUsers = [
-    "tazjin"
-    "riking"
-    "Profpatsch"
-    "grfn"
-    "lukegb"
-  ];
+  knownUsers = map (u: u.username) depot.ops.users;
 
   todo = struct {
     file = string;