about summary refs log tree commit diff
path: root/web/blog
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-10-11T14·50+0300
committerflokli <flokli@flokli.de>2024-10-11T17·19+0000
commit8b7b85359b50f1b93cd63e2935ff09bdc50d5916 (patch)
tree8fbce7592b9605aa67e6def515859771d4bf1941 /web/blog
parent6a116d5057954470a3aa9907c3050c05ba6e8a37 (diff)
test(tvix/store/signing_wrapper): restructure r/8790
Move things around a bit to make it easier to understand what's going on:

 - We first validate our fixture invariants
 - We then insert into the PathInfoService
 - Do all comparisons and checks we can on the returned PathInfo struct
 - Only convert to the NarInfo variant to calculate the fingerprint,
   and don't keep intermediate let bindings for this

Before cl/12588, this was arguably much harder to do that way, as we
relied on some of the conversions done in the to_narinfo() function.

Change-Id: Iaddbf1079f73ce566ef6d56f69a823e080b2e006
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12595
Reviewed-by: Marijan Petričević <marijan.petricevic94@gmail.com>
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
Reviewed-by: sinavir <tvix@sinavir.fr>
Diffstat (limited to 'web/blog')
0 files changed, 0 insertions, 0 deletions