about summary refs log tree commit diff
path: root/views/.skip-subtree
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-10-10T22·23+0300
committerflokli <flokli@flokli.de>2024-10-11T17·19+0000
commit6a116d5057954470a3aa9907c3050c05ba6e8a37 (patch)
tree22bea8605d649e3335266d4277367419d809c671 /views/.skip-subtree
parent48fa320cf49fee159d8cdd031c21ae6d17dbb7b3 (diff)
refactor(tvix/glue/register_in_path_info_service): return only PathInfo r/8789
The store path is already contained in the PathInfo, and the ca bits is
already passed into the function, so known to the caller - there's no
need to duplicate this.

We can also avoid having two separate block_on in our import builtin -
we already know the content hash before constructing, as we pass it in
via ca_hash.

There's still some room to unclutter some more of the code around
importing - we still do NAR calculation twice in some cases, and some of
the code might be share-able from other places producing PathInfo too.
Log a TODO for this cleanup.

Change-Id: I6a5fc427d15bc9293a396310143c7694dd2996c0
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12592
Reviewed-by: Marijan Petričević <marijan.petricevic94@gmail.com>
Reviewed-by: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
Diffstat (limited to 'views/.skip-subtree')
0 files changed, 0 insertions, 0 deletions