about summary refs log tree commit diff
path: root/users/wpcarro/emacs/pkgs/maybe
diff options
context:
space:
mode:
authorWilliam Carroll <wpcarro@gmail.com>2022-07-30T14·16-0700
committerclbot <clbot@tvl.fyi>2022-07-30T14·25+0000
commit6686c6d693acd340094370889a8381e793e76933 (patch)
treedb3478ca53b25f4fe8a7130f83dfe9b42b0b1aa9 /users/wpcarro/emacs/pkgs/maybe
parent4193f24e5d7583f2b176cc35cac2e55319be528f (diff)
fix(wpcarro/emacs): Use should macro in maybe.el tests r/4355
More fixes along the way

Change-Id: I6b62eb0545981c2792d6c70089fe81324ba2dbf0
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6010
Reviewed-by: wpcarro <wpcarro@gmail.com>
Autosubmit: wpcarro <wpcarro@gmail.com>
Tested-by: BuildkiteCI
Diffstat (limited to 'users/wpcarro/emacs/pkgs/maybe')
-rw-r--r--users/wpcarro/emacs/pkgs/maybe/tests.el19
1 files changed, 8 insertions, 11 deletions
diff --git a/users/wpcarro/emacs/pkgs/maybe/tests.el b/users/wpcarro/emacs/pkgs/maybe/tests.el
index 775bb6b7ac80..c0463cc65a53 100644
--- a/users/wpcarro/emacs/pkgs/maybe/tests.el
+++ b/users/wpcarro/emacs/pkgs/maybe/tests.el
@@ -9,20 +9,17 @@
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
 (ert-deftest maybe-nil? ()
-  (and
-   (maybe-nil? nil)
-   (not (maybe-nil? t))))
+  (should (maybe-nil? nil))
+  (should (not (maybe-nil? t))))
 
 (ert-deftest maybe-some? ()
-  (and
-   (maybe-some? '(1 2 3))
-   (not (maybe-some? nil))))
+  (should (maybe-some? '(1 2 3)))
+  (should (not (maybe-some? nil))))
 
 (ert-deftest maybe-default ()
-  (and
-   (string= "some" (maybe-default "some" nil))
-   (= 10 (maybe-default 1 10))))
+  (should (string= "some" (maybe-default "some" nil)))
+  (should (= 10 (maybe-default 1 10))))
 
 (ert-deftest maybe-map ()
-  (eq nil (maybe-map (lambda (x) (* x 2)) nil))
-  (= 4 (maybe-map (lambda (x) (* x 2)) 2)))
+  (should (eq nil (maybe-map (lambda (x) (* x 2)) nil)))
+  (should (= 4 (maybe-map (lambda (x) (* x 2)) 2))))