about summary refs log tree commit diff
path: root/users/wpcarro/emacs/pkgs/bag/tests.el
diff options
context:
space:
mode:
authorWilliam Carroll <wpcarro@gmail.com>2022-07-30T14·09-0700
committerclbot <clbot@tvl.fyi>2022-07-30T14·12+0000
commit3935848a5dffc5b5193feca267427671525cbaf3 (patch)
tree28bcdf0c96cd64e5107506dab8e5572e56410e95 /users/wpcarro/emacs/pkgs/bag/tests.el
parent977473d6316c2122cfbdcdebe30a111aaab0aa33 (diff)
fix(wpcarro/emacs): Use should macros for bag.el tests r/4353
:facepalm: (more fixes forthcoming)

Change-Id: Ibcbea21c44034a2fe6649c22ba2c140da15ec004
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6008
Reviewed-by: wpcarro <wpcarro@gmail.com>
Autosubmit: wpcarro <wpcarro@gmail.com>
Tested-by: BuildkiteCI
Diffstat (limited to 'users/wpcarro/emacs/pkgs/bag/tests.el')
-rw-r--r--users/wpcarro/emacs/pkgs/bag/tests.el24
1 files changed, 10 insertions, 14 deletions
diff --git a/users/wpcarro/emacs/pkgs/bag/tests.el b/users/wpcarro/emacs/pkgs/bag/tests.el
index 0cc2a6029e3c..4970f70815c9 100644
--- a/users/wpcarro/emacs/pkgs/bag/tests.el
+++ b/users/wpcarro/emacs/pkgs/bag/tests.el
@@ -12,25 +12,21 @@
 (setq fixture (bag-from-list '(1 1 1 2 2 3)))
 
 (ert-deftest bag-add ()
-  (and
-   (not (bag-contains? 4 fixture))
-   (bag-contains? 4 (bag-add 4 fixture))))
+  (should (not (bag-contains? 4 fixture)))
+  (should (bag-contains? 4 (bag-add 4 fixture))))
 
 (ert-deftest bag-remove ()
-  (and
-   (bag-contains? 1 fixture)
-   (not (bag-contains? 3 (bag-remove 3 fixture)))))
+  (should (bag-contains? 1 fixture))
+  (should (not (bag-contains? 3 (bag-remove 3 fixture)))))
 
 (ert-deftest bag-count ()
-  (and
-   (= 3 (bag-count 1 fixture))
-   (= 2 (bag-count 2 fixture))
-   (= 1 (bag-count 3 fixture))))
+  (should (= 3 (bag-count 1 fixture)))
+  (should (= 2 (bag-count 2 fixture)))
+  (should (= 1 (bag-count 3 fixture))))
 
 (ert-deftest bag-total ()
-  (= 6 (bag-total fixture)))
+  (should (= 6 (bag-total fixture))))
 
 (ert-deftest bag-contains? ()
-  (and
-   (bag-contains? 1 fixture)
-   (not (bag-contains? 4 fixture))))
+  (should (bag-contains? 1 fixture))
+  (should (not (bag-contains? 4 fixture))))