about summary refs log tree commit diff
path: root/users/flokli/presentations/2023-09-09-nixcon-tvix
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-10-26T08·36+0200
committerflokli <flokli@flokli.de>2024-10-26T10·13+0000
commitf3f20c2080f1721d099d0c472740763ee062543a (patch)
tree1c7b547d6c11f304f8b928042ea27c7ea8da928f /users/flokli/presentations/2023-09-09-nixcon-tvix
parent5faa3f9c657f7ee12c6e5536a6e0a5403c80ff29 (diff)
fix(users/flokli/slides/2023-nixcon): fix pdf gen r/8858
reveal-md didn't exit with a nonzero exit code and just didn't contain
the PDF. Fix this.

Change-Id: Ie4bc7cbf4b9117b0a672a3294e9e64fb13459247
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12683
Autosubmit: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
Diffstat (limited to 'users/flokli/presentations/2023-09-09-nixcon-tvix')
-rw-r--r--users/flokli/presentations/2023-09-09-nixcon-tvix/default.nix8
1 files changed, 4 insertions, 4 deletions
diff --git a/users/flokli/presentations/2023-09-09-nixcon-tvix/default.nix b/users/flokli/presentations/2023-09-09-nixcon-tvix/default.nix
index 1ec0a0bd0ed7..b50309b6c2f6 100644
--- a/users/flokli/presentations/2023-09-09-nixcon-tvix/default.nix
+++ b/users/flokli/presentations/2023-09-09-nixcon-tvix/default.nix
@@ -18,9 +18,6 @@ stdenv.mkDerivation {
     fontDirectories = with pkgs; [ jetbrains-mono fira fira-code fira-mono lato ];
   };
 
-  PUPPETEER_EXECUTABLE_PATH = "${pkgs.chromium}/bin/chromium";
-  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD = "1";
-
   nativeBuildInputs = [ pkgs.reveal-md pkgs.graphviz ];
 
   buildPhase = ''
@@ -31,7 +28,10 @@ stdenv.mkDerivation {
 
     mkdir -p $out
     reveal-md --static $out presentation.md
-    reveal-md --print $out/slides.pdf presentation.md
     cp tvixbolt.webm $out
+
+    CHROME_CONFIG_HOME=/build/.config reveal-md presentation.md --print $out/slides.pdf --puppeteer-chromium-executable="${pkgs.chromium}/bin/chromium"
+    # Above command doesn't fail on error, ensure file has been created
+    [[ -f "$out/slides.pdf" ]] || exit 1
   '';
 }