refactor(tvix/eval): clean up implementation of `compile_literal` r/4889

Suggested by sterni in cl/6231

Change-Id: I58bbc8a922d360ea79a4dacb76cf8aa1fad93757
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6622
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>

1 files changed, 7 insertions, 10 deletions

diff --git a/tvix/eval/src/compiler/mod.rs b/tvix/eval/src/compiler/mod.rs
index 0322733676..52b6e8e542 100644
--- a/tvix/eval/src/compiler/mod.rs
+++ b/tvix/eval/src/compiler/mod.rs
@@ -190,20 +190,17 @@ impl Compiler<'_, '_> {
     }
 
     fn compile_literal(&mut self, node: ast::Literal) {
-        match node.kind() {
-            ast::LiteralKind::Float(f) => {
-                self.emit_constant(Value::Float(f.value().unwrap()), &node);
-            }
-
-            ast::LiteralKind::Integer(i) => {
-                self.emit_constant(Value::Integer(i.value().unwrap()), &node);
-            }
+        let value = match node.kind() {
+            ast::LiteralKind::Float(f) => Value::Float(f.value().unwrap()),
+            ast::LiteralKind::Integer(i) => Value::Integer(i.value().unwrap()),
 
             ast::LiteralKind::Uri(u) => {
                 self.emit_warning(&node, WarningKind::DeprecatedLiteralURL);
-                self.emit_constant(Value::String(u.syntax().text().into()), &node);
+                Value::String(u.syntax().text().into())
             }
-        }
+        };
+
+        self.emit_constant(value, &node);
     }
 
     fn compile_path(&mut self, node: ast::Path) {