diff options
| author | Ilan Joselevich <personal@ilanjoselevich.com> | 2024-07-04T18·05+0300 |
|---|---|---|
| committer | Ilan Joselevich <personal@ilanjoselevich.com> | 2024-07-05T20·19+0000 |
| commit | 7ca32d9f0baf2548ec32d75d2872e8b82d4d8921 (patch) | |
| tree | 791a20db7c7c1c3cc7da36088ac3b4f11af4f0c0 /tvix | |
| parent | 6a7069904e9d29f05638c37a52b640bc9eb43a63 (diff) | |
refactor(web/tvixbolt): buildRustPackage -> crate2nix r/8349
With the recent changes to crate2nix and buildRustCrate in nixpkgs it is now possible to build tvixbolt via crate2nix like we do for other tvix crates. We can reuse a lot of the customizations done in //tvix in tvixbolt to avoid repeating ourselves. A script for serving tvixbolt locally for testing purposes is also available now through the .serve attribute of tvixbolt. This change supersedes https://cl.tvl.fyi/c/depot/+/11821. Change-Id: I4864df8b75aec73cf5fee2428924ed4cfbb32902 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11952 Tested-by: BuildkiteCI Autosubmit: Ilan Joselevich <personal@ilanjoselevich.com> Reviewed-by: flokli <flokli@flokli.de>
Diffstat (limited to 'tvix')
| -rw-r--r-- | tvix/docs/src/TODO.md | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/tvix/docs/src/TODO.md b/tvix/docs/src/TODO.md index fe161e3412d4..9baf170351e4 100644 --- a/tvix/docs/src/TODO.md +++ b/tvix/docs/src/TODO.md @@ -25,18 +25,6 @@ sure noone is working on this, or has some specific design in mind already. with a different level of `--strict`, but the toplevel doc-comment suggests its generic? -### crate2nix for WASM (@kranzes) -Most of Tvix is living inside a `//tvix` cargo workspace, and we use `crate2nix` -as a build system, to get crate-level build granularity (and caching), keeping -compile times somewhat manageable. - -Thanks to the recent crate2nix fixes, we can now use it to build WASM. -We should migrate `//web/tvixbolt` from `rustPlatform.buildRustPackage` to -`crate2nix`. -An initial cl/11821 to move it to the `//tvix` workspace got some pushback, we -should see if it's possible to keep it in a separate directory and still refer -to the (cleaned) sources described in `tvix/default.nix`. - ## Perf - String Contexts currently do a lot of indirections (edef) (NixString -> NixStringInner -> HashSet[element] -> NixContextElement -> String -> data) |