diff options
| author | Florian Klink <flokli@flokli.de> | 2024-05-23T14·58+0200 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2024-05-23T15·58+0000 |
| commit | c4c42c8b6c064b8b1a30632034948de07cbef305 (patch) | |
| tree | 4df7a7321dc79baa895bd082e6fe6af73d1643e2 /tvix | |
| parent | 6ad3780734fef723709bdc3eaf871b2a5c94291e (diff) | |
docs(tvix/docs/TODO): add item for string context rework r/8166
Change-Id: I4592490a75fb05093b3fd8649db3b57bff748c0d Reviewed-on: https://cl.tvl.fyi/c/depot/+/11707 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: edef <edef@edef.eu> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix')
| -rw-r--r-- | tvix/docs/src/TODO.md | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/tvix/docs/src/TODO.md b/tvix/docs/src/TODO.md index ca740c965527..0fb7d70d40ce 100644 --- a/tvix/docs/src/TODO.md +++ b/tvix/docs/src/TODO.md @@ -25,6 +25,15 @@ sure noone is working on this, or has some specific design in mind already. with a different level of `--strict`, but the toplevel doc-comment suggests its generic? +## Perf + - String Contexts currently do a lot of indirections (edef) + (NixString -> NixStringInner -> HashSet[element] -> NixContextElement -> String -> data) + to get to the actual data. We should improve this. There's various ideas, one + of it is globally interning all Nix context elements, and only keeping + indices into that. We might need to have different representations for small + amount of context elements or larger ones, and need tooling to reason about + the amount of contexts we have. + ### Error cleanup - Currently, all services use tvix_castore::Error, which only has two kinds (invalid request, storage error), containing an (owned) string. |