diff options
author | Florian Klink <flokli@flokli.de> | 2023-08-19T15·31+0200 |
---|---|---|
committer | flokli <flokli@flokli.de> | 2023-08-20T21·52+0000 |
commit | aead2001d7c3535be0f2f49daf73fe8a658d0c51 (patch) | |
tree | c2cae4d0ee0eb6537542985ff0da7ef5331d1bce /tvix | |
parent | cf1a884ec52dc7e837ae19fb2332292419707fda (diff) |
refactor(tvix/eval): impl Default for SourceCode r/6507
… instead of new(). Suggested by clippy. Change-Id: Iac7be733392afefc2b4ff2e38386eee95f3bce94 Reviewed-on: https://cl.tvl.fyi/c/depot/+/9103 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: raitobezarius <tvl@lahfa.xyz>
Diffstat (limited to 'tvix')
-rw-r--r-- | tvix/eval/src/lib.rs | 2 | ||||
-rw-r--r-- | tvix/eval/src/source.rs | 12 |
2 files changed, 8 insertions, 6 deletions
diff --git a/tvix/eval/src/lib.rs b/tvix/eval/src/lib.rs index deb48b50078e..3ce98bc47097 100644 --- a/tvix/eval/src/lib.rs +++ b/tvix/eval/src/lib.rs @@ -145,7 +145,7 @@ impl<'code, 'co, 'ro> Evaluation<'code, 'co, 'ro> { /// Initialise an `Evaluation` for the given Nix source code snippet, and /// an optional code location. pub fn new(code: &'code str, location: Option<PathBuf>) -> Self { - let source_map = SourceCode::new(); + let source_map = SourceCode::default(); let location_str = location .as_ref() diff --git a/tvix/eval/src/source.rs b/tvix/eval/src/source.rs index 649679536080..5a7f10abb8da 100644 --- a/tvix/eval/src/source.rs +++ b/tvix/eval/src/source.rs @@ -19,11 +19,6 @@ use codemap::{CodeMap, Span}; pub struct SourceCode(Rc<RefCell<CodeMap>>); impl SourceCode { - /// Create a new SourceCode instance. - pub fn new() -> Self { - SourceCode(Rc::new(RefCell::new(CodeMap::new()))) - } - /// Access a read-only reference to the codemap. pub fn codemap(&self) -> Ref<CodeMap> { self.0.borrow() @@ -61,3 +56,10 @@ impl SourceCode { self.codemap().look_up_span(span).file } } + +impl Default for SourceCode { + /// Create a new SourceCode instance. + fn default() -> Self { + Self(Rc::new(RefCell::new(CodeMap::new()))) + } +} |