diff options
author | sterni <sternenseemann@systemli.org> | 2022-12-28T11·52+0100 |
---|---|---|
committer | sterni <sternenseemann@systemli.org> | 2022-12-29T09·52+0000 |
commit | 56555b211ee2896999ad457cabc02e411ca54f40 (patch) | |
tree | 398db9a81d0e96f2faf9fb55a9583170e98d4c06 /tvix | |
parent | ee7a724b608fa30e3664bbc2e99e19e72559b15a (diff) |
docs(tvix/eval): sketch in place list/attr set update idea r/5530
Change-Id: Ic7debbd8cbd3acdf5f3947288f2aa2964bd163a0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7660 Autosubmit: sterni <sternenseemann@systemli.org> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
Diffstat (limited to 'tvix')
-rw-r--r-- | tvix/eval/docs/known-optimisation-potential.md | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/tvix/eval/docs/known-optimisation-potential.md b/tvix/eval/docs/known-optimisation-potential.md index 64101b861753..484ae271355d 100644 --- a/tvix/eval/docs/known-optimisation-potential.md +++ b/tvix/eval/docs/known-optimisation-potential.md @@ -110,3 +110,27 @@ optimisations, but note the most important ones here. Currently, the compiler emits a separate entry in the constant table for each literal. So the program `1 + 1 + 1` will have three entries in its `Chunk::constants` instead of only one. + +* Do some list and attribute set operations in place [hard] + + Algorithms that can not do a lot of work inside `builtins` like `map`, + `filter` or `foldl'` usually perform terribly if they use data structures like + lists and attribute sets. + + `builtins` can do work in place on a copy of a `Value`, but naïvely expressed + recursive algorithms will usually use `//` and `++` to do a single change to a + `Value` at a time, requiring a full copy of the data structure each time. + It would be a big improvement if we could do some of these operations in place + without requiring a new copy. + + There are probably two approaches: We could determine statically if a value is + reachable from elsewhere and emit a special in place instruction if not. An + easier alternative is probably to rely on reference counting at runtime: If no + other reference to a value exists, we can extend the list or update the + attribute set in place. + + An **alternative** to this is using [persistent data + structures](https://en.wikipedia.org/wiki/Persistent_data_structure) or at the + very least [immutable data structures](https://docs.rs/im/latest/im/) that can + be copied more efficiently than the stock structures we are using at the + moment. |