about summary refs log tree commit diff
path: root/tvix/verify-lang-tests/default.nix
diff options
context:
space:
mode:
authorsterni <sternenseemann@systemli.org>2023-06-07T14·08+0200
committerclbot <clbot@tvl.fyi>2023-06-15T11·01+0000
commit0f71d8f813adad2d8bf4cc3048adb7fb60f5a1f8 (patch)
tree45a391afc1c5d775ab5a36d04dc82bf3184e211d /tvix/verify-lang-tests/default.nix
parent0005737f110aa7667aec3ca3bb5bc7d4907a8664 (diff)
test(tvix/eval): genericClosure (pointer) comparison support r/6309
genericClosure has very limited support for pointer equality: It relies
on comparison (not equality!) in C++ Nix, so as soon as C++ Nix supports
comparing lists (langVersion >= 6) we can rely on pointer equality for
key.

Since Tvix uses equality, not comparison for the insert, our behavior is
currently different, as documented by the notyetpassing tests.

Change-Id: Ifcd741ed4fc3ccc3825f7038875d56a9918b786a
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8720
Tested-by: BuildkiteCI
Autosubmit: sterni <sternenseemann@systemli.org>
Reviewed-by: tazjin <tazjin@tvl.su>
Diffstat (limited to 'tvix/verify-lang-tests/default.nix')
-rw-r--r--tvix/verify-lang-tests/default.nix1
1 files changed, 1 insertions, 0 deletions
diff --git a/tvix/verify-lang-tests/default.nix b/tvix/verify-lang-tests/default.nix
index ef67aeb48986..7e70b6230673 100644
--- a/tvix/verify-lang-tests/default.nix
+++ b/tvix/verify-lang-tests/default.nix
@@ -55,6 +55,7 @@ let
     "eval-okay-sort.nix" = [ nix ];
     "eval-okay-compare-lists.nix" = [ nix ];
     "eval-okay-value-pointer-compare.nix" = [ nix ];
+    "eval-okay-builtins-genericClosure-pointer-equality.nix" = [ nix ];
     # getAttrPos gains support for functionArgs-returned sets after 2.3
     "eval-okay-getattrpos-functionargs.nix" = [ nix ];
     # groupBy appeared (long) after 2.3