diff options
author | Florian Klink <flokli@flokli.de> | 2023-06-09T09·26+0300 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2023-06-12T10·24+0000 |
commit | 7725eb53ad67730e92a3839a6c10925c668e5586 (patch) | |
tree | 82b8abf8e52630039d2a0cd3ae8b251c32e863bd /tvix/store/src/proto/grpc_directoryservice_wrapper.rs | |
parent | 6f85dbfc06c4fa96deb968cfeb7e98ba36e95043 (diff) |
refactor(tvix/store): use Box<dyn DirectoryService> r/6272
Once we support configuring services at runtime, we don't know what DirectoryService we're using at compile time. This also means, we can't explicitly use the is_closed method from GRPCPutter, without making it part of the DirectoryPutter itself. Change-Id: Icd2a1ec4fc5649a6cd15c9cc7db4c2b473630431 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8727 Autosubmit: flokli <flokli@flokli.de> Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/store/src/proto/grpc_directoryservice_wrapper.rs')
-rw-r--r-- | tvix/store/src/proto/grpc_directoryservice_wrapper.rs | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/tvix/store/src/proto/grpc_directoryservice_wrapper.rs b/tvix/store/src/proto/grpc_directoryservice_wrapper.rs index 6d2df310137f..f27688c4e962 100644 --- a/tvix/store/src/proto/grpc_directoryservice_wrapper.rs +++ b/tvix/store/src/proto/grpc_directoryservice_wrapper.rs @@ -1,27 +1,26 @@ use crate::proto; use crate::{directoryservice::DirectoryService, B3Digest}; use std::collections::HashMap; +use std::sync::Arc; use tokio::{sync::mpsc::channel, task}; use tokio_stream::wrappers::ReceiverStream; use tonic::{async_trait, Request, Response, Status, Streaming}; use tracing::{debug, instrument, warn}; -pub struct GRPCDirectoryServiceWrapper<C: DirectoryService> { - directory_service: C, +pub struct GRPCDirectoryServiceWrapper { + directory_service: Arc<Box<dyn DirectoryService>>, } -impl<DS: DirectoryService> From<DS> for GRPCDirectoryServiceWrapper<DS> { - fn from(value: DS) -> Self { +impl From<Box<dyn DirectoryService>> for GRPCDirectoryServiceWrapper { + fn from(value: Box<dyn DirectoryService>) -> Self { Self { - directory_service: value, + directory_service: Arc::new(value), } } } #[async_trait] -impl<DS: DirectoryService + Send + Sync + Clone + 'static> - proto::directory_service_server::DirectoryService for GRPCDirectoryServiceWrapper<DS> -{ +impl proto::directory_service_server::DirectoryService for GRPCDirectoryServiceWrapper { type GetStream = ReceiverStream<tonic::Result<proto::Directory, Status>>; #[instrument(skip(self))] |