diff options
author | Connor Brewster <cbrewster@hey.com> | 2023-09-16T15·20-0500 |
---|---|---|
committer | Connor Brewster <cbrewster@hey.com> | 2023-09-20T14·21+0000 |
commit | 6b7c936bc50934b45df132f659292e2c45256dea (patch) | |
tree | 74b369688e63ed4ff34c9270584ba30b91d7c979 /tvix/store/src/fuse/inodes.rs | |
parent | 237c0eb415c632ec3480d890084c3d815298ac1f (diff) |
refactor(tvix/store/fuse): Switch from fuser to fuse-backend-rs r/6621
This switches the FUSE implementation from fuser to fuse-backend-rs. fuse-backend-rs is designed to work with both FUSE and virtiofs. Virtiofs support will make it possible to plug the tvix-store into a microvm and have `/nix/store` access without having to setup FUSE inside the guest. Additionally fuse-backend-rs has nice support for running multiple FUSE threads and has some async support. The goal of this commit is to mechanically switch over to fuse-backend-rs with minimal changes. I did have to add some locks here and there because fuse-backend-rs uses `&self` on all methods whereas fuser uses `&mut self`. `&self` is required for concurrent access to the FUSE server, so this makes sense. We can consider switching to concurrent maps and use some other techniques to reduce lock contention and critical section size. Issue: https://b.tvl.fyi/issues/305 Change-Id: Icde5a58c6eef98f8984c1e04e980b756dfb76b47 Reviewed-on: https://cl.tvl.fyi/c/depot/+/9341 Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
Diffstat (limited to 'tvix/store/src/fuse/inodes.rs')
-rw-r--r-- | tvix/store/src/fuse/inodes.rs | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/tvix/store/src/fuse/inodes.rs b/tvix/store/src/fuse/inodes.rs index f44dde7b804f..e8959ce3629b 100644 --- a/tvix/store/src/fuse/inodes.rs +++ b/tvix/store/src/fuse/inodes.rs @@ -66,13 +66,3 @@ impl From<proto::Directory> for InodeData { InodeData::Directory(DirectoryInodeData::Populated(digest, children)) } } - -impl From<&InodeData> for fuser::FileType { - fn from(val: &InodeData) -> Self { - match val { - InodeData::Regular(..) => fuser::FileType::RegularFile, - InodeData::Symlink(_) => fuser::FileType::Symlink, - InodeData::Directory(..) => fuser::FileType::Directory, - } - } -} |