diff options
author | Florian Klink <flokli@flokli.de> | 2022-12-28T16·17+0100 |
---|---|---|
committer | flokli <flokli@flokli.de> | 2022-12-30T20·25+0000 |
commit | 319c03f63413a82d9266ed939eba7f7e552dd2b2 (patch) | |
tree | 7ed69310905fd8f4d7250aca3eb0976119f62a70 /tvix/store/src/dummy_blob_service.rs | |
parent | 0bf2b0ef1164aae0ad692066e8cfc0b243a89e4d (diff) |
feat(tvix/store): add logging with tracing r/5558
This uses [tracing](https://github.com/tokio-rs/tracing) for logs/ tracing. Annotate all method handlers with an instrument macro, and warn! a message for them being unimplemented. Co-Authored-By: Márton Boros <martonboros@gmail.com> Change-Id: Id42a41db33782d82abfb8dc0e49a8915000e5d89 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7665 Reviewed-by: tazjin <tazjin@tvl.su> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/store/src/dummy_blob_service.rs')
-rw-r--r-- | tvix/store/src/dummy_blob_service.rs | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/tvix/store/src/dummy_blob_service.rs b/tvix/store/src/dummy_blob_service.rs index 7731ea3344e3..690f6bde3869 100644 --- a/tvix/store/src/dummy_blob_service.rs +++ b/tvix/store/src/dummy_blob_service.rs @@ -7,6 +7,9 @@ use crate::proto::PutBlobResponse; use crate::proto::ReadBlobRequest; use crate::proto::StatBlobRequest; use tonic::{Request, Response, Result, Status, Streaming}; +use tracing::{instrument, warn}; + +const NOT_IMPLEMENTED_MSG: &str = "not implemented"; pub struct DummyBlobService {} @@ -14,21 +17,27 @@ pub struct DummyBlobService {} impl BlobService for DummyBlobService { type ReadStream = ReceiverStream<Result<BlobChunk>>; + #[instrument(skip(self))] async fn stat(&self, _request: Request<StatBlobRequest>) -> Result<Response<BlobMeta>> { - Err(Status::unimplemented("not implemented")) + warn!(NOT_IMPLEMENTED_MSG); + Err(Status::unimplemented(NOT_IMPLEMENTED_MSG)) } + #[instrument(skip(self))] async fn read( &self, _request: Request<ReadBlobRequest>, ) -> Result<Response<Self::ReadStream>, Status> { - Err(Status::unimplemented("not implemented")) + warn!(NOT_IMPLEMENTED_MSG); + Err(Status::unimplemented(NOT_IMPLEMENTED_MSG)) } + #[instrument(skip(self, _request))] async fn put( &self, _request: Request<Streaming<BlobChunk>>, ) -> Result<Response<PutBlobResponse>> { - Err(Status::unimplemented("not implemented")) + warn!(NOT_IMPLEMENTED_MSG); + Err(Status::unimplemented(NOT_IMPLEMENTED_MSG)) } } |