diff options
author | Florian Klink <flokli@flokli.de> | 2023-07-20T10·37+0300 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2023-07-21T19·01+0000 |
commit | a6580748aabe7fcbea735396ac700661b6c53e87 (patch) | |
tree | fab2df50c860f6ddc6730693223aa42e0416dca0 /tvix/store/src/directoryservice/grpc.rs | |
parent | 72e82ffcb11b1aaf1f1cc8db4189ced5ec0aa42e (diff) |
feat(tvix/store/digests): use bytes::Bytes instead of Vec<u8> r/6437
This will save us some copies, because a clone will simply create an additional pointer to the same data. Change-Id: I017a5d6b4c85a861b5541ebad2858ad4fbf8e8fa Reviewed-on: https://cl.tvl.fyi/c/depot/+/8978 Reviewed-by: raitobezarius <tvl@lahfa.xyz> Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/store/src/directoryservice/grpc.rs')
-rw-r--r-- | tvix/store/src/directoryservice/grpc.rs | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/tvix/store/src/directoryservice/grpc.rs b/tvix/store/src/directoryservice/grpc.rs index b9a5036a9140..e6f34b2bd80c 100644 --- a/tvix/store/src/directoryservice/grpc.rs +++ b/tvix/store/src/directoryservice/grpc.rs @@ -142,12 +142,13 @@ impl DirectoryService for GRPCDirectoryService { .spawn(async move { grpc_client.put(tokio_stream::iter(vec![directory])).await }); match self.tokio_handle.block_on(task)? { - Ok(put_directory_resp) => Ok(B3Digest::from_vec( - put_directory_resp.into_inner().root_digest, - ) - .map_err(|_| { - Error::StorageError("invalid root digest length in response".to_string()) - })?), + Ok(put_directory_resp) => Ok(put_directory_resp + .into_inner() + .root_digest + .try_into() + .map_err(|_| { + Error::StorageError("invalid root digest length in response".to_string()) + })?), Err(e) => Err(crate::Error::StorageError(e.to_string())), } } @@ -265,7 +266,7 @@ impl Iterator for StreamIterator { for child_directory in &directory.directories { // We ran validate() above, so we know these digests must be correct. let child_directory_digest = - B3Digest::from_vec(child_directory.digest.clone()).unwrap(); + child_directory.digest.clone().try_into().unwrap(); self.expected_directory_digests .insert(child_directory_digest); @@ -355,7 +356,7 @@ impl DirectoryPutter for GRPCPutter { .map_err(|e| Error::StorageError(e.to_string()))? .root_digest; - B3Digest::from_vec(root_digest).map_err(|_| { + root_digest.try_into().map_err(|_| { Error::StorageError("invalid root digest length in response".to_string()) }) } |