diff options
| author | Florian Klink <flokli@flokli.de> | 2023-06-12T12·13+0300 |
|---|---|---|
| committer | flokli <flokli@flokli.de> | 2023-06-12T12·43+0000 |
| commit | 64a4f6185c5dcd96ee57978963324ea50f4dd6f7 (patch) | |
| tree | 2bf4136908835b3b766c736e5f7713f05f664b69 /tvix/store/src/blobservice/mod.rs | |
| parent | b49f7cfec6a11816971d7d7c7cdcee3088bae7d2 (diff) | |
refactor(tvix/store/blobsvc): drop Result<_,_> around open_write r/6278
We never returned Err here anyways, and we can still return an error during the first (or subsequent) write(s). Change-Id: I4b4cd3d35f6ea008e9ffe2f7b71bfc9187309e2f Reviewed-on: https://cl.tvl.fyi/c/depot/+/8750 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: tazjin <tazjin@tvl.su>
Diffstat (limited to 'tvix/store/src/blobservice/mod.rs')
| -rw-r--r-- | tvix/store/src/blobservice/mod.rs | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tvix/store/src/blobservice/mod.rs b/tvix/store/src/blobservice/mod.rs index d9aa15bf2a46..c1bca927d7d0 100644 --- a/tvix/store/src/blobservice/mod.rs +++ b/tvix/store/src/blobservice/mod.rs @@ -24,8 +24,7 @@ pub trait BlobService: Send + Sync { /// Insert a new blob into the store. Returns a [BlobWriter], which /// implements [io::Write] and a [BlobWriter::close]. - /// TODO: is there any reason we want this to be a Result<>, and not just T? - fn open_write(&self) -> Result<Box<dyn BlobWriter>, Error>; + fn open_write(&self) -> Box<dyn BlobWriter>; } /// A [io::Write] that you need to close() afterwards, and get back the digest |