about summary refs log tree commit diff
path: root/tvix/store/src/blobservice/grpc.rs
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2023-06-12T12·13+0300
committerflokli <flokli@flokli.de>2023-06-12T12·43+0000
commit64a4f6185c5dcd96ee57978963324ea50f4dd6f7 (patch)
tree2bf4136908835b3b766c736e5f7713f05f664b69 /tvix/store/src/blobservice/grpc.rs
parentb49f7cfec6a11816971d7d7c7cdcee3088bae7d2 (diff)
refactor(tvix/store/blobsvc): drop Result<_,_> around open_write r/6278
We never returned Err here anyways, and we can still return an error
during the first (or subsequent) write(s).

Change-Id: I4b4cd3d35f6ea008e9ffe2f7b71bfc9187309e2f
Reviewed-on: https://cl.tvl.fyi/c/depot/+/8750
Autosubmit: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
Reviewed-by: tazjin <tazjin@tvl.su>
Diffstat (limited to 'tvix/store/src/blobservice/grpc.rs')
-rw-r--r--tvix/store/src/blobservice/grpc.rs10
1 files changed, 5 insertions, 5 deletions
diff --git a/tvix/store/src/blobservice/grpc.rs b/tvix/store/src/blobservice/grpc.rs
index 46ec64bce7..6f04c6a3d4 100644
--- a/tvix/store/src/blobservice/grpc.rs
+++ b/tvix/store/src/blobservice/grpc.rs
@@ -121,9 +121,9 @@ impl BlobService for GRPCBlobService {
         }
     }
 
-    /// Returns a [Self::BlobWriter], that'll internally wrap each write in a
-    // [proto::BlobChunk] and which is passed to the
-    fn open_write(&self) -> Result<Box<dyn BlobWriter>, crate::Error> {
+    /// Returns a BlobWriter, that'll internally wrap each write in a
+    // [proto::BlobChunk], which is send to the gRPC server.
+    fn open_write(&self) -> Box<dyn BlobWriter> {
         let mut grpc_client = self.grpc_client.clone();
 
         // set up an mpsc channel passing around Bytes.
@@ -155,11 +155,11 @@ impl BlobService for GRPCBlobService {
         // … which is then turned into a [io::Write].
         let writer = SyncIoBridge::new(async_writer);
 
-        Ok(Box::new(GRPCBlobWriter {
+        Box::new(GRPCBlobWriter {
             tokio_handle: self.tokio_handle.clone(), // TODO: is the clone() ok here?
             task_and_writer: Some((task, writer)),
             digest: None,
-        }))
+        })
     }
 }