diff options
author | Florian Klink <flokli@flokli.de> | 2023-09-03T14·39+0300 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2023-09-05T21·13+0000 |
commit | f499d2e031c100b6e1af53c8d77c045667ec1909 (patch) | |
tree | f914733205f170c4ab9bafe5f69e39181c30a826 /tvix/store/src/bin | |
parent | f9b5fc49b123cb4db3941ee2ae9b891f5262deef (diff) |
feat(tvix/store): fix ctrl-c handling on mount command r/6557
This enables the tokio `signal` feature, and registers a ctrl_c signal handler, which will use the unmount handle to unmount in case a ctrl-c signal is received. This avoids having disconnected mountpoints when Ctrl-C'ing a `tvix-store mount` invocation. In case the filesystem is unmounted externally (via `umount /path/to/ mountpoint`), the future is waiting for the signal is never resolved and the task is stopped. Change-Id: I149f705a6cb50188177f2a6c6a5fcd77218e2a3f Reviewed-on: https://cl.tvl.fyi/c/depot/+/9218 Reviewed-by: tazjin <tazjin@tvl.su> Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/store/src/bin')
-rw-r--r-- | tvix/store/src/bin/tvix-store.rs | 27 |
1 files changed, 24 insertions, 3 deletions
diff --git a/tvix/store/src/bin/tvix-store.rs b/tvix/store/src/bin/tvix-store.rs index d2a8927351f9..c11af5765bd9 100644 --- a/tvix/store/src/bin/tvix-store.rs +++ b/tvix/store/src/bin/tvix-store.rs @@ -264,16 +264,37 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { directory_service.clone(), )?; - tokio::task::spawn_blocking(move || { + let mut fuse_session = tokio::task::spawn_blocking(move || { let f = FUSE::new( blob_service, directory_service, path_info_service, list_root, ); - fuser::mount2(f, &dest, &[]) + + fuser::Session::new(f, &dest, &[]) + }) + .await??; + + // grab a handle to unmount the file system, and register a signal + // handler. + let mut fuse_unmounter = fuse_session.unmount_callable(); + tokio::spawn(async move { + tokio::signal::ctrl_c().await.unwrap(); + info!("interrupt received, unmounting…"); + fuse_unmounter.unmount().unwrap(); + }); + + // Start the fuse filesystem and wait for its completion, which + // happens when it's unmounted externally, or via the signal handler + // task. + tokio::task::spawn_blocking(move || -> io::Result<()> { + info!("mounting tvix-store on {:?}", fuse_session.mountpoint()); + let res = fuse_session.run()?; + info!("unmount occured, terminating…"); + Ok(res) }) - .await?? + .await??; } }; Ok(()) |