about summary refs log tree commit diff
path: root/tvix/store/protos/rpc_blobstore_grpc.pb.go
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2023-09-17T12·32+0300
committerflokli <flokli@flokli.de>2023-09-18T10·33+0000
commitca25acf11bae5cd66ed050f354879593ce6bf86a (patch)
tree54bab17442b38dbf35c040042274a3a236ae90b9 /tvix/store/protos/rpc_blobstore_grpc.pb.go
parentbf2fe88a5c0c7f778502f87ddacb5072919d455e (diff)
chore(tvix/store/protos): drop unused fields for now r/6608
This wasn't removed yet, and no code is using/populating it so far.

It's confusing, let's update it to the state of things now, and re-
introduce it once we get there.

Change-Id: I68f5ba17a8eee604d8ccd82749da7c8be094cb99
Reviewed-on: https://cl.tvl.fyi/c/depot/+/9351
Reviewed-by: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/store/protos/rpc_blobstore_grpc.pb.go')
-rw-r--r--tvix/store/protos/rpc_blobstore_grpc.pb.go16
1 files changed, 6 insertions, 10 deletions
diff --git a/tvix/store/protos/rpc_blobstore_grpc.pb.go b/tvix/store/protos/rpc_blobstore_grpc.pb.go
index 3842ea288544..531ebcd2c637 100644
--- a/tvix/store/protos/rpc_blobstore_grpc.pb.go
+++ b/tvix/store/protos/rpc_blobstore_grpc.pb.go
@@ -31,12 +31,10 @@ const (
 //
 // For semantics around ctx use and closing/ending streaming RPCs, please refer to https://pkg.go.dev/google.golang.org/grpc/?tab=doc#ClientConn.NewStream.
 type BlobServiceClient interface {
-	// Stat exposes metadata about a given blob,
+	// In the future, Stat will expose more metadata about a given blob,
 	// such as more granular chunking, baos.
-	// It implicitly allows checking for existence too, as asking this for a
-	// non-existing Blob will return a Status::not_found grpc error.
-	// If there's no more granular chunking available, the response will simply
-	// contain a single chunk.
+	// For now, it's only used to check for the existence of a blob, as asking
+	// this for a non-existing Blob will return a Status::not_found gRPC error.
 	Stat(ctx context.Context, in *StatBlobRequest, opts ...grpc.CallOption) (*BlobMeta, error)
 	// Read returns a stream of BlobChunk, which is just a stream of bytes with
 	// the digest specified in ReadBlobRequest.
@@ -138,12 +136,10 @@ func (x *blobServicePutClient) CloseAndRecv() (*PutBlobResponse, error) {
 // All implementations must embed UnimplementedBlobServiceServer
 // for forward compatibility
 type BlobServiceServer interface {
-	// Stat exposes metadata about a given blob,
+	// In the future, Stat will expose more metadata about a given blob,
 	// such as more granular chunking, baos.
-	// It implicitly allows checking for existence too, as asking this for a
-	// non-existing Blob will return a Status::not_found grpc error.
-	// If there's no more granular chunking available, the response will simply
-	// contain a single chunk.
+	// For now, it's only used to check for the existence of a blob, as asking
+	// this for a non-existing Blob will return a Status::not_found gRPC error.
 	Stat(context.Context, *StatBlobRequest) (*BlobMeta, error)
 	// Read returns a stream of BlobChunk, which is just a stream of bytes with
 	// the digest specified in ReadBlobRequest.