diff options
| author | Florian Klink <flokli@flokli.de> | 2023-10-11T11·08+0200 |
|---|---|---|
| committer | flokli <flokli@flokli.de> | 2023-10-11T15·29+0000 |
| commit | 8ced43f3c79d61c91c88ad86b8f7b801b94d93f3 (patch) | |
| tree | f94be36e433f392cd1a96d2de441c2800823ba67 /tvix/store/protos/pathinfo_test.go | |
| parent | 6dab6081985dc0ccda0fcbcd45714ac122c229ef (diff) | |
feat(tvix/store/protos): validate NarSha256 r/6785
Change-Id: I016d1b020b04850f0dca68c2ea96643230dada10 Reviewed-on: https://cl.tvl.fyi/c/depot/+/9649 Reviewed-by: Brian McGee <brian@bmcgee.ie> Tested-by: BuildkiteCI
Diffstat (limited to '')
| -rw-r--r-- | tvix/store/protos/pathinfo_test.go | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/tvix/store/protos/pathinfo_test.go b/tvix/store/protos/pathinfo_test.go index adac30a97f..74af50e569 100644 --- a/tvix/store/protos/pathinfo_test.go +++ b/tvix/store/protos/pathinfo_test.go @@ -34,7 +34,7 @@ func genPathInfoSymlink() *storev1pb.PathInfo { References: [][]byte{exampleStorePathDigest}, Narinfo: &storev1pb.NARInfo{ NarSize: 0, - NarSha256: []byte{}, + NarSha256: []byte{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}, Signatures: []*storev1pb.NARInfo_Signature{}, ReferenceNames: []string{EXAMPLE_STORE_PATH}, }, @@ -61,6 +61,16 @@ func TestValidate(t *testing.T) { assert.Equal(t, "00000000000000000000000000000000-dummy", storePath.String()) }) + t.Run("invalid nar_sha256", func(t *testing.T) { + pi := genPathInfoSymlink() + + // create broken references, where the reference digest is wrong + pi.Narinfo.NarSha256 = []byte{0xbe, 0xef} + + _, err := pi.Validate() + assert.Error(t, err, "must not validate") + }) + t.Run("invalid reference digest", func(t *testing.T) { pi := genPathInfoSymlink() |