diff options
| author | Aspen Smith <root@gws.fyi> | 2024-07-06T00·29-0400 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2024-07-06T15·03+0000 |
| commit | dfe137786c98f7e610cf95dd7cbc1fc476a766fd (patch) | |
| tree | 2b03183b7cac856f2c5dd509027e3df58fc5db5c /tvix/serde/examples/nixpkgs.rs | |
| parent | d5964c1d548615aea1f3165c478ad91ad87822de (diff) | |
refactor(tvix/eval): Builderize Evaluation r/8351
Make constructing of a new Evaluation use the builder pattern rather than setting public mutable fields. This is currently a pure refactor (no functionality has changed) but has a few advantages: - We've encapsulated the internals of the fields in Evaluation, meaning we can change them without too much breakage of clients - We have type safety that prevents us from ever changing the fields of an Evaluation after it's built (which matters more in a world where we reuse Evaluations). More importantly, this paves the road for doing different things with the construction of an Evaluation - notably, sharing certain things like the GlobalsMap across subsequent evaluations in eg the REPL. Fixes: b/262 Change-Id: I4a27116faac14cdd144fc7c992d14ae095a1aca4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11956 Tested-by: BuildkiteCI Autosubmit: aspen <root@gws.fyi> Reviewed-by: flokli <flokli@flokli.de>
Diffstat (limited to 'tvix/serde/examples/nixpkgs.rs')
| -rw-r--r-- | tvix/serde/examples/nixpkgs.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tvix/serde/examples/nixpkgs.rs b/tvix/serde/examples/nixpkgs.rs index ad8c4160b5d0..e3c589dba118 100644 --- a/tvix/serde/examples/nixpkgs.rs +++ b/tvix/serde/examples/nixpkgs.rs @@ -23,8 +23,8 @@ fn main() { } "#; - let result = tvix_serde::from_str_with_config::<Config, _>(code, |eval| { - eval.enable_impure(None); + let result = tvix_serde::from_str_with_config::<Config, _>(code, |eval_builder| { + eval_builder.enable_impure(None) }); match result { |