diff options
author | Florian Klink <flokli@flokli.de> | 2023-08-19T20·01+0200 |
---|---|---|
committer | flokli <flokli@flokli.de> | 2023-08-20T22·19+0000 |
commit | 0193f07642db752c3e14e02064c02b0fd1cc060b (patch) | |
tree | 85130551dd210f650bc66b4a1dc2d612bbaa5e0c /tvix/serde/.skip-subtree | |
parent | 4017039595fc85c02c8c313b73073220954b9f5a (diff) |
refactor(tvix/nix-compat/nixhash): validate digest lengths r/6512
There was a NixHash::new() before, which didn't perform any validation of the digest length. We had some length validation when parsing nix hashes or SRI hashes, but some places didn't perform validation and/or constructed the struct directly. Replace NixHash::new() with a `impl TryFrom<(HashAlgo, Vec<u8>)> for NixHash`, which does do this validation, and update constructing code to use that, rather than populating structs directly. In some rare cases where we're sure the digest length is correct we still populate the struct manually. Fixes b/291. Change-Id: I7a323c5b18d94de0ec15e391b3e7586df42f4229 Reviewed-on: https://cl.tvl.fyi/c/depot/+/9109 Reviewed-by: raitobezarius <tvl@lahfa.xyz> Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/serde/.skip-subtree')
0 files changed, 0 insertions, 0 deletions