about summary refs log tree commit diff
path: root/tvix/nar-bridge
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2023-10-09T17·46+0200
committerclbot <clbot@tvl.fyi>2023-10-09T22·01+0000
commit92481825b36f914bc99cbb15d560865d808b2306 (patch)
tree1448b5d8ec6b41f487c445670ba55524132b7555 /tvix/nar-bridge
parent67ccbf8c946ee18d45ec0d8c43d69d6809a4d644 (diff)
test(tvix/store/protos): add go tests for Validate() r/6757
We already have validation tests for Rust, let's add the missing ones
for golang too.

Change-Id: Iaf3a3e1ee72d5647da3f2aa977d6e0d0379b2ce5
Reviewed-on: https://cl.tvl.fyi/c/depot/+/9595
Reviewed-by: Brian McGee <brian@bmcgee.ie>
Autosubmit: flokli <flokli@flokli.de>
Tested-by: BuildkiteCI
Diffstat (limited to 'tvix/nar-bridge')
-rw-r--r--tvix/nar-bridge/pkg/exporter/export.go3
1 files changed, 0 insertions, 3 deletions
diff --git a/tvix/nar-bridge/pkg/exporter/export.go b/tvix/nar-bridge/pkg/exporter/export.go
index 40ccc4b6380c..1f898ccad6dd 100644
--- a/tvix/nar-bridge/pkg/exporter/export.go
+++ b/tvix/nar-bridge/pkg/exporter/export.go
@@ -194,9 +194,6 @@ func Export(
 	}
 }
 
-// TODO: add validation functions to Directory in both rust and golang, to
-// validate the keys in directories, files and symlinks are sorted.
-
 // drainNextNode will drain a directory message with one of its child nodes,
 // whichever comes first alphabetically.
 func drainNextNode(d *castorev1pb.Directory) interface{} {