diff options
author | Florian Klink <flokli@flokli.de> | 2024-06-13T07·26+0300 |
---|---|---|
committer | clbot <clbot@tvl.fyi> | 2024-06-13T16·16+0000 |
commit | 99c5a2e8bcb83e595d2c12bf7296338b1687f9de (patch) | |
tree | de564c7c639f696f5d4a435c4fa910b9114ab2fd /tvix/glue/src/builtins | |
parent | 7ee55c293cc47a6b3bebacd4d991aa9aa9cc7287 (diff) |
feat(tvix/glue): report progress on all fetches, use progress bars r/8259
This should also report progress on fetches which we couldn't delay until actually having to IO into them, like `builtins.fetchurl` calls without a upfront-provided hash. While at it, upgrade the progress spinners to progress bars, which increment if we know the size of the fetch. Change-Id: Ic3f332286d8bc2177f3d994ba25b165728d4b702 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11797 Autosubmit: flokli <flokli@flokli.de> Tested-by: BuildkiteCI Reviewed-by: aspen <root@gws.fyi>
Diffstat (limited to 'tvix/glue/src/builtins')
-rw-r--r-- | tvix/glue/src/builtins/fetchers.rs | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/tvix/glue/src/builtins/fetchers.rs b/tvix/glue/src/builtins/fetchers.rs index 08a882586e9b..d95287aeca3a 100644 --- a/tvix/glue/src/builtins/fetchers.rs +++ b/tvix/glue/src/builtins/fetchers.rs @@ -7,7 +7,6 @@ use crate::{ }; use nix_compat::nixhash; use std::rc::Rc; -use tracing::info; use tvix_eval::builtin_macros::builtins; use tvix_eval::generators::Gen; use tvix_eval::generators::GenCo; @@ -112,8 +111,6 @@ pub(crate) mod fetcher_builtins { } None => { // If we don't have enough info, do the fetch now. - info!(?fetch, "triggering required fetch"); - let (store_path, _root_node) = state .tokio_handle .block_on(async { state.fetcher.ingest_and_persist(&name, fetch).await }) |