diff options
| author | Ryan Lahfa <tvl@lahfa.xyz> | 2024-01-14T00·41+0100 |
|---|---|---|
| committer | clbot <clbot@tvl.fyi> | 2024-01-17T17·31+0000 |
| commit | f71bb351d29f58935e6002615cd94d6e6259bf26 (patch) | |
| tree | 168311dd206ec4524db0105d8109e0ba4d698ec7 /tvix/eval | |
| parent | 75cc52ddb136e66b1a79117425fb35f80dcecc07 (diff) | |
feat(tvix/glue): introduce test suite for context strings r/7404
This is an additional test suite on the top of the Nix ones for context strings matters. It already smoked out multiple mistakes and potential bugs and non-deterministic result from the evaluator. It uses a similar technology as the one in the tvix-eval albeit we instantiate a fully fledged evaluator with in-memory store. We copy the files instead of symlinking them because crates are built in isolation, so symlinks cannot work. Change-Id: I63ae225ce4f83c6e2c8ccd60d779c2f8eb9d08fb Reviewed-on: https://cl.tvl.fyi/c/depot/+/10619 Autosubmit: raitobezarius <tvl@lahfa.xyz> Tested-by: BuildkiteCI Reviewed-by: flokli <flokli@flokli.de>
Diffstat (limited to 'tvix/eval')
| -rw-r--r-- | tvix/eval/src/tests/mod.rs | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/tvix/eval/src/tests/mod.rs b/tvix/eval/src/tests/mod.rs index 2dceeadc7ae9..7509379fdab6 100644 --- a/tvix/eval/src/tests/mod.rs +++ b/tvix/eval/src/tests/mod.rs @@ -166,14 +166,6 @@ fn nix_eval_okay(#[files("src/tests/nix_tests/eval-okay-*.nix")] code_path: Path // notyetpassing; this makes the test suite much more useful for // regression testing, since there should always be zero non-ignored // failing tests. -// -// Unfortunately test_generator is unmaintained, so the PRs to make -// it understand #[ignored] has been sitting for two years, so we -// can't use `cargo test --include-ignored`, which is the normal way -// of handling this situation. -// -// https://github.com/frehberg/test-generator/pull/10 -// https://github.com/frehberg/test-generator/pull/8 #[rstest] fn nix_eval_okay_currently_failing( #[files("src/tests/nix_tests/notyetpassing/eval-okay-*.nix")] code_path: PathBuf, |